Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix k2 installation in Docker with CUDA 12 #6709

Merged

Conversation

github-actions[bot]
Copy link
Contributor

What does this PR do ?

Fix k2 installation in Docker with CUDA 12.
Currently k2 is not installed in Docker (fails silently).
Relies on a fix in k2-fsa/k2#1200

Collection: [ASR]

Changelog

  • fix k2 installation source in scripts/speech_recognition/k2/setup.sh

Usage

import k2
# do anything you want with k2

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Copy link
Collaborator

@artbataev artbataev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cherry-pick from r1.19.0

@artbataev artbataev merged commit ae4d4ee into main May 24, 2023
1 check passed
@artbataev artbataev deleted the cherry-pick-main-0ca1dd3685995267b49193236a6ca0d27aea75a6 branch May 24, 2023 14:09
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
Signed-off-by: Vladimir Bataev <[email protected]>
Co-authored-by: Vladimir Bataev <[email protected]>
Signed-off-by: hsiehjackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant