Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix k2 installation in Docker with CUDA 12 #6707

Merged
merged 1 commit into from
May 23, 2023
Merged

Fix k2 installation in Docker with CUDA 12 #6707

merged 1 commit into from
May 23, 2023

Conversation

artbataev
Copy link
Collaborator

What does this PR do ?

Fix k2 installation in Docker with CUDA 12.
Currently k2 is not installed in Docker (fails silently).
Relies on a fix in k2-fsa/k2#1200

Collection: [ASR]

Changelog

  • fix k2 installation source in scripts/speech_recognition/k2/setup.sh

Usage

import k2
# do anything you want with k2

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@artbataev artbataev requested review from GNroy and titu1994 May 23, 2023 17:10
Copy link
Collaborator

@GNroy GNroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lets put a reminder somewhere to take a look every 2-weeks if K2 has released the required version

@titu1994 titu1994 merged commit 0ca1dd3 into r1.19.0 May 23, 2023
8 of 10 checks passed
@titu1994 titu1994 deleted the fix_k2_cuda12 branch May 23, 2023 17:19
github-actions bot pushed a commit that referenced this pull request May 23, 2023
artbataev added a commit that referenced this pull request May 24, 2023
Signed-off-by: Vladimir Bataev <[email protected]>
Co-authored-by: Vladimir Bataev <[email protected]>
hsiehjackson pushed a commit to hsiehjackson/NeMo that referenced this pull request Jun 2, 2023
Signed-off-by: Vladimir Bataev <[email protected]>
Co-authored-by: Vladimir Bataev <[email protected]>
Signed-off-by: hsiehjackson <[email protected]>
yaoyu-33 pushed a commit that referenced this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants