Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sharding for speechlm and vlm #11876

Merged
merged 3 commits into from
Jan 23, 2025
Merged

Add sharding for speechlm and vlm #11876

merged 3 commits into from
Jan 23, 2025

Conversation

BoxiangW
Copy link
Collaborator

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@BoxiangW
Copy link
Collaborator Author

I will add SpeechLM fsdp2 ci tesst once the speechlm ci test is ready

Signed-off-by: Boxiang Wang <[email protected]>
Copy link
Contributor

beep boop 🤖: 🚨 The following files must be fixed before merge!


Your code was analyzed with PyLint. The following annotations have been identified:

************* Module nemo.collections.speechlm.models.hf_auto_model_for_speech_seq2seq
nemo/collections/speechlm/models/hf_auto_model_for_speech_seq2seq.py:27:0: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/speechlm/models/hf_auto_model_for_speech_seq2seq.py:35:0: C0115: Missing class docstring (missing-class-docstring)
nemo/collections/speechlm/models/hf_auto_model_for_speech_seq2seq.py:60:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/speechlm/models/hf_auto_model_for_speech_seq2seq.py:73:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/speechlm/models/hf_auto_model_for_speech_seq2seq.py:79:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/speechlm/models/hf_auto_model_for_speech_seq2seq.py:82:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/speechlm/models/hf_auto_model_for_speech_seq2seq.py:105:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/speechlm/models/hf_auto_model_for_speech_seq2seq.py:112:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/speechlm/models/hf_auto_model_for_speech_seq2seq.py:124:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/speechlm/models/hf_auto_model_for_speech_seq2seq.py:129:4: C0116: Missing function or method docstring (missing-function-docstring)

-----------------------------------
Your code has been rated at 9.39/10

Mitigation guide:

  • Add sensible and useful docstrings to functions and methods
  • For trivial methods like getter/setters, consider adding # pylint: disable=C0116 inside the function itself
  • To disable multiple functions/methods at once, put a # pylint: disable=C0116 before the first and a # pylint: enable=C0116 after the last.

By applying these rules, we reduce the occurance of this message in future.

Thank you for improving NeMo's documentation!

Copy link
Contributor

beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base.


Your code was analyzed with PyLint. The following annotations have been identified:

************* Module nemo.lightning.pytorch.strategies.utils
nemo/lightning/pytorch/strategies/utils.py:40:0: C0115: Missing class docstring (missing-class-docstring)
nemo/lightning/pytorch/strategies/utils.py:49:0: C0116: Missing function or method docstring (missing-function-docstring)
nemo/lightning/pytorch/strategies/utils.py:57:0: C0116: Missing function or method docstring (missing-function-docstring)
nemo/lightning/pytorch/strategies/utils.py:69:0: C0116: Missing function or method docstring (missing-function-docstring)
nemo/lightning/pytorch/strategies/utils.py:85:0: C0116: Missing function or method docstring (missing-function-docstring)
nemo/lightning/pytorch/strategies/utils.py:120:0: C0116: Missing function or method docstring (missing-function-docstring)
nemo/lightning/pytorch/strategies/utils.py:142:0: C0116: Missing function or method docstring (missing-function-docstring)
nemo/lightning/pytorch/strategies/utils.py:197:0: C0116: Missing function or method docstring (missing-function-docstring)

-----------------------------------
Your code has been rated at 9.61/10

Mitigation guide:

  • Add sensible and useful docstrings to functions and methods
  • For trivial methods like getter/setters, consider adding # pylint: disable=C0116 inside the function itself
  • To disable multiple functions/methods at once, put a # pylint: disable=C0116 before the first and a # pylint: enable=C0116 after the last.

By applying these rules, we reduce the occurance of this message in future.

Thank you for improving NeMo's documentation!

Copy link
Contributor

[🤖]: Hi @BoxiangW 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@BoxiangW BoxiangW requested a review from akoumpa January 17, 2025 22:15
Copy link
Member

@akoumpa akoumpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@akoumpa
Copy link
Member

akoumpa commented Jan 23, 2025

@pablo-garay can you merge this? Thanks.

@ko3n1g ko3n1g merged commit cc365b6 into main Jan 23, 2025
209 of 216 checks passed
@ko3n1g ko3n1g deleted the boxiangw/fsdp2-sharding branch January 23, 2025 20:00
parthmannan pushed a commit that referenced this pull request Jan 28, 2025
* Add sharding for speechlm and vlm

Signed-off-by: Boxiang Wang <[email protected]>

* Add ci test for VLM

Signed-off-by: Boxiang Wang <[email protected]>

* Apply isort and black reformatting

Signed-off-by: BoxiangW <[email protected]>

---------

Signed-off-by: Boxiang Wang <[email protected]>
Signed-off-by: BoxiangW <[email protected]>
Co-authored-by: BoxiangW <[email protected]>
Signed-off-by: Parth Mannan <[email protected]>
abhinavg4 pushed a commit that referenced this pull request Jan 30, 2025
* Add sharding for speechlm and vlm

Signed-off-by: Boxiang Wang <[email protected]>

* Add ci test for VLM

Signed-off-by: Boxiang Wang <[email protected]>

* Apply isort and black reformatting

Signed-off-by: BoxiangW <[email protected]>

---------

Signed-off-by: Boxiang Wang <[email protected]>
Signed-off-by: BoxiangW <[email protected]>
Co-authored-by: BoxiangW <[email protected]>
Signed-off-by: Abhinav Garg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants