Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pytorch-lightning #11306

Merged
merged 4 commits into from
Nov 18, 2024
Merged

Remove pytorch-lightning #11306

merged 4 commits into from
Nov 18, 2024

Conversation

maanug-nv
Copy link
Collaborator

What does this PR do ?

Use lightning instead of pytorch_lightning.
Depends on #11252 .

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@maanug-nv maanug-nv marked this pull request as ready for review November 18, 2024 02:28
@maanug-nv
update import in docs
c201fc2 
Signed-off-by: Maanu Grover <[email protected]>
@maanug-nv
update import in tutorials
7c59a7f 
Signed-off-by: Maanu Grover <[email protected]>
@maanug-nv
remove pl requirement
da46b5a 
Signed-off-by: Maanu Grover <[email protected]>
@maanug-nv
missed import updates
01a7624 
Signed-off-by: Maanu Grover <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

beep boop 🤖: 🚨 The following files must be fixed before merge!

Your code was analyzed with PyLint. The following annotations have been identified:

************* Module nemo.collections.tts.models.speechllm.megatron_base_speechllm_prompt_model
nemo/collections/tts/models/speechllm/megatron_base_speechllm_prompt_model.py:92:0: C0301: Line too long (121/119) (line-too-long)
nemo/collections/tts/models/speechllm/megatron_base_speechllm_prompt_model.py:186:0: C0301: Line too long (183/119) (line-too-long)
nemo/collections/tts/models/speechllm/megatron_base_speechllm_prompt_model.py:82:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/tts/models/speechllm/megatron_base_speechllm_prompt_model.py:405:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/tts/models/speechllm/megatron_base_speechllm_prompt_model.py:408:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/tts/models/speechllm/megatron_base_speechllm_prompt_model.py:411:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/tts/models/speechllm/megatron_base_speechllm_prompt_model.py:414:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/tts/models/speechllm/megatron_base_speechllm_prompt_model.py:421:4: C0116: Missing function or method docstring (missing-function-docstring)
************* Module nemo.collections.tts.models.speechllm.megatron_t5_speechllm_model
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:107:0: C0301: Line too long (180/119) (line-too-long)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:109:0: C0301: Line too long (140/119) (line-too-long)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:281:0: C0301: Line too long (137/119) (line-too-long)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:283:0: C0301: Line too long (125/119) (line-too-long)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:289:0: C0301: Line too long (125/119) (line-too-long)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:302:0: C0301: Line too long (121/119) (line-too-long)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:303:0: C0301: Line too long (121/119) (line-too-long)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:313:0: C0301: Line too long (121/119) (line-too-long)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:407:0: C0301: Line too long (150/119) (line-too-long)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:408:0: C0301: Line too long (127/119) (line-too-long)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:472:0: C0301: Line too long (146/119) (line-too-long)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:975:0: C0301: Line too long (123/119) (line-too-long)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:977:0: C0301: Line too long (128/119) (line-too-long)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:985:0: C0301: Line too long (130/119) (line-too-long)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:1741:0: C0301: Line too long (120/119) (line-too-long)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:1752:0: C0301: Line too long (130/119) (line-too-long)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:1792:0: C0301: Line too long (151/119) (line-too-long)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:1829:0: C0301: Line too long (122/119) (line-too-long)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:1831:0: C0301: Line too long (128/119) (line-too-long)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:1834:0: C0301: Line too long (130/119) (line-too-long)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:1869:0: C0301: Line too long (151/119) (line-too-long)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:1921:0: C0301: Line too long (151/119) (line-too-long)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:1969:0: C0301: Line too long (159/119) (line-too-long)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:2240:0: C0301: Line too long (123/119) (line-too-long)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:2639:0: C0301: Line too long (150/119) (line-too-long)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:86:0: C0115: Missing class docstring (missing-class-docstring)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:326:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:589:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:608:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:944:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:950:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:956:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:1069:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:1089:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:1107:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:1113:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:1519:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:1551:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:1630:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:1707:4: C0116: Missing function or method docstring (missing-function-docstring)
nemo/collections/tts/models/speechllm/megatron_t5_speechllm_model.py:2641:4: C0116: Missing function or method docstring (missing-function-docstring)

-----------------------------------
Your code has been rated at 9.68/10

Thank you for improving NeMo's documentation!

titu1994
titu1994 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@maanug-nv maanug-nv enabled auto-merge (squash) November 18, 2024 21:11
@github-actions GitHub Actions
Copy link
Contributor

[🤖]: Hi @maanug-nv 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully

So it might be time to merge this PR or get some approvals

I'm just a bot so I'll leave it you what to do next.

//cc @pablo-garay @ko3n1g

@maanug-nv maanug-nv merged commit bc9e6a8 into main Nov 18, 2024
163 of 166 checks passed
@maanug-nv maanug-nv deleted the maanug/remove-pl branch November 18, 2024 21:27
@jstjohn jstjohn mentioned this pull request Nov 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nithinraok nithinraok nithinraok approved these changes

@titu1994 titu1994 titu1994 approved these changes

Assignees
No one assigned
Labels
ASR audio NLP Run CICD Speaker Tasks TTS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maanug-nv @titu1994 @nithinraok