Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pytorch_lightning to pytorch.lightning when bumping NeMo version #456

Open
jstjohn opened this issue Nov 20, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@jstjohn
Copy link
Collaborator

jstjohn commented Nov 20, 2024

This will be required for our next version bump. All instances of pytorch_lightning in imports need to change to pytorch.lightning. We may also need to look at dependencies.

More info from a slack thread I am pasting below:

NVIDIA/NeMo#11306 and NVIDIA/NeMo#11252 have been merged, which replace all usage of pytorch_lightning with lightning.pytorch . pytorch_lightning should no longer be present in the container.
Going forward if you need to import something from Lightning, use import lightning.pytorch , import lightning.fabric , or from lightning... import ....
If you use import pytorch_lightning you'll likely see a ModuleNotFoundError, or errors similar to the one reported in this thread, especially if you try to inherit from pytorch_lightning .
Please see PRs for context.

@jstjohn jstjohn added the enhancement New feature or request label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant