Revert "mcp-client-cli: Note that client and server transports must match." #892
Conversation
…atch. (#…" This reverts commit c7d487d.
WalkthroughThis PR removes version 1.4 from docs/version listing, adjusts a sentence in MCP client docs, and downgrades numerous dependencies across examples and packages from nvidia-nat ~=1.4 to ~=1.3 (including various extras). No code logic changes are introduced. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
AnuradhaKaruppiah
added
bug
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
packages/nvidia_nat_all/pyproject.toml (1)
23-23: Keep extras sorted for consistency.Line 23 violates the “Keep sorted!!!” guidance because the extras are no longer in lexical order. Please restore the alphabetical order of the extras to match the rest of the dependency list.
- "nvidia-nat[gunicorn, async_endpoints]~=1.3", + "nvidia-nat[async_endpoints, gunicorn]~=1.3",packages/nvidia_nat_phoenix/pyproject.toml (1)
23-24: Restore alphabetical dependency orderLine 23 puts
nvidia-nat[opentelemetry]~=1.3ahead ofarize-phoenix~=11.28, contradicting the “Keep sorted!!!” directive. Reorder the entries alphabetically to match the file guidance.dependencies = [ - "nvidia-nat[opentelemetry]~=1.3", - "arize-phoenix~=11.28", + "arize-phoenix~=11.28", + "nvidia-nat[opentelemetry]~=1.3", ]Based on learnings
packages/nvidia_nat_crewai/pyproject.toml (1)
23-24: Restore sorted dependency order.The block is labeled “Keep sorted!!!”, but
nvidia-nat[litellm]still precedescrewai. Please swap them so the list is alphabetically sorted again.# Keep sorted!!! - "nvidia-nat[litellm]~=1.3", - "crewai~=0.193.2", + "crewai~=0.193.2", + "nvidia-nat[litellm]~=1.3",
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (63)
docs/source/versions1.json(1 hunks)docs/source/workflows/mcp/mcp-client.md(0 hunks)examples/HITL/por_to_jiratickets/pyproject.toml(1 hunks)examples/HITL/simple_calculator_hitl/pyproject.toml(1 hunks)examples/MCP/simple_auth_mcp/pyproject.toml(1 hunks)examples/MCP/simple_calculator_mcp/pyproject.toml(1 hunks)examples/RAG/simple_rag/pyproject.toml(1 hunks)examples/advanced_agents/alert_triage_agent/pyproject.toml(1 hunks)examples/advanced_agents/profiler_agent/pyproject.toml(1 hunks)examples/control_flow/router_agent/pyproject.toml(1 hunks)examples/control_flow/sequential_executor/pyproject.toml(1 hunks)examples/custom_functions/automated_description_generation/pyproject.toml(1 hunks)examples/custom_functions/plot_charts/pyproject.toml(1 hunks)examples/documentation_guides/workflows/text_file_ingest/pyproject.toml(1 hunks)examples/evaluation_and_profiling/email_phishing_analyzer/pyproject.toml(1 hunks)examples/evaluation_and_profiling/simple_calculator_eval/pyproject.toml(1 hunks)examples/evaluation_and_profiling/simple_web_query_eval/pyproject.toml(1 hunks)examples/evaluation_and_profiling/swe_bench/pyproject.toml(1 hunks)examples/frameworks/adk_demo/pyproject.toml(1 hunks)examples/frameworks/agno_personal_finance/pyproject.toml(1 hunks)examples/frameworks/haystack_deep_research_agent/pyproject.toml(1 hunks)examples/frameworks/multi_frameworks/pyproject.toml(1 hunks)examples/frameworks/semantic_kernel_demo/pyproject.toml(1 hunks)examples/front_ends/simple_auth/pyproject.toml(1 hunks)examples/front_ends/simple_calculator_custom_routes/pyproject.toml(1 hunks)examples/getting_started/simple_calculator/pyproject.toml(1 hunks)examples/getting_started/simple_web_query/pyproject.toml(1 hunks)examples/notebooks/first_search_agent/pyproject.toml(1 hunks)examples/notebooks/retail_sales_agent/pyproject.toml(1 hunks)examples/object_store/user_report/pyproject.toml(1 hunks)examples/observability/redact_pii/pyproject.toml(1 hunks)examples/observability/simple_calculator_observability/pyproject.toml(1 hunks)packages/compat/aiqtoolkit/pyproject.toml(1 hunks)packages/compat/aiqtoolkit_agno/pyproject.toml(1 hunks)packages/compat/aiqtoolkit_crewai/pyproject.toml(1 hunks)packages/compat/aiqtoolkit_langchain/pyproject.toml(1 hunks)packages/compat/aiqtoolkit_llama_index/pyproject.toml(1 hunks)packages/compat/aiqtoolkit_mem0ai/pyproject.toml(1 hunks)packages/compat/aiqtoolkit_semantic_kernel/pyproject.toml(1 hunks)packages/compat/aiqtoolkit_test/pyproject.toml(1 hunks)packages/compat/aiqtoolkit_weave/pyproject.toml(1 hunks)packages/compat/aiqtoolkit_zep_cloud/pyproject.toml(1 hunks)packages/nvidia_nat_adk/pyproject.toml(1 hunks)packages/nvidia_nat_agno/pyproject.toml(1 hunks)packages/nvidia_nat_all/pyproject.toml(1 hunks)packages/nvidia_nat_crewai/pyproject.toml(1 hunks)packages/nvidia_nat_data_flywheel/pyproject.toml(1 hunks)packages/nvidia_nat_ingestion/pyproject.toml(1 hunks)packages/nvidia_nat_langchain/pyproject.toml(1 hunks)packages/nvidia_nat_llama_index/pyproject.toml(1 hunks)packages/nvidia_nat_mcp/pyproject.toml(1 hunks)packages/nvidia_nat_mem0ai/pyproject.toml(1 hunks)packages/nvidia_nat_mysql/pyproject.toml(1 hunks)packages/nvidia_nat_opentelemetry/pyproject.toml(1 hunks)packages/nvidia_nat_phoenix/pyproject.toml(1 hunks)packages/nvidia_nat_profiling/pyproject.toml(1 hunks)packages/nvidia_nat_ragaai/pyproject.toml(1 hunks)packages/nvidia_nat_redis/pyproject.toml(1 hunks)packages/nvidia_nat_s3/pyproject.toml(1 hunks)packages/nvidia_nat_semantic_kernel/pyproject.toml(1 hunks)packages/nvidia_nat_test/pyproject.toml(1 hunks)packages/nvidia_nat_weave/pyproject.toml(1 hunks)packages/nvidia_nat_zep_cloud/pyproject.toml(1 hunks)
💤 Files with no reviewable changes (1)
- docs/source/workflows/mcp/mcp-client.md
🧰 Additional context used
📓 Path-based instructions (6)
**/*
⚙️ CodeRabbit configuration file
**/*: # Code Review Instructions
- Ensure the code follows best practices and coding standards. - For Python code, follow
PEP 20 and
PEP 8 for style guidelines.- Check for security vulnerabilities and potential issues. - Python methods should use type hints for all parameters and return values.
Example:def my_function(param1: int, param2: str) -> bool: pass- For Python exception handling, ensure proper stack trace preservation:
- When re-raising exceptions: use bare
raisestatements to maintain the original stack trace,
and uselogger.error()(notlogger.exception()) to avoid duplicate stack trace output.- When catching and logging exceptions without re-raising: always use
logger.exception()
to capture the full stack trace information.Documentation Review Instructions - Verify that documentation and comments are clear and comprehensive. - Verify that the documentation doesn't contain any TODOs, FIXMEs or placeholder text like "lorem ipsum". - Verify that the documentation doesn't contain any offensive or outdated terms. - Verify that documentation and comments are free of spelling mistakes, ensure the documentation doesn't contain any
words listed in the
ci/vale/styles/config/vocabularies/nat/reject.txtfile, words that might appear to be
spelling mistakes but are listed in theci/vale/styles/config/vocabularies/nat/accept.txtfile are OK.Misc. - All code (except .mdc files that contain Cursor rules) should be licensed under the Apache License 2.0,
and should contain an Apache License 2.0 header comment at the top of each file.
- Confirm that copyright years are up-to date whenever a file is changed.
Files:
examples/getting_started/simple_calculator/pyproject.tomldocs/source/versions1.jsonexamples/frameworks/semantic_kernel_demo/pyproject.tomlpackages/nvidia_nat_test/pyproject.tomlexamples/observability/simple_calculator_observability/pyproject.tomlexamples/advanced_agents/alert_triage_agent/pyproject.tomlexamples/front_ends/simple_calculator_custom_routes/pyproject.tomlpackages/compat/aiqtoolkit_agno/pyproject.tomlpackages/nvidia_nat_zep_cloud/pyproject.tomlexamples/observability/redact_pii/pyproject.tomlpackages/nvidia_nat_redis/pyproject.tomlpackages/nvidia_nat_ragaai/pyproject.tomlpackages/nvidia_nat_semantic_kernel/pyproject.tomlexamples/MCP/simple_auth_mcp/pyproject.tomlexamples/frameworks/adk_demo/pyproject.tomlpackages/compat/aiqtoolkit_llama_index/pyproject.tomlexamples/control_flow/router_agent/pyproject.tomlexamples/evaluation_and_profiling/swe_bench/pyproject.tomlpackages/compat/aiqtoolkit_weave/pyproject.tomlpackages/nvidia_nat_llama_index/pyproject.tomlpackages/compat/aiqtoolkit_crewai/pyproject.tomlpackages/nvidia_nat_all/pyproject.tomlexamples/frameworks/haystack_deep_research_agent/pyproject.tomlexamples/evaluation_and_profiling/simple_calculator_eval/pyproject.tomlexamples/frameworks/multi_frameworks/pyproject.tomlexamples/documentation_guides/workflows/text_file_ingest/pyproject.tomlexamples/getting_started/simple_web_query/pyproject.tomlpackages/nvidia_nat_crewai/pyproject.tomlpackages/nvidia_nat_s3/pyproject.tomlpackages/nvidia_nat_profiling/pyproject.tomlexamples/front_ends/simple_auth/pyproject.tomlexamples/control_flow/sequential_executor/pyproject.tomlpackages/compat/aiqtoolkit_zep_cloud/pyproject.tomlexamples/custom_functions/plot_charts/pyproject.tomlexamples/object_store/user_report/pyproject.tomlexamples/custom_functions/automated_description_generation/pyproject.tomlpackages/nvidia_nat_phoenix/pyproject.tomlpackages/compat/aiqtoolkit_test/pyproject.tomlexamples/advanced_agents/profiler_agent/pyproject.tomlpackages/nvidia_nat_ingestion/pyproject.tomlexamples/RAG/simple_rag/pyproject.tomlpackages/nvidia_nat_mcp/pyproject.tomlpackages/nvidia_nat_adk/pyproject.tomlpackages/compat/aiqtoolkit/pyproject.tomlpackages/nvidia_nat_weave/pyproject.tomlexamples/notebooks/retail_sales_agent/pyproject.tomlpackages/nvidia_nat_opentelemetry/pyproject.tomlpackages/compat/aiqtoolkit_mem0ai/pyproject.tomlpackages/nvidia_nat_mem0ai/pyproject.tomlpackages/compat/aiqtoolkit_langchain/pyproject.tomlexamples/evaluation_and_profiling/simple_web_query_eval/pyproject.tomlpackages/nvidia_nat_langchain/pyproject.tomlpackages/nvidia_nat_mysql/pyproject.tomlexamples/frameworks/agno_personal_finance/pyproject.tomlexamples/HITL/por_to_jiratickets/pyproject.tomlpackages/nvidia_nat_agno/pyproject.tomlexamples/notebooks/first_search_agent/pyproject.tomlexamples/MCP/simple_calculator_mcp/pyproject.tomlexamples/HITL/simple_calculator_hitl/pyproject.tomlpackages/compat/aiqtoolkit_semantic_kernel/pyproject.tomlexamples/evaluation_and_profiling/email_phishing_analyzer/pyproject.tomlpackages/nvidia_nat_data_flywheel/pyproject.toml
examples/**/*
⚙️ CodeRabbit configuration file
examples/**/*: - This directory contains example code and usage scenarios for the toolkit, at a minimum an example should
contain a README.md or file README.ipynb.
- If an example contains Python code, it should be placed in a subdirectory named
src/and should
contain apyproject.tomlfile. Optionally, it might also contain scripts in ascripts/directory.- If an example contains YAML files, they should be placed in a subdirectory named
configs/. - If an example contains sample data files, they should be placed in a subdirectory nameddata/, and should
be checked into git-lfs.
Files:
examples/getting_started/simple_calculator/pyproject.tomlexamples/frameworks/semantic_kernel_demo/pyproject.tomlexamples/observability/simple_calculator_observability/pyproject.tomlexamples/advanced_agents/alert_triage_agent/pyproject.tomlexamples/front_ends/simple_calculator_custom_routes/pyproject.tomlexamples/observability/redact_pii/pyproject.tomlexamples/MCP/simple_auth_mcp/pyproject.tomlexamples/frameworks/adk_demo/pyproject.tomlexamples/control_flow/router_agent/pyproject.tomlexamples/evaluation_and_profiling/swe_bench/pyproject.tomlexamples/frameworks/haystack_deep_research_agent/pyproject.tomlexamples/evaluation_and_profiling/simple_calculator_eval/pyproject.tomlexamples/frameworks/multi_frameworks/pyproject.tomlexamples/documentation_guides/workflows/text_file_ingest/pyproject.tomlexamples/getting_started/simple_web_query/pyproject.tomlexamples/front_ends/simple_auth/pyproject.tomlexamples/control_flow/sequential_executor/pyproject.tomlexamples/custom_functions/plot_charts/pyproject.tomlexamples/object_store/user_report/pyproject.tomlexamples/custom_functions/automated_description_generation/pyproject.tomlexamples/advanced_agents/profiler_agent/pyproject.tomlexamples/RAG/simple_rag/pyproject.tomlexamples/notebooks/retail_sales_agent/pyproject.tomlexamples/evaluation_and_profiling/simple_web_query_eval/pyproject.tomlexamples/frameworks/agno_personal_finance/pyproject.tomlexamples/HITL/por_to_jiratickets/pyproject.tomlexamples/notebooks/first_search_agent/pyproject.tomlexamples/MCP/simple_calculator_mcp/pyproject.tomlexamples/HITL/simple_calculator_hitl/pyproject.tomlexamples/evaluation_and_profiling/email_phishing_analyzer/pyproject.toml
docs/source/**/*
⚙️ CodeRabbit configuration file
This directory contains the source code for the documentation. All documentation should be written in Markdown format. Any image files should be placed in the
docs/source/_staticdirectory.
Files:
docs/source/versions1.json
packages/*/pyproject.toml
📄 CodeRabbit inference engine (.cursor/rules/general.mdc)
packages/*/pyproject.toml: Each package must contain a pyproject.toml
In packages, declare a dependency on nvidia-nat or packages starting with nvidia-nat-
Use ~= version constraints (e.g., ~=1.0) for dependencies
Files:
packages/nvidia_nat_test/pyproject.tomlpackages/nvidia_nat_zep_cloud/pyproject.tomlpackages/nvidia_nat_redis/pyproject.tomlpackages/nvidia_nat_ragaai/pyproject.tomlpackages/nvidia_nat_semantic_kernel/pyproject.tomlpackages/nvidia_nat_llama_index/pyproject.tomlpackages/nvidia_nat_all/pyproject.tomlpackages/nvidia_nat_crewai/pyproject.tomlpackages/nvidia_nat_s3/pyproject.tomlpackages/nvidia_nat_profiling/pyproject.tomlpackages/nvidia_nat_phoenix/pyproject.tomlpackages/nvidia_nat_ingestion/pyproject.tomlpackages/nvidia_nat_mcp/pyproject.tomlpackages/nvidia_nat_adk/pyproject.tomlpackages/nvidia_nat_weave/pyproject.tomlpackages/nvidia_nat_opentelemetry/pyproject.tomlpackages/nvidia_nat_mem0ai/pyproject.tomlpackages/nvidia_nat_langchain/pyproject.tomlpackages/nvidia_nat_mysql/pyproject.tomlpackages/nvidia_nat_agno/pyproject.tomlpackages/nvidia_nat_data_flywheel/pyproject.toml
{packages/*/pyproject.toml,uv.lock}
📄 CodeRabbit inference engine (.cursor/rules/general.mdc)
Add new dependencies to both pyproject.toml (alphabetically) and uv.lock via uv pip install --sync
Files:
packages/nvidia_nat_test/pyproject.tomlpackages/nvidia_nat_zep_cloud/pyproject.tomlpackages/nvidia_nat_redis/pyproject.tomlpackages/nvidia_nat_ragaai/pyproject.tomlpackages/nvidia_nat_semantic_kernel/pyproject.tomlpackages/nvidia_nat_llama_index/pyproject.tomlpackages/nvidia_nat_all/pyproject.tomlpackages/nvidia_nat_crewai/pyproject.tomlpackages/nvidia_nat_s3/pyproject.tomlpackages/nvidia_nat_profiling/pyproject.tomlpackages/nvidia_nat_phoenix/pyproject.tomlpackages/nvidia_nat_ingestion/pyproject.tomlpackages/nvidia_nat_mcp/pyproject.tomlpackages/nvidia_nat_adk/pyproject.tomlpackages/nvidia_nat_weave/pyproject.tomlpackages/nvidia_nat_opentelemetry/pyproject.tomlpackages/nvidia_nat_mem0ai/pyproject.tomlpackages/nvidia_nat_langchain/pyproject.tomlpackages/nvidia_nat_mysql/pyproject.tomlpackages/nvidia_nat_agno/pyproject.tomlpackages/nvidia_nat_data_flywheel/pyproject.toml
packages/**/*
⚙️ CodeRabbit configuration file
packages/**/*: - This directory contains optional plugin packages for the toolkit, each should contain apyproject.tomlfile. - Thepyproject.tomlfile should declare a dependency onnvidia-nator another package with a name starting
withnvidia-nat-. This dependency should be declared using~=<version>, and the version should be a two
digit version (ex:~=1.0).
- Not all packages contain Python code, if they do they should also contain their own set of tests, in a
tests/directory at the same level as thepyproject.tomlfile.
Files:
packages/nvidia_nat_test/pyproject.tomlpackages/compat/aiqtoolkit_agno/pyproject.tomlpackages/nvidia_nat_zep_cloud/pyproject.tomlpackages/nvidia_nat_redis/pyproject.tomlpackages/nvidia_nat_ragaai/pyproject.tomlpackages/nvidia_nat_semantic_kernel/pyproject.tomlpackages/compat/aiqtoolkit_llama_index/pyproject.tomlpackages/compat/aiqtoolkit_weave/pyproject.tomlpackages/nvidia_nat_llama_index/pyproject.tomlpackages/compat/aiqtoolkit_crewai/pyproject.tomlpackages/nvidia_nat_all/pyproject.tomlpackages/nvidia_nat_crewai/pyproject.tomlpackages/nvidia_nat_s3/pyproject.tomlpackages/nvidia_nat_profiling/pyproject.tomlpackages/compat/aiqtoolkit_zep_cloud/pyproject.tomlpackages/nvidia_nat_phoenix/pyproject.tomlpackages/compat/aiqtoolkit_test/pyproject.tomlpackages/nvidia_nat_ingestion/pyproject.tomlpackages/nvidia_nat_mcp/pyproject.tomlpackages/nvidia_nat_adk/pyproject.tomlpackages/compat/aiqtoolkit/pyproject.tomlpackages/nvidia_nat_weave/pyproject.tomlpackages/nvidia_nat_opentelemetry/pyproject.tomlpackages/compat/aiqtoolkit_mem0ai/pyproject.tomlpackages/nvidia_nat_mem0ai/pyproject.tomlpackages/compat/aiqtoolkit_langchain/pyproject.tomlpackages/nvidia_nat_langchain/pyproject.tomlpackages/nvidia_nat_mysql/pyproject.tomlpackages/nvidia_nat_agno/pyproject.tomlpackages/compat/aiqtoolkit_semantic_kernel/pyproject.tomlpackages/nvidia_nat_data_flywheel/pyproject.toml
🧠 Learnings (2)
📚 Learning: 2025-09-23T18:39:15.023Z
Learnt from: CR
PR: NVIDIA/NeMo-Agent-Toolkit#0
File: .cursor/rules/general.mdc:0-0
Timestamp: 2025-09-23T18:39:15.023Z
Learning: Applies to packages/*/pyproject.toml : In packages, declare a dependency on nvidia-nat or packages starting with nvidia-nat-
Applied to files:
examples/getting_started/simple_calculator/pyproject.tomlexamples/frameworks/semantic_kernel_demo/pyproject.tomlpackages/nvidia_nat_test/pyproject.tomlexamples/observability/simple_calculator_observability/pyproject.tomlexamples/front_ends/simple_calculator_custom_routes/pyproject.tomlpackages/compat/aiqtoolkit_agno/pyproject.tomlpackages/nvidia_nat_zep_cloud/pyproject.tomlexamples/observability/redact_pii/pyproject.tomlpackages/nvidia_nat_redis/pyproject.tomlpackages/nvidia_nat_ragaai/pyproject.tomlpackages/nvidia_nat_semantic_kernel/pyproject.tomlexamples/MCP/simple_auth_mcp/pyproject.tomlexamples/frameworks/adk_demo/pyproject.tomlexamples/evaluation_and_profiling/swe_bench/pyproject.tomlpackages/compat/aiqtoolkit_weave/pyproject.tomlpackages/nvidia_nat_llama_index/pyproject.tomlpackages/compat/aiqtoolkit_crewai/pyproject.tomlpackages/nvidia_nat_all/pyproject.tomlexamples/frameworks/haystack_deep_research_agent/pyproject.tomlexamples/evaluation_and_profiling/simple_calculator_eval/pyproject.tomlexamples/frameworks/multi_frameworks/pyproject.tomlexamples/documentation_guides/workflows/text_file_ingest/pyproject.tomlexamples/getting_started/simple_web_query/pyproject.tomlpackages/nvidia_nat_crewai/pyproject.tomlpackages/nvidia_nat_s3/pyproject.tomlpackages/nvidia_nat_profiling/pyproject.tomlexamples/front_ends/simple_auth/pyproject.tomlexamples/control_flow/sequential_executor/pyproject.tomlpackages/compat/aiqtoolkit_zep_cloud/pyproject.tomlexamples/object_store/user_report/pyproject.tomlexamples/custom_functions/automated_description_generation/pyproject.tomlpackages/nvidia_nat_phoenix/pyproject.tomlpackages/compat/aiqtoolkit_test/pyproject.tomlexamples/advanced_agents/profiler_agent/pyproject.tomlpackages/nvidia_nat_ingestion/pyproject.tomlexamples/RAG/simple_rag/pyproject.tomlpackages/nvidia_nat_mcp/pyproject.tomlpackages/nvidia_nat_adk/pyproject.tomlpackages/compat/aiqtoolkit/pyproject.tomlpackages/nvidia_nat_weave/pyproject.tomlexamples/notebooks/retail_sales_agent/pyproject.tomlpackages/nvidia_nat_opentelemetry/pyproject.tomlpackages/compat/aiqtoolkit_mem0ai/pyproject.tomlpackages/nvidia_nat_mem0ai/pyproject.tomlpackages/compat/aiqtoolkit_langchain/pyproject.tomlexamples/evaluation_and_profiling/simple_web_query_eval/pyproject.tomlpackages/nvidia_nat_langchain/pyproject.tomlpackages/nvidia_nat_mysql/pyproject.tomlexamples/frameworks/agno_personal_finance/pyproject.tomlexamples/HITL/por_to_jiratickets/pyproject.tomlpackages/nvidia_nat_agno/pyproject.tomlexamples/notebooks/first_search_agent/pyproject.tomlexamples/MCP/simple_calculator_mcp/pyproject.tomlexamples/HITL/simple_calculator_hitl/pyproject.tomlpackages/compat/aiqtoolkit_semantic_kernel/pyproject.tomlpackages/nvidia_nat_data_flywheel/pyproject.toml
📚 Learning: 2025-09-23T18:39:15.023Z
Learnt from: CR
PR: NVIDIA/NeMo-Agent-Toolkit#0
File: .cursor/rules/general.mdc:0-0
Timestamp: 2025-09-23T18:39:15.023Z
Learning: Applies to packages/*/pyproject.toml : Use ~=<two-digit> version constraints (e.g., ~=1.0) for dependencies
Applied to files:
packages/nvidia_nat_test/pyproject.tomlpackages/nvidia_nat_phoenix/pyproject.tomlpackages/nvidia_nat_ingestion/pyproject.tomlpackages/nvidia_nat_mcp/pyproject.toml
🔇 Additional comments (26)
examples/observability/redact_pii/pyproject.toml (1)
12-12: Dependency downgrade looks good.Aligning the example to
nvidia-nat[weave]~=1.3matches the release 1.3 branch—you’re good here.examples/evaluation_and_profiling/swe_bench/pyproject.toml (1)
13-13: Dependency downgrade matches release targetAligning this example with the 1.3 line looks correct for the release/1.3 branch. Thanks for keeping the extras in sync.
examples/getting_started/simple_web_query/pyproject.toml (1)
13-14: Dependency pins correctly reverted to 1.3 track.Requiring the langchain and telemetry extras on
nvidia-nat1.3 matches the release/1.3 baseline and keeps this example consistent with the rest of the revert. Looks good.examples/control_flow/sequential_executor/pyproject.toml (1)
13-13: Downgrade keeps this example aligned with release/1.3.Reverting to
nvidia-nat[langchain]~=1.3matches the dependency level expected on this branch; no additional adjustments needed.examples/frameworks/haystack_deep_research_agent/pyproject.toml (1)
12-12: Version pin matches the reversion goal.The downgrade to
nvidia-nat~=1.3aligns with the branch-wide reversion and keeps this example in sync with the workspace. No further action needed.examples/control_flow/router_agent/pyproject.toml (1)
13-14: Dependency pin matches release/1.3 baseline.Reverting the
nvidia-nat[langchain]constraint back to the 1.3 series keeps this example aligned with the release branch dependency set. Looks good.examples/frameworks/agno_personal_finance/pyproject.toml (1)
13-15: Restore the~=1.3constraint on the extras line.Line 14 drops the version pin from the
nvidia-nat[openai,litellm]dependency. Our packaging guidelines require everynvidia-natdependency to use a two-digit~=constraint, and the goal of this revert is to keep everything on the 1.3 line. Add~=1.3back so we don’t accidentally pull in 1.4 again.⛔ Skipped due to learnings
Learnt from: CR PR: NVIDIA/NeMo-Agent-Toolkit#0 File: .cursor/rules/general.mdc:0-0 Timestamp: 2025-09-23T18:39:15.023Z Learning: Applies to packages/*/pyproject.toml : In packages, declare a dependency on nvidia-nat or packages starting with nvidia-nat-docs/source/versions1.json (1)
1-6: Doc version list consistent with 1.3 focus.Marking 1.3 as preferred while removing 1.4 aligns with the revert to the 1.3 docs set; no issues spotted.
examples/front_ends/simple_auth/pyproject.toml (1)
12-15: Dependency pin matches release/1.3.Switching the example to
nvidia-nat[langchain]~=1.3keeps it aligned with the 1.3 release train; everything else stays consistent.packages/nvidia_nat_ragaai/pyproject.toml (1)
20-25: RagaAI plugin now tracks 1.3 workspace.Downgrading to
nvidia-nat[litellm,opentelemetry]~=1.3keeps this package in sync with the reverted release line; dependency ordering intact.packages/compat/aiqtoolkit_llama_index/pyproject.toml (1)
11-18: Compat shim tied back to 1.3.The dependency adjustment to
nvidia-nat[llama-index]~=1.3matches the rest of the revert work; looks good.packages/compat/aiqtoolkit_zep_cloud/pyproject.toml (1)
9-16: Zep Cloud compat package aligned with 1.3.Updating to
nvidia-nat[zep-cloud]~=1.3correctly syncs this transitional package with the 1.3 line; nothing else to flag.packages/nvidia_nat_weave/pyproject.toml (1)
23-23: Downgrade looks correct.Reverting the dependency to
nvidia-nat~=1.3matches the release/1.3 target and keeps the list sorted.packages/nvidia_nat_adk/pyproject.toml (1)
37-37: Revert applied consistently.The
nvidia-nat[litellm]~=1.3downgrade lines up with the revert and keeps the constraint format compliant.packages/nvidia_nat_test/pyproject.toml (1)
23-23: Matches the intended rollback.Switching to
nvidia-nat~=1.3restores compatibility with the release/1.3 train.examples/HITL/por_to_jiratickets/pyproject.toml (1)
12-12: Example dependency updated appropriately.Reverting to
nvidia-nat[langchain]~=1.3brings the example back in sync with the toolkit version strategy.examples/HITL/simple_calculator_hitl/pyproject.toml (1)
13-13: Dependency rollback confirmed.The
nvidia-nat[langchain]~=1.3pin aligns with the other HITL assets and the release/1.3 baseline.packages/nvidia_nat_zep_cloud/pyproject.toml (1)
23-24: Downgrade aligns with package policyThe shift to
nvidia-nat~=1.3keeps the two-digit~=constraint and maintains sorted ordering. No further action needed.packages/compat/aiqtoolkit_agno/pyproject.toml (1)
13-13: Constraint matches revert targetThe dependency now uses
nvidia-nat[agno]~=1.3, satisfying the two-digit~=requirement and matching the revert scope.packages/nvidia_nat_semantic_kernel/pyproject.toml (1)
23-24: Semantic Kernel package stays compliant
nvidia-nat~=1.3keeps the dependency within the expected constraint format, and ordering remains alphabetic.examples/RAG/simple_rag/pyproject.toml (1)
16-17: Example dependency downgrade looks goodThe extras bundle now targets
nvidia-nat[...]~=1.3with alphabetical extras, matching the revert intent.examples/evaluation_and_profiling/email_phishing_analyzer/pyproject.toml (1)
13-18: Downgrade matches targeted revert. The dependency constraint shifting to~=1.3lines up with the broader rollback and keeps the extras consistent.examples/advanced_agents/profiler_agent/pyproject.toml (1)
13-20: Constraint rollback looks good. Updating to~=1.3keeps the extras bundle valid while matching the revert strategy.packages/compat/aiqtoolkit_langchain/pyproject.toml (1)
14-18: Revert in sync with policy. The compat package now points back tonvidia-nat[langchain]~=1.3, satisfying the package guideline.packages/nvidia_nat_mysql/pyproject.toml (1)
20-25: MySQL plugin dependency reverted cleanly. Switching tonvidia-nat~=1.3matches the intended rollback and keeps the spec compliant.packages/compat/aiqtoolkit_semantic_kernel/pyproject.toml (1)
9-13: Compat package now tracks 1.3 again. The semantic-kernel extra is back on the 1.3 line, consistent with the revert.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/1.3 #892 +/- ##
============================================
Coverage 77.06% 77.06%
============================================
Files 444 444
Lines 26635 26635
============================================
Hits 20526 20526
Misses 6109 6109
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/merge |
…atch." (NVIDIA#892) Reverts NVIDIA#887 - Documentation - Updated versions: removed 1.4 and marked 1.3 as the preferred version. - Simplified MCP client docs by removing SSE transport prerequisite note. - Chores - Standardized dependencies across examples and packages to nvidia-nat ~=1.3 (including extras such as langchain, mcp, ingestion, mem0ai, adk, agno, telemetry/opentelemetry, profiling, weave, redis, mysql, s3, zep-cloud, llama-index, crewai, semantic-kernel, litellm, gunicorn, async_endpoints). - Adjusted extras ordering where applicable without functional impact. Authors: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - David Gardner (https://github.com/dagardner-nv) URL: NVIDIA#892 docs: add note about increasing file descriptor limit Signed-off-by: ノウラ | Flare <[email protected]>
Reverts #887
Summary by CodeRabbit
Documentation
Chores