mcp-client-cli: Note that client and server transports must match. #887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Gardner <[email protected]>
Forward-merge triggered by push to release/1.3 that creates a PR to keep develop up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See [forward-merger docs](https://docs.rapids.ai/maintainers/forward-merger/) for more info.
Signed-off-by: Anuradha Karuppiah <[email protected]>
AnuradhaKaruppiah
added
doc
WalkthroughAdds a documentation paragraph to the MCP client tool listing section about SSE transport requirements, noting the server must start with --transport sse, client/server transports must match, and the default is streamable-http. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ericevans-nv
approved these changes
Oct 1, 2025
AnuradhaKaruppiah
changed the title
|
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Oct 1, 2025
…atch." (#892) Reverts #887 ## Summary by CodeRabbit - Documentation - Updated versions: removed 1.4 and marked 1.3 as the preferred version. - Simplified MCP client docs by removing SSE transport prerequisite note. - Chores - Standardized dependencies across examples and packages to nvidia-nat ~=1.3 (including extras such as langchain, mcp, ingestion, mem0ai, adk, agno, telemetry/opentelemetry, profiling, weave, redis, mysql, s3, zep-cloud, llama-index, crewai, semantic-kernel, litellm, gunicorn, async_endpoints). - Adjusted extras ordering where applicable without functional impact. Authors: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - David Gardner (https://github.com/dagardner-nv) URL: #892
nouraellm
pushed a commit
to nouraellm/NeMo-Agent-Toolkit
that referenced
this pull request
Oct 3, 2025
…VIDIA#887) Closes ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. ## Summary by CodeRabbit * **Documentation** * Added guidance to the MCP client tool listing explaining SSE transport requirements: the server must be started with --transport sse, client and server transports must match, and the default transport is streamable-http. * Clarifies setup expectations to reduce misconfiguration and aid onboarding and troubleshooting. Authors: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) - David Gardner (https://github.com/dagardner-nv) Approvers: - Eric Evans II (https://github.com/ericevans-nv) URL: NVIDIA#887
nouraellm
pushed a commit
to nouraellm/NeMo-Agent-Toolkit
that referenced
this pull request
Oct 3, 2025
…atch." (NVIDIA#892) Reverts NVIDIA#887 - Documentation - Updated versions: removed 1.4 and marked 1.3 as the preferred version. - Simplified MCP client docs by removing SSE transport prerequisite note. - Chores - Standardized dependencies across examples and packages to nvidia-nat ~=1.3 (including extras such as langchain, mcp, ingestion, mem0ai, adk, agno, telemetry/opentelemetry, profiling, weave, redis, mysql, s3, zep-cloud, llama-index, crewai, semantic-kernel, litellm, gunicorn, async_endpoints). - Adjusted extras ordering where applicable without functional impact. Authors: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - David Gardner (https://github.com/dagardner-nv) URL: NVIDIA#892 docs: add note about increasing file descriptor limit Signed-off-by: ノウラ | Flare <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes
By Submitting this PR I confirm:
Summary by CodeRabbit