Skip to content

build: AUT-1615 add torch-memory-saver dev dependency - #6701

Merged
ko3n1g merged 8 commits into
NVIDIA:mainfrom
svcnemo-autobot:add-torch-memory-saver-dev
Aug 21, 2026
Merged

build: AUT-1615 add torch-memory-saver dev dependency#6701
ko3n1g merged 8 commits into
NVIDIA:mainfrom
svcnemo-autobot:add-torch-memory-saver-dev

Conversation

@svcnemo-autobot

@svcnemo-autobot svcnemo-autobot commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Background

Megatron-LM uses torch_memory_saver for inference and RL memory offloading, but it is absent from the development environment.

What changed

  • Added torch-memory-saver to the dev extra.
  • Pinned its GitHub source to commit 9bc9a442e6d108c7b7903def199896a005143aaf (tag v0.0.10b1).
  • Regenerated uv.lock with that exact revision.
  • Configured installation and CI image builds to derive TMS_CUDA_MAJOR from the active CUDA toolkit.

Details

flowchart LR
    A[GitHub commit] --> B[dev dependency]
    C[active CUDA toolkit] --> D[source build]
    B --> D
Loading

Tested

  • uv lock --check
  • Dev-extra source build, sync, and import in NGC PyTorch 26.06
  • CUDA-major detection and install-script propagation
  • bash -n docker/common/install.sh
  • git diff --check

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
@svcnemo-autobot
svcnemo-autobot requested a review from a team as a code owner August 20, 2026 11:26
@copy-pr-bot

copy-pr-bot Bot commented Aug 20, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci
svcnvidia-nemo-ci marked this pull request as draft August 20, 2026 11:26
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

/ok to test 705c2e0

Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

/ok to test 511b0ef

@ko3n1g
ko3n1g marked this pull request as ready for review August 20, 2026 15:06
@ko3n1g
ko3n1g enabled auto-merge August 20, 2026 15:06
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
auto-merge was automatically disabled August 20, 2026 15:47

Head branch was pushed to by a user without write access

@nemo-autobot-origin
nemo-autobot-origin Bot requested a review from a team as a code owner August 20, 2026 15:47
@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Approved All necessary approvals have been made label Aug 20, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

/ok to test a848e09

@ko3n1g

ko3n1g commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

@svcnemo-autobot fetch and merge upstream/main

Copy link
Copy Markdown
Collaborator Author

💬 I’m fetching and merging the current upstream main into the owned PR branch now; I’ll validate and publish the resulting merge head.

@ko3n1g
ko3n1g removed the request for review from a team August 20, 2026 20:53
@ko3n1g
ko3n1g enabled auto-merge August 20, 2026 20:53
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

/ok to test b800152

@nemo-automation-bot

Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/32460128637

@nemo-automation-bot

Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/32466798875

Merged via the queue into NVIDIA:main with commit ab5e2c9 Aug 21, 2026
239 of 242 checks passed
devnkong pushed a commit to devnkong/Megatron-LM that referenced this pull request Aug 22, 2026
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Signed-off-by: Kezhi Kong <kezhik@kezhik-mlt.client.nvidia.com>
cspades pushed a commit to cspades/RL that referenced this pull request Aug 30, 2026
Bumps the Megatron-Bridge submodule (nesting Megatron-LM at 7c9c3a027,
which pins emerging-optimizers@v0.3.0) and RL's own constraint-dependencies
pin to match, per <NVIDIA/Megatron-LM#6701>.

The automated mbridge-bump pipeline (nemo-ci) could not do this on its
own: it bumps only the submodule, not RL's root pin, so uv lock failed
with a conflicting-URL error until both moved together in one commit.

Signed-off-by: Kajal Jain <kajalj@nvidia.com>
cspades pushed a commit to cspades/RL that referenced this pull request Aug 30, 2026
Bumps the Megatron-Bridge submodule (nesting Megatron-LM at 7c9c3a027,
which pins emerging-optimizers@v0.3.0) and RL's own constraint-dependencies
pin to match, per <NVIDIA/Megatron-LM#6701>.

The automated mbridge-bump pipeline (nemo-ci) could not do this on its
own: it bumps only the submodule, not RL's root pin, so uv lock failed
with a conflicting-URL error until both moved together in one commit.

Signed-off-by: Kajal Jain <kajalj@nvidia.com>
cspades pushed a commit to cspades/RL that referenced this pull request Aug 31, 2026
Bumps the Megatron-Bridge submodule (nesting Megatron-LM at 7c9c3a027,
which pins emerging-optimizers@v0.3.0) and RL's own constraint-dependencies
pin to match, per <NVIDIA/Megatron-LM#6701>.

The automated mbridge-bump pipeline (nemo-ci) could not do this on its
own: it bumps only the submodule, not RL's root pin, so uv lock failed
with a conflicting-URL error until both moved together in one commit.

Signed-off-by: Kajal Jain <kajalj@nvidia.com>
cspades pushed a commit to NVIDIA-NeMo/RL that referenced this pull request Aug 31, 2026
Bumps the Megatron-Bridge submodule (nesting Megatron-LM at 7c9c3a027,
which pins emerging-optimizers@v0.3.0) and RL's own constraint-dependencies
pin to match, per <NVIDIA/Megatron-LM#6701>.

The automated mbridge-bump pipeline (nemo-ci) could not do this on its
own: it bumps only the submodule, not RL's root pin, so uv lock failed
with a conflicting-URL error until both moved together in one commit.

Signed-off-by: Kajal Jain <kajalj@nvidia.com>
ksivaman pushed a commit to ksivaman/Megatron-LM that referenced this pull request Sep 1, 2026
Signed-off-by: svcnemo-autobot <svcnemo-autobot@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made Run tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants