Skip to content

ci: Bump Megatron-Bridge to b11414c7 - #3906

Merged
yuki-97 merged 5 commits into
mainfrom
kajalj/bump-emerging-optimizers-v0.3.0
Sep 1, 2026
Merged

ci: Bump Megatron-Bridge to b11414c7#3906
yuki-97 merged 5 commits into
mainfrom
kajalj/bump-emerging-optimizers-v0.3.0

Conversation

@kajalj22

@kajalj22 kajalj22 commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Bumps the Megatron-Bridge submodule pointer to b11414c7 (nesting Megatron-LM at 7c9c3a027).
  • Bumps RL's own emerging-optimizers pin in constraint-dependencies from v0.2.0 to v0.3.0, matching Megatron-LM's [tool.uv.sources] pin (see NVIDIA/Megatron-LM#6701).
  • Regenerates uv.lock.

Manual bump: the automated create_mbridge_bump_pr nemo-ci pipeline only advances the submodule pointer, not RL's own root pin, so uv lock failed with conflicting emerging-optimizers URLs (v0.2.0 from RL's stale root pin vs v0.3.0 transitively via the bumped Megatron-LM). Bumping both together in this PR resolves cleanly.

Supersedes #3868 (stale automated bump to an older commit).

Potential Open Issues (Related to MBridge)

Summary of the TODO's and relevant issues:

Codex summary of all nightly test failures that may need tracking:

  1. 417124452 — Moonlight TQ
    Test: grpo-moonlight-16ba3b-4n8g-megatron-tq_simple.sh
    CheckpointException: checkpoint missing expected linear_q_proj.layer_norm_weight.

  2. 417124388 — Moonlight
    Test: grpo-moonlight-16ba3b-4n8g-megatron.sh
    Same checkpoint/state-dict mismatch as above.

  3. 417124464 — Qwen2.5 native Megatron generation
    Test: grpo-qwen2.5-math-1.5b-instruct-1n8g-megatron_generation-noncolocated-single-controller-sync.sh
    train/token_mult_prob_error = inf, expected median < 1.1.

The two Moonlight failures are one issue: regenerate/invalidate the shared checkpoint after the MBridge model-schema change. The generation failure needs a pre/post-bump A/B run.

  1. 417124437 — Nemotron3 Super
    Test: grpo-nemotron3-super-120BA12B-16n8g-megatron.sh
    CUDA illegal memory access in offload_after_refit() after accessing offloaded Mamba weights.

  2. 417124430 — Nano-v3 Megatron
    Test: grpo-nanov3-30BA3B-2n8g-megatron-pack-cp.sh
    Same Mamba offload CUDA illegal-memory access.

  3. 417124425 — Nano-v2 Megatron
    Test: grpo-nano-v2-12b-1n8g-megatron.sh
    Same Mamba offload CUDA illegal-memory access.

  4. 417124401 — Nemotron-Omni MMPR Megatron
    Test: vlm_grpo-nemotron-omni-30ba3b-mmpr-4n8g-megatron-tp8ep16.v1.sh
    FileNotFoundError: .../blobs/configuration_nemotron_h.py.

  5. 417124400 — Nemotron-Omni CLEVR Megatron
    Test: vlm_grpo-nemotron-omni-30ba3b-clevr-1n8g-megatron-tp8ep8.v1.sh
    Same Transformers 5.12.1 symlink-resolution error.

The IMA group is covered by Peter Dykas’s fix; the two multimodal jobs are covered by Transformers ≥5.13.

  1. 417124419
    Test: grpo-dapomath17k-dsv3-megatron.sh
    DeepseekV3Config lacks qk_head_dim. Identical in prior job 415927951.

  2. 417124408
    Test: grpo-moonlight-16ba3b-4n8g-megatron-fp8-e2e.sh
    vLLM CuMem allocator CUDA invalid argument. Identical in prior job 415927940.

  3. 417124397
    Test: vlm_grpo-qwen3-omni-30ba3b-audiomcq-4n8g-megatron.v1.sh
    Gloo receive timed out after 30 minutes.

  4. 417124396
    Test: vlm_grpo-qwen2.5-omni-7b-intent-1n8g-megatron.v1.sh
    Reached the Slurm time limit without a preceding exception.

Test plan

  • uv lock resolves cleanly (565 packages)
  • uv.lock retains provides-extras metadata
  • CI passes

@kajalj22
kajalj22 requested review from a team as code owners August 29, 2026 03:19
@kajalj22 kajalj22 added the CI:L1 Run doctests, unit tests, and functional tests label Aug 29, 2026
@kajalj22
kajalj22 requested a review from terrykong August 29, 2026 03:19
@copy-pr-bot

copy-pr-bot Bot commented Aug 29, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: ea95f20 (PR #3906 from kajalj/bump-emerging-optimizers-v0.3.0)

✅ Submodules that are properly updated:

Megatron-Bridge: ✅ PR branch is ahead of main branch (fast-forward)

All submodule changes look good! ✨

@kajalj22

Copy link
Copy Markdown
Contributor Author

/ok to test ea95f20

@cspades
cspades requested review from a team as code owners August 30, 2026 02:55
@github-actions

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: aab7ed1 (PR #3906 from kajalj/bump-emerging-optimizers-v0.3.0)

✅ Submodules that are properly updated:

Megatron-Bridge: ✅ PR branch is ahead of main branch (fast-forward)

All submodule changes look good! ✨

@cspades

cspades commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

/ok to test aab7ed1

@cspades

cspades commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

/ok to test 167e1c0

@github-actions

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: 167e1c0 (PR #3906 from kajalj/bump-emerging-optimizers-v0.3.0)

✅ Submodules that are properly updated:

Megatron-Bridge: ✅ PR branch is ahead of main branch (fast-forward)

All submodule changes look good! ✨

@cspades
cspades force-pushed the kajalj/bump-emerging-optimizers-v0.3.0 branch from 167e1c0 to 72211f4 Compare August 31, 2026 15:39
@cspades
cspades requested a review from a team as a code owner August 31, 2026 15:39
@github-actions github-actions Bot added the Documentation Improvements or additions to documentation label Aug 31, 2026
@github-actions

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: 72211f4 (PR #3906 from kajalj/bump-emerging-optimizers-v0.3.0)

✅ Submodules that are properly updated:

Megatron-Bridge: ✅ PR branch is ahead of main branch (fast-forward)

All submodule changes look good! ✨

@cspades

cspades commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

/ok to test 72211f4

kajalj22 and others added 3 commits August 31, 2026 08:43
Bumps the Megatron-Bridge submodule (nesting Megatron-LM at 7c9c3a027,
which pins emerging-optimizers@v0.3.0) and RL's own constraint-dependencies
pin to match, per <NVIDIA/Megatron-LM#6701>.

The automated mbridge-bump pipeline (nemo-ci) could not do this on its
own: it bumps only the submodule, not RL's root pin, so uv lock failed
with a conflicting-URL error until both moved together in one commit.

Signed-off-by: Kajal Jain <kajalj@nvidia.com>
Signed-off-by: Cory Ye <cye@nvidia.com>
Signed-off-by: Cory Ye <cye@nvidia.com>
@cspades
cspades force-pushed the kajalj/bump-emerging-optimizers-v0.3.0 branch from 72211f4 to 75f7f04 Compare August 31, 2026 15:43
@copy-pr-bot

copy-pr-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@cspades

cspades commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

/ok to test 75f7f04

@github-actions

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: 75f7f04 (PR #3906 from kajalj/bump-emerging-optimizers-v0.3.0)

✅ Submodules that are properly updated:

Megatron-Bridge: ✅ PR branch is ahead of main branch (fast-forward)

All submodule changes look good! ✨

…optimizers-v0.3.0

Signed-off-by: Kajal Jain <kajalj@nvidia.com>

# Conflicts:
#	uv.lock
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: 8fc0e3d (PR #3906 from kajalj/bump-emerging-optimizers-v0.3.0)

✅ Submodules that are properly updated:

Megatron-Bridge: ✅ PR branch is ahead of main branch (fast-forward)

All submodule changes look good! ✨

@yuki-97

yuki-97 commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

/ok to test 8fc0e3d

@yuki-97
yuki-97 enabled auto-merge (squash) September 1, 2026 07:21
@yuki-97 yuki-97 added CI:Lfast Runs a fast test suite and re-use nightly `main` container (but sync dependencies to PRs version) and removed CI:L1 Run doctests, unit tests, and functional tests labels Sep 1, 2026
@yuki-97

yuki-97 commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

/ok to test 807e12a

@yuki-97

yuki-97 commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

8fc0e3d passed on CI:L1 except the PPO tests already failed in main branch, merged main and changed to CI:Lfast for merge.

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

✅ Submodule Fast-Forward Check Results

Check based on commit: 807e12a (PR #3906 from kajalj/bump-emerging-optimizers-v0.3.0)

✅ Submodules that are properly updated:

Megatron-Bridge: ✅ PR branch is ahead of main branch (fast-forward)

All submodule changes look good! ✨

@yuki-97
yuki-97 merged commit a0edb27 into main Sep 1, 2026
86 checks passed
@yuki-97
yuki-97 deleted the kajalj/bump-emerging-optimizers-v0.3.0 branch September 1, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI:Lfast Runs a fast test suite and re-use nightly `main` container (but sync dependencies to PRs version) Documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants