[4/4] Hyperparameter Transfer across Muon and preconditioned optimizers. - #5000
Draft
plugyawn wants to merge 25 commits into
Draft
[4/4] Hyperparameter Transfer across Muon and preconditioned optimizers.#5000plugyawn wants to merge 25 commits into
plugyawn wants to merge 25 commits into
Conversation
svcnvidia-nemo-ci
marked this pull request as draft
May 26, 2026 21:08
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
6 tasks
…icy-infra # Conflicts: # megatron/core/optimizer/__init__.py
plugyawn
force-pushed
the
feature/muon-spectral-mup
branch
from
May 27, 2026 05:07
05d2aec to
85e2e92
Compare
plugyawn
force-pushed
the
feature/muon-spectral-mup
branch
from
May 27, 2026 05:21
85e2e92 to
15fb60a
Compare
This was referenced Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PR 4/4 of the scaling-recipes split requested in #4381. This builds on the scaling-policy, width-
MuP, and depth-MuP PRs, as started in #4829.
Design doc: PR_MuP.pdf
References: [1/4]: #4829, [2/4]: #4998, [3/4]: #4999.
Intended delta for review:
plugyawn/Megatron-LM@feature/depth-mup...feature/muon-spectral-mup
Builds on #4999.
Currently only handles Muon, but the routing is expressed through emerging-optimizers and parameter-role policy hooks, so the same pattern should extend to other matrix-preconditioned or optimizer-specific parameterizations in future PRs. @mkhona-nvidia could comment better.
TL;DR: this PR adds the Muon scalar-optimizer interaction needed for the scaling-recipes stack. It is the
follow-up to the Muon/MuP behavior discussed in #3715.
This PR:
configured scalar optimizer;
muon_scalar_optimizervalidation for CLI/YAML paths;adamandlionas scalar optimizers;style MuP matrix overrides;
This does not change the core orthogonalized matrix update itself; it only makes the scalar-
parameter side explicit and configurable.
Issue tracking
Related to #4381 and #3715.
Testing
muon_scalar_optimizervalidation.python -m py_compile megatron/core/optimizer/emerging_optimizers.py megatron/core/optimizer/ __init__.py megatron/training/arguments.py megatron/training/yaml_arguments.py tests/unit_tests/ test_lion_optimizer.py tests/unit_tests/transformer/test_mup.pycompatibility.
Pre-checks
tools/autoformat.shCode review
Feel free to message or comment @NVIDIA/mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.