[3/4] Hyperparameter Transfer: add dense GPT depth-MuP recipe - #4999
Draft
plugyawn wants to merge 22 commits into
Draft
[3/4] Hyperparameter Transfer: add dense GPT depth-MuP recipe#4999plugyawn wants to merge 22 commits into
plugyawn wants to merge 22 commits into
Conversation
svcnvidia-nemo-ci
marked this pull request as draft
May 26, 2026 21:07
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
This was referenced May 26, 2026
…icy-infra # Conflicts: # megatron/core/optimizer/__init__.py
plugyawn
force-pushed
the
feature/depth-mup
branch
from
May 27, 2026 05:07
9e21b8d to
1eaf274
Compare
plugyawn
force-pushed
the
feature/depth-mup
branch
from
May 27, 2026 05:21
1eaf274 to
ef280a9
Compare
This was referenced Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR [1/4] (current): #4829
What does this PR do?
PR 3/4 of the scaling-recipes split requested in #4381. This builds on #4829 and the canonical
width-MuP recipe PR.
Design doc: PR_MuP.pdf
References: [1/4]: #4829, [2/4]: #4998, [4/4]: #5000
Intended delta for review:
plugyawn/Megatron-LM@feature/scaling-recipe-mup...feature/depth-mup
Because stacked PRs are not enabled in this repository, this PR is opened against
mainto track the intended progression, but the intended review delta is the comparison above.This PR adds an experimental
depth_muprecipe for dense GPT-style residual transformers withAdam/AdamW.
The recipe applies:
depth_mult^-1;depth_mult^0;depth_mult^-1;depth_mult^+0.5.The init compensation is included because Megatron already has layer-count-based residual output-
projection initialization; this keeps the initialization behavior from double-counting depth while
making residual branch scaling explicit in the forward graph.
Supported surface in this PR:
Explicitly out of scope for this first version:
Issue tracking
Related to #4381 and #4088.
Testing
depth_mupconfig resolution and validation.python -m py_compile megatron/core/parameterization/spec.py megatron/core/parameterization/ model_policy.py megatron/core/parameterization/training_policy.py megatron/core/parameterization/ eval_runtime.py megatron/training/arguments.py megatron/training/checkpointing.py megatron/ training/yaml_arguments.py tests/unit_tests/transformer/test_mup.py tests/unit_tests/ test_optimizer.pycompatibility.
Pre-checks
Code review
Feel free to message or comment @NVIDIA/mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.