chore: nightly sync main into dev (13_05_2026) - #4788
Closed
svcnvidia-nemo-ci wants to merge 25 commits into
Closed
Conversation
Co-authored-by: Antoni-Joan Solergibert <asolergibert@nvidia.com>
…al tests` (#4730) Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: oliver könig <okoenig@nvidia.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Signed-off-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Shivanjan Chakravorty <shivanjanc@nvidia.com> Co-authored-by: Cory Ye <44509866+cspades@users.noreply.github.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com> Signed-off-by: oliver könig <okoenig@nvidia.com> Co-authored-by: oliver könig <okoenig@nvidia.com>
Signed-off-by: Shivanjan Chakravorty <shivanjanc@nvidia.com>
Signed-off-by: Ajay Balasa <abalasa@nvidia.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: Chen Cui <chcui@nvidia.com> Co-authored-by: Tuomas Rintamaki <trintamaki@nvidia.com> Co-authored-by: Tyler Poon <tylerpoon@gmail.com> Co-authored-by: Collin McCarthy <cmccarthy@nvidia.com> Co-authored-by: Matthieu Le <matthieul@nvidia.com> Co-authored-by: Piotr Zelasko <pzelasko@nvidia.com> Co-authored-by: Ehsan Hosseini Asl <ehosseiniasl@nvidia.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Siddharth Singh <sidsingh@nvidia.com>
Signed-off-by: dimapihtar <dpykhtar@nvidia.com>
…parallel_size * expert_tensor_parallel_size (#4678) Signed-off-by: dimapihtar <dpykhtar@nvidia.com>
Co-authored-by: Jorge Albericio <jalbericiola@nvidia.com>
#4509) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
/ok to test fd56123 |
svcnvidia-nemo-ci
force-pushed
the
main2dev/13_05_2026
branch
from
May 14, 2026 00:31
b53ac60 to
187ce73
Compare
Contributor
Author
|
/ok to test 187ce73 |
svcnvidia-nemo-ci
force-pushed
the
main2dev/13_05_2026
branch
from
May 14, 2026 02:20
187ce73 to
d0efe4f
Compare
Contributor
Author
|
/ok to test d0efe4f |
Contributor
Author
|
Superseded by today's nightly sync. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nightly sync of
mainintodevfor 13_05_2026.mainmerged intodevFiles taken from main (overrides)
These files were explicitly overridden with
main's version because dev'sversions reference args or APIs that main removed/renamed:
megatron/training/training.pymegatron/training/initialize.pymegatron/training/utils.pymegatron/training/datasets/data_samplers.pymegatron/core/optimizer/layer_wise_optimizer.pytests/test_utils/recipes/h100/bert.yaml(restored from main — missing in dev)tests/test_utils/recipes/h100/t5.yaml(restored from main — missing in dev)Files restored from dev (must not change in sync)
Per skill guidance:
pyproject.toml(dev keepsfast-hadamard-transform+ owntransformer-engine/nvidia-resiliency-extrevisions)uv.lockdocker/Dockerfile.ci.dev.github/CODEOWNERSSurgical merges (kept main + dev features)
After
-X theirsresolved conflicts in favor of main, the following fileshad dev-only features re-injected to fix API breakage:
megatron/core/extensions/transformer_engine.py— restored dev'sTEFusedDenseMLPclass (referenced by dev test + spec).megatron/core/models/gpt/experimental_attention_variant_module_specs.py— restored
HyperConnectionTransformerLayerimport (still referenced).megatron/core/models/gpt/gpt_layer_specs.py— restoreddense_grouped_gemmparameter onget_mlp_module_spec_for_backendrouting to
TEFusedDenseMLP.as_mlp_submodulewhen set; preservesmain's
MlpBuilderpattern.megatron/core/transformer/moe/moe_layer.py— restoredinput_idsparameter on
MoELayer.forward(still passed throughcustom_forward).megatron/core/transformer/transformer_layer.py— restoredmlp_hyper_connectionfield onTransformerLayerSubmodules, restored**moe_kwargsandinput_ids=input_idsplumbing on the MLP/routerforward paths.
tests/unit_tests/transformer/moe/test_routers.py— restoredget_default_pg_collectionandTopKRouterimports.tests/unit_tests/transformer/moe/test_token_dispatcher.py—restored
MoETokenDispatcherimport.API mismatch audit
The merge took main's version in several "interface" files. After
re-injecting the dev-only features above:
TEFusedDenseMLP.as_mlp_submoduleis inherited fromTEFusedMLP(since it's a subclass) and is invokable through main's
MlpBuilderpattern.
_forward_mlp_routernow threadsinput_idstoself.mlp(...)again so MTP hash routing remains functional.
No deleted-from-dev files needed to be restored; the only file
genuinely deleted in this window (
.github/workflows/multi-approval-bot.yml)was intentionally removed on dev per PR #3576.
Conflict resolution overview
-X theirswas used. Files that had remerge conflicts:See commit
fd56123cefor the full merge content. The merge commitpreserves both parents (
origin/devandorigin/main).Generated by
Automated sync bot. CI fixes (if any) will land as a follow-up
commit on this branch.