Skip to content

[build] fix: move mamba-ssm and causal-conv1d to optional [ssm] extra #4517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ko3n1g merged 4 commits into from
Apr 29, 2026
Merged

[build] fix: move mamba-ssm and causal-conv1d to optional [ssm] extra #4517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ee1a6ee
[build] fix: move mamba-ssm and causal-conv1d to optional [ssm] extra
ko3n1g Apr 29, 2026
9525793
build: regenerate uv.lock after moving mamba-ssm/causal-conv1d to [ss…
ko3n1g Apr 29, 2026
36f6af2
build: install [ssm] extra in CI Dockerfile to restore mamba-ssm/caus…
ko3n1g Apr 29, 2026
541674a
build: move transformer-engine to optional [te] extra
ko3n1g Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker/Dockerfile.ci.dev
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# syntax=docker/dockerfile:1.3-labs

ARG FROM_IMAGE_NAME
FROM ${FROM_IMAGE_NAME} as main

Check warning on line 5 in docker/Dockerfile.ci.dev

View workflow job for this annotation

GitHub Actions / cicd-container-build (gcp, us-east4-docker.pkg.dev/nv-projdgxchipp-20260113193621/megatron-lm, nv...

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG ${FROM_IMAGE_NAME} results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/

Check warning on line 5 in docker/Dockerfile.ci.dev

View workflow job for this annotation

GitHub Actions / cicd-container-build (gcp, us-east4-docker.pkg.dev/nv-projdgxchipp-20260113193621/megatron-lm, nv...

The 'as' keyword should match the case of the 'from' keyword 

FromAsCasing: 'as' and 'FROM' keywords' casing do not match
More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

Check warning on line 5 in docker/Dockerfile.ci.dev

View workflow job for this annotation

GitHub Actions / cicd-container-build (aws, 766267172432.dkr.ecr.us-east-1.amazonaws.com, nvidia-ci-aws-gpu-x8)

The 'as' keyword should match the case of the 'from' keyword 

FromAsCasing: 'as' and 'FROM' keywords' casing do not match
More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

Check warning on line 5 in docker/Dockerfile.ci.dev

View workflow job for this annotation

GitHub Actions / cicd-container-build (aws, 766267172432.dkr.ecr.us-east-1.amazonaws.com, nvidia-ci-aws-gpu-x8)

Default value for global ARG results in an empty or invalid base image name 

InvalidDefaultArgInFrom: Default value for ARG ${FROM_IMAGE_NAME} results in empty or invalid base image name
More info: https://docs.docker.com/go/dockerfile/rule/invalid-default-arg-in-from/
ENV PIP_CONSTRAINT=""
ENV DEBIAN_FRONTEND=noninteractive
ARG UV_VERSION=0.7.2
Expand Down Expand Up @@ -41,7 +41,7 @@
export NVTE_CUDA_ARCHS="80;90;100"
uv venv ${UV_PROJECT_ENVIRONMENT} --system-site-packages
uv sync --only-group build
uv sync --extra ${IMAGE_TYPE} --extra mlm --link-mode copy --locked \
uv sync --extra ${IMAGE_TYPE} --extra mlm --extra ssm --extra te --link-mode copy --locked \
--no-install-package torch \
--no-install-package torchvision \
--no-install-package triton \
Expand Down Expand Up @@ -82,7 +82,7 @@
ENV UV_PYTHON=$UV_PROJECT_ENVIRONMENT/bin/python

##### For NVIDIANS only #####
FROM main as jet

Check warning on line 85 in docker/Dockerfile.ci.dev

View workflow job for this annotation

GitHub Actions / cicd-container-build (gcp, us-east4-docker.pkg.dev/nv-projdgxchipp-20260113193621/megatron-lm, nv...

The 'as' keyword should match the case of the 'from' keyword 

FromAsCasing: 'as' and 'FROM' keywords' casing do not match
More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/

Check warning on line 85 in docker/Dockerfile.ci.dev

View workflow job for this annotation

GitHub Actions / cicd-container-build (aws, 766267172432.dkr.ecr.us-east-1.amazonaws.com, nvidia-ci-aws-gpu-x8)

The 'as' keyword should match the case of the 'from' keyword 

FromAsCasing: 'as' and 'FROM' keywords' casing do not match
More info: https://docs.docker.com/go/dockerfile/rule/from-as-casing/
ARG JET_API_VERSION
ENV PATH="$PATH:/opt/jet/bin"
RUN --mount=type=secret,id=JET_INDEX_URLS bash -ex <<"EOF"
Expand Down
14 changes: 9 additions & 5 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,15 +89,12 @@ mlm = [

dev = [
"nvidia-modelopt[torch]; sys_platform != 'darwin'",
"transformer-engine[pytorch,core_cu13]",
"nvidia-resiliency-ext",
"tqdm",
"einops~=0.8",
"tensorstore~=0.1,!=0.1.46,!=0.1.72",
"multi-storage-client~=0.27",
"opentelemetry-api~=1.33.1",
"mamba-ssm~=2.2",
"causal-conv1d~=1.5",
"flash-linear-attention~=0.4.0",
"megatron-energon[av_decode]~=6.0",
"av",
Expand All @@ -119,8 +116,6 @@ lts = [
"tensorstore~=0.1,!=0.1.46,!=0.1.72",
"multi-storage-client~=0.27",
"opentelemetry-api~=1.33.1",
"mamba-ssm~=2.2",
"causal-conv1d~=1.5",
"megatron-energon[av_decode]~=6.0",
"av",
"flashinfer-python~=0.5.0",
Expand All @@ -131,6 +126,15 @@ lts = [
"emerging_optimizers",
]

te = [
"transformer-engine[pytorch,core_cu13]",
]

ssm = [
"mamba-ssm~=2.2",
"causal-conv1d~=1.5",
]

[dependency-groups]
test = [
"coverage",
Expand Down
Loading
Loading