[build] fix: move mamba-ssm and causal-conv1d to optional [ssm] extra - #4517
Merged
Conversation
Both packages require ~10 min CUDA compilation from source, making downstream consumers (e.g. Megatron-Bridge wheel build CI) exceed runner step limits intermittently. They are imported under try/except ImportError in mamba_mixer.py, so removing them from [dev]/[lts] does not break non-SSM workflows. Consumers that need Mamba model support should add the [ssm] extra: pip install megatron-core[dev,ssm] Signed-off-by: oliver könig <okoenig@nvidia.com>
svcnvidia-nemo-ci
marked this pull request as draft
April 29, 2026 08:06
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
…m] extra Signed-off-by: oliver könig <okoenig@nvidia.com>
Contributor
Author
|
/ok to test 9525793 |
…al-conv1d Signed-off-by: oliver könig <okoenig@nvidia.com>
Contributor
Author
|
/ok to test |
Remove transformer-engine from the [dev] extra and introduce a dedicated [te] optional extra so that a plain package install does not trigger CUDA compilation of TransformerEngine. CI Dockerfiles opt back in via --extra te to preserve the existing runtime behaviour. Signed-off-by: Oliver Koenig <okoenig@nvidia.com> Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: oliver könig <okoenig@nvidia.com>
Contributor
Author
|
/ok to test |
chtruong814
approved these changes
Apr 29, 2026
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25124805124 |
Contributor
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/25126205137 |
yangbofun
pushed a commit
to xlm-research/Megatron-LM
that referenced
this pull request
May 22, 2026
…NVIDIA#4517) Signed-off-by: oliver könig <okoenig@nvidia.com> Signed-off-by: Oliver Koenig <okoenig@nvidia.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
yhgalaxy
pushed a commit
to yhgalaxy/Megatron-LM
that referenced
this pull request
Jun 17, 2026
…NVIDIA#4517) Signed-off-by: oliver könig <okoenig@nvidia.com> Signed-off-by: Oliver Koenig <okoenig@nvidia.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: yhgalaxy <yhgalaxy@outlook.com>
jon-barker
pushed a commit
to jon-barker/Megatron-LM
that referenced
this pull request
Jul 10, 2026
…NVIDIA#4517) Signed-off-by: oliver könig <okoenig@nvidia.com> Signed-off-by: Oliver Koenig <okoenig@nvidia.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Jon Barker <jbarker@aws-cmh-slurm-1-vscode-02.cm.cluster>
terminator123
pushed a commit
to 021ai/Megatron-LM
that referenced
this pull request
Aug 3, 2026
…NVIDIA#4517) Signed-off-by: oliver könig <okoenig@nvidia.com> Signed-off-by: Oliver Koenig <okoenig@nvidia.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude summary
Problem
mamba-ssmandcausal-conv1dare listed in the[dev]and[lts]optional extras. Both packages have no pre-built wheels for common CUDA configurations and must be compiled from source, taking ~10 minutes each. This makes any downstream package that depends onmegatron-core[dev]— notably the Megatron-Bridge wheel build CI — routinely exceed k8s runner step limits, causing intermittent failures.Fix
Remove
mamba-ssmandcausal-conv1dfrom[dev]and[lts], and expose them as a dedicated[ssm]extra. This is safe because both packages are imported insidetry/except ImportErrorblocks inmamba_mixer.py— non-SSM workflows are unaffected.Usage for Mamba support: