Skip to content

Fix typo in PR4133. #4277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cspades merged 3 commits into from
Apr 14, 2026
Merged

Fix typo in PR4133. #4277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7816399
Fix typo in PR4133.
cspades Apr 13, 2026
7dfcc40
Merge branch 'main' into cye/decgrad-typo
cspades Apr 13, 2026
6df0085
Merge branch 'main' into cye/decgrad-typo
cspades Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion megatron/core/optimizer/optimizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1377,7 +1377,7 @@ def step(self):
or (
# Megatron-FSDP always uses decoupled_grad with FusedAdam.
self.config.use_precision_aware_optimizer
and getattr(params[0], "__fsdp_param__", False)
and getattr(parameters[0], "__fsdp_param__", False)
)
),
)
Expand Down
2 changes: 1 addition & 1 deletion tests/unit_tests/distributed/megatron_fsdp/test_mcore_fully_sharded_data_parallel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -773,7 +773,6 @@ def _training_loop(seed=42, **kwargs):

return outputs

@pytest.mark.flaky_in_dev
@pytest.mark.skipif(
not is_torch_min_version("2.4.0"), reason="Test needs to be updated for torch >= 2.4.0"
)
Expand Down Expand Up @@ -816,6 +815,7 @@ def _training_loop(seed=42, **kwargs):
data_parallel_sharding_strategy="optim_grads_params",
megatron_fsdp_main_params_dtype=torch.float32,
use_precision_aware_optimizer=True,
fp8="hybrid",
fp8_recipe="delayed",
fp8_param_gather=True,
bf16=True,
Expand Down
Loading