Skip to content

Fix typo in PR4133. - #4277

Merged
cspades merged 3 commits into
NVIDIA:mainfrom
cspades:cye/decgrad-typo
Apr 14, 2026
Merged

Fix typo in PR4133.#4277
cspades merged 3 commits into
NVIDIA:mainfrom
cspades:cye/decgrad-typo

Conversation

@cspades

@cspades cspades commented Apr 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

What does this PR do ?

FIXME(@cspades): Why aren't the PP tests catching this error?

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

@cspades
Fix typo in PR4133.
7816399 
Signed-off-by: Cory Ye <cye@nvidia.com>
@cspades cspades self-assigned this Apr 13, 2026
@cspades
cspades requested review from a team as code owners April 13, 2026 15:55
@cspades cspades added the bug Something isn't working label Apr 13, 2026
@svcnvidia-nemo-ci
svcnvidia-nemo-ci marked this pull request as draft April 13, 2026 15:55
@github-actions

github-actions Bot commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

This PR has been automatically converted to draft because all PRs must start as drafts.

When you are ready for review, click Ready for Review to begin the review process. This will:

  1. Add the oncall reviewer (optional reviewer)
  2. Add required review teams based on your changes

See the contribution guide for more details.

@copy-pr-bot

copy-pr-bot Bot commented Apr 13, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Apr 13, 2026
@cspades
cspades marked this pull request as ready for review April 13, 2026 16:00
@svcnvidia-nemo-ci
svcnvidia-nemo-ci requested a review from a team April 13, 2026 16:00
@svcnvidia-nemo-ci svcnvidia-nemo-ci added Final Review PR is in the "final review" stage complexity: low labels Apr 13, 2026
@cspades
cspades enabled auto-merge April 13, 2026 18:12
@svcnvidia-nemo-ci svcnvidia-nemo-ci added Approved All necessary approvals have been made and removed Final Review PR is in the "final review" stage labels Apr 13, 2026
@cspades
cspades added this pull request to the merge queue Apr 13, 2026
@svcnvidia-nemo-ci

svcnvidia-nemo-ci commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24361208969

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 13, 2026
@cspades
cspades added this pull request to the merge queue Apr 13, 2026
@cspades

cspades commented Apr 13, 2026

Copy link
Copy Markdown
Member Author

Random errors (networking, MBridge Docker pull failures, etc. from what I see) sending it back in

@svcnvidia-nemo-ci

svcnvidia-nemo-ci commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24368644455

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 13, 2026
@cspades
cspades enabled auto-merge April 14, 2026 00:38
@cspades
cspades added this pull request to the merge queue Apr 14, 2026
@svcnvidia-nemo-ci

svcnvidia-nemo-ci commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24377351696

@svcnvidia-nemo-ci

svcnvidia-nemo-ci commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24378546914

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 14, 2026
@cspades
cspades added this pull request to the merge queue Apr 14, 2026
@cspades
cspades removed this pull request from the merge queue due to a manual request Apr 14, 2026
@cspades
cspades added this pull request to the merge queue Apr 14, 2026
@svcnvidia-nemo-ci

svcnvidia-nemo-ci commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24407944282

Merged via the queue into NVIDIA:main with commit 4cef23c Apr 14, 2026
63 of 64 checks passed
@cspades
cspades deleted the cye/decgrad-typo branch April 14, 2026 16:27
Phlip79 added a commit to Phlip79/Megatron-LM that referenced this pull request Apr 17, 2026
@Phlip79 @claude
fix: correct params->parameters typo in ChainedOptimizer.step()
78ac06f 
Port of NVIDIA#4277 to dev. Fixes NameError raised when
ChainedOptimizer.step() takes the Megatron-FSDP + precision-aware
optimizer branch. Also adds the missing fp8="hybrid" mode to the
optim_grads_params_fused_adam_e2e test parametrization so the FSDP
e2e test exercises the fixed code path.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced Apr 17, 2026
Merged
Closed
@cspades cspades mentioned this pull request May 18, 2026
Open
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
@cspades
Fix typo in PR4133. (NVIDIA#4277)
a1db19b 
Signed-off-by: Cory Ye <cye@nvidia.com>
yhgalaxy pushed a commit to yhgalaxy/Megatron-LM that referenced this pull request Jun 17, 2026
@cspades @yhgalaxy
Fix typo in PR4133. (NVIDIA#4277)
e5bb260 
Signed-off-by: Cory Ye <cye@nvidia.com>
Signed-off-by: yhgalaxy <yhgalaxy@outlook.com>
jon-barker pushed a commit to jon-barker/Megatron-LM that referenced this pull request Jul 10, 2026
@cspades Jon Barker
Fix typo in PR4133. (NVIDIA#4277)
12ccd0b 
Signed-off-by: Cory Ye <cye@nvidia.com>
Signed-off-by: Jon Barker <jbarker@aws-cmh-slurm-1-vscode-02.cm.cluster>
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
@cspades @terminator123
Fix typo in PR4133. (NVIDIA#4277)
cc3c1b9 
Signed-off-by: Cory Ye <cye@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deepakn94 deepakn94 deepakn94 approved these changes
@ericharper ericharper ericharper approved these changes
+1 more reviewer
@malay-nagda malay-nagda malay-nagda approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@cspades cspades

Labels

Approved All necessary approvals have been made bug Something isn't working complexity: low

Projects

None yet

Milestone

Core 0.16

Development

Successfully merging this pull request may close these issues.

5 participants

@cspades @svcnvidia-nemo-ci @deepakn94 @ericharper @malay-nagda