revert: Revert emerging optimizer refactor (#4113, #4119) - #4156
Closed
ko3n1g wants to merge 2 commits into
Closed
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
ko3n1g
force-pushed
the
ko3n1g/revert/emerging-optimizer-refactor
branch
from
April 6, 2026 11:39
bf4a1d6 to
5f9f3ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_megatron_muon_optimizerwith thelayer_wise_distributed_optimizerparameter, which was removed in the refactoremerging_optimizers.py(introduced in Refactor emerging optimizer integration #4113)Motivation
The refactor caused a
TypeErrorin downstream users callingget_megatron_muon_optimizer(layer_wise_distributed_optimizer=...):Test plan
get_megatron_muon_optimizer(layer_wise_distributed_optimizer=True/False)works as beforetests/unit_tests/test_muon_optimizer.pytests/unit_tests/test_layer_wise_optimizer.py🤖 Generated with Claude Code