Skip to content

Add more emerging optimizers - #3907

Merged
FDecaYed merged 11 commits into
NVIDIA:devfrom
skyw:skyw/add_more_emerging_optimizers
Mar 19, 2026
Merged

Add more emerging optimizers#3907
FDecaYed merged 11 commits into
NVIDIA:devfrom
skyw:skyw/add_more_emerging_optimizers

Conversation

@skyw

@skyw skyw commented Mar 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do ?

Added adaptive muon and test.

Clean up some emerging optimizers code overall

A further update of _init_group is required from EmergingOptimizers side before distributed checkpoint can be supported.
Coresponding change: https://github.com/NVIDIA-NeMo/Emerging-Optimizers/pull/132/changes

Recommend to finish EmergingOptimizers update and pick it up in dev before merging to main branch.

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

skyw added 4 commits March 17, 2026 15:07
@skyw
add aaptive muon with necessary simplification
1ff345c 
Signed-off-by: Hao Wu <skyw@nvidia.com>
@skyw
add adpative muon to more places
ef58c81 
Signed-off-by: Hao Wu <skyw@nvidia.com>
@skyw
fix inheritance
11a63ce 
Signed-off-by: Hao Wu <skyw@nvidia.com>
@skyw
fix muon config
9fe6df1 
Signed-off-by: Hao Wu <skyw@nvidia.com>
@skyw
skyw requested review from FDecaYed and mkhona-nvidia March 17, 2026 22:42
@skyw
skyw requested review from a team as code owners March 17, 2026 22:42
@copy-pr-bot

copy-pr-bot Bot commented Mar 17, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

FDecaYed
FDecaYed approved these changes Mar 18, 2026
View reviewed changes

@FDecaYed FDecaYed left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FDecaYed

FDecaYed commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

/ok to test 9fe6df1

@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Mar 18, 2026
FDecaYed
FDecaYed requested changes Mar 18, 2026
View reviewed changes

@FDecaYed FDecaYed left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to also bump package dependency?

mkhona-nvidia
mkhona-nvidia reviewed Mar 18, 2026
View reviewed changes
Comment thread megatron/core/optimizer/emerging_optimizers.py
@skyw

skyw commented Mar 18, 2026

Copy link
Copy Markdown
Contributor Author

Need to also bump package dependency?

will tag a v0.2 after NVIDIA-NeMo/Emerging-Optimizers#135 and update here. change to draft

@skyw
skyw marked this pull request as draft March 18, 2026 17:33
skyw added 2 commits March 18, 2026 13:08
@skyw
add lion optimizers
be4b03d 
Signed-off-by: Hao Wu <skyw@nvidia.com>
@skyw
update emerging-optimizers version
00ade35 
Signed-off-by: Hao Wu <skyw@nvidia.com>
@skyw

skyw commented Mar 18, 2026

Copy link
Copy Markdown
Contributor Author

Need to also bump package dependency?

updated.

@skyw
skyw marked this pull request as ready for review March 18, 2026 20:11
@skyw
skyw requested a review from a team as a code owner March 18, 2026 20:11
@skyw

skyw commented Mar 18, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 00ade35

skyw and others added 2 commits March 18, 2026 13:18
@skyw

skyw commented Mar 18, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 46336bf

@skyw
fix lint error
9d82c16 
Signed-off-by: Hao Wu <skyw@nvidia.com>
@skyw

skyw commented Mar 18, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 9d82c16

@skyw
remove python 3.12 feature for now
9bc2cb6 
Signed-off-by: Hao Wu <skyw@nvidia.com>
@skyw

skyw commented Mar 18, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 9bc2cb6

@FDecaYed

FDecaYed commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

/ok to test 4038625

FDecaYed
FDecaYed approved these changes Mar 19, 2026
View reviewed changes

@FDecaYed FDecaYed left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test all passing. LGTM

@FDecaYed
FDecaYed enabled auto-merge March 19, 2026 08:23
@FDecaYed
FDecaYed added this pull request to the merge queue Mar 19, 2026
@svcnvidia-nemo-ci

svcnvidia-nemo-ci commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/23295640720

Merged via the queue into NVIDIA:dev with commit 8ae70d4 Mar 19, 2026
49 of 50 checks passed
@FDecaYed
FDecaYed deleted the skyw/add_more_emerging_optimizers branch March 19, 2026 13:53
@skyw skyw mentioned this pull request Mar 31, 2026
Closed
5 tasks
skyw added a commit to skyw/Megatron-LM that referenced this pull request Apr 3, 2026
@skyw
Add more emerging optimizers (NVIDIA#3907)
cd77916
@skyw skyw mentioned this pull request Apr 3, 2026
Merged
5 tasks
github-merge-queue Bot pushed a commit that referenced this pull request Apr 3, 2026
@skyw
Add more emerging optimizers (#3907) (#4119)
c9797ad 
Signed-off-by: Hao Wu <skyw@nvidia.com>
ko3n1g added a commit to ko3n1g/Megatron-LM that referenced this pull request Apr 6, 2026
@ko3n1g
Revert "Add more emerging optimizers (NVIDIA#3907) (NVIDIA#4119)"
ba6f008 
This reverts commit c9797ad.

Signed-off-by: oliver könig <okoenig@nvidia.com>
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
@skyw
Add more emerging optimizers (NVIDIA#3907) (NVIDIA#4119)
79055d1 
Signed-off-by: Hao Wu <skyw@nvidia.com>
yhgalaxy pushed a commit to yhgalaxy/Megatron-LM that referenced this pull request Jun 17, 2026
@skyw @yhgalaxy
Add more emerging optimizers (NVIDIA#3907) (NVIDIA#4119)
344b21e 
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: yhgalaxy <yhgalaxy@outlook.com>
jon-barker pushed a commit to jon-barker/Megatron-LM that referenced this pull request Jul 10, 2026
@skyw Jon Barker
Add more emerging optimizers (NVIDIA#3907) (NVIDIA#4119)
2a21704 
Signed-off-by: Hao Wu <skyw@nvidia.com>
Signed-off-by: Jon Barker <jbarker@aws-cmh-slurm-1-vscode-02.cm.cluster>
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
@skyw @terminator123
Add more emerging optimizers (NVIDIA#3907) (NVIDIA#4119)
c2bb53b 
Signed-off-by: Hao Wu <skyw@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkhona-nvidia mkhona-nvidia mkhona-nvidia left review comments
@FDecaYed FDecaYed FDecaYed approved these changes
@chtruong814 chtruong814 chtruong814 approved these changes

Assignees

No one assigned

Labels

complexity: medium

Projects

None yet

Milestone

Core 0.16

Development

Successfully merging this pull request may close these issues.

5 participants

@skyw @FDecaYed @svcnvidia-nemo-ci @mkhona-nvidia @chtruong814