Skip to content

revert of #2658#3736

Merged
sbak5 merged 2 commits intoNVIDIA:mainfrom
dimapihtar:revert_2658
Mar 9, 2026
Merged

revert of #2658#3736
sbak5 merged 2 commits intoNVIDIA:mainfrom
dimapihtar:revert_2658

Conversation

@dimapihtar
Copy link
Copy Markdown
Contributor

What does this PR do ?

Reverts #2658

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

Pre-checks

  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.

Step 1: Mark PR as "Ready for Review"

  1. When your PR is ready, click Ready for Review.
  2. An oncall reviewer is auto-assigned and expert reviewers are notified based on your changes.
    • Some PRs may jump straight to step 2. This is determined by .github/CODEOWNERS.

⚠️ Only mark as ready once merge-conflicts are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

Step 2: Final Review

For PRs that change megatron/core, once all expert reviewers have approved, the Final Review label is applied automatically and final reviewers are assigned.

For PRs outside megatron/core, this step is skipped.

Step 3: Approved

Once all required reviewers have approved, the Approved label is applied automatically.

Merge

Any member of mcore-engineers will be able to merge your PR.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Signed-off-by: dimapihtar <dpihtar@gmail.com>
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Mar 6, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@dimapihtar dimapihtar added Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. complexity: low labels Mar 6, 2026
@dimapihtar dimapihtar marked this pull request as ready for review March 6, 2026 17:34
@svcnvidia-nemo-ci svcnvidia-nemo-ci requested a review from a team March 6, 2026 17:34
@dimapihtar dimapihtar requested review from sbak5 and removed request for a team March 6, 2026 17:34
@dimapihtar
Copy link
Copy Markdown
Contributor Author

/ok to test cfe9bf6

@dimapihtar dimapihtar changed the title revert of 2658 revert of #2658 Mar 6, 2026
@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Mar 6, 2026
@sbak5
Copy link
Copy Markdown
Contributor

sbak5 commented Mar 9, 2026

/claude review

@sbak5 sbak5 added this pull request to the merge queue Mar 9, 2026
@svcnvidia-nemo-ci
Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/22867194032

Copy link
Copy Markdown
Contributor

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — clean revert of #2658, restoring the original RNG sharding by PP/TP only.

Merged via the queue into NVIDIA:main with commit 56158bb Mar 9, 2026
54 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity: low Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants