Skip to content

Update RNG sharding to include EP rank#2658

Merged
dimapihtar merged 3 commits intoNVIDIA:mainfrom
paul-gibbons:pg/rng_state_fix_ep
Dec 17, 2025
Merged

Update RNG sharding to include EP rank#2658
dimapihtar merged 3 commits intoNVIDIA:mainfrom
paul-gibbons:pg/rng_state_fix_ep

Conversation

@paul-gibbons
Copy link
Contributor

What does this PR do ?

Cuda RNG states are not properly saved+restored when training models with EP. RNG sharding only accounts for TP+PP.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

Signed-off-by: Paul Gibbons <pgibbons@nvidia.com>
@copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 13, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Copy link
Contributor

@dimapihtar dimapihtar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@dimapihtar
Copy link
Contributor

/ok to test 43b525e

Signed-off-by: Paul Gibbons <pgibbons@nvidia.com>
Signed-off-by: Paul Gibbons <pgibbons@nvidia.com>
@dimapihtar
Copy link
Contributor

/ok to test 17b2e92

@dimapihtar dimapihtar added this pull request to the merge queue Dec 17, 2025
Merged via the queue into NVIDIA:main with commit 2485495 Dec 17, 2025
47 checks passed
maanug-nv pushed a commit to maanug-nv/Megatron-LM that referenced this pull request Jan 10, 2026
Signed-off-by: Paul Gibbons <pgibbons@nvidia.com>
daiyaanarfeen pushed a commit to daiyaanarfeen/Megatron-LM that referenced this pull request Feb 23, 2026
Signed-off-by: Paul Gibbons <pgibbons@nvidia.com>
@dimapihtar dimapihtar mentioned this pull request Mar 6, 2026
5 tasks
github-merge-queue bot pushed a commit that referenced this pull request Mar 9, 2026
Signed-off-by: dimapihtar <dpihtar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants