Skip to content

[main] fix(moe): fix the bug where gate was not sliced when kv_head < tp_size. - #3575

Merged
Phlip79 merged 5 commits into
NVIDIA:mainfrom
yuzhongw-nvidia:yuzhongw/fix_output_gate
Mar 11, 2026
Merged

[main] fix(moe): fix the bug where gate was not sliced when kv_head < tp_size.#3575
Phlip79 merged 5 commits into
NVIDIA:mainfrom
yuzhongw-nvidia:yuzhongw/fix_output_gate

Conversation

@yuzhongw-nvidia

Copy link
Copy Markdown
Contributor

What does this PR do ?

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

PR for dev: #3529

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@yuzhongw-nvidia
yuzhongw-nvidia requested review from a team as code owners February 25, 2026 02:21
@copy-pr-bot

copy-pr-bot Bot commented Feb 25, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@svcnvidia-nemo-ci
svcnvidia-nemo-ci requested a review from a team February 25, 2026 02:21
@yuzhongw-nvidia yuzhongw-nvidia added module: moe Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. labels Feb 25, 2026
@yuzhongw-nvidia

Copy link
Copy Markdown
Contributor Author

/ok to test e87d1ad

@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Feb 25, 2026
@yuzhongw-nvidia

Copy link
Copy Markdown
Contributor Author

/ok to test 7d48f18

@yuzhongw-nvidia

Copy link
Copy Markdown
Contributor Author

/ok to test e168f02

@yuzhongw-nvidia

Copy link
Copy Markdown
Contributor Author

/ok to test fc52b0b

@Phlip79 Phlip79 added Final Review PR is in the "final review" stage complexity: medium and removed Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. labels Mar 2, 2026
@yuzhongw-nvidia
yuzhongw-nvidia force-pushed the yuzhongw/fix_output_gate branch from fc52b0b to 5f04037 Compare March 5, 2026 09:47
@yuzhongw-nvidia

Copy link
Copy Markdown
Contributor Author

/ok to test 5f04037

@svcnvidia-nemo-ci svcnvidia-nemo-ci added Approved All necessary approvals have been made and removed Final Review PR is in the "final review" stage labels Mar 11, 2026
@Phlip79
Phlip79 enabled auto-merge March 11, 2026 05:37
@Phlip79
Phlip79 added this pull request to the merge queue Mar 11, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/22938544599

Merged via the queue into NVIDIA:main with commit 16a8cdb Mar 11, 2026
54 of 56 checks passed
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
… tp_size. (NVIDIA#3575)

Co-authored-by: xiaotaoliu <xiaotaoliu@tencent.com>
yhgalaxy pushed a commit to yhgalaxy/Megatron-LM that referenced this pull request Jun 17, 2026
… tp_size. (NVIDIA#3575)

Co-authored-by: xiaotaoliu <xiaotaoliu@tencent.com>
Signed-off-by: yhgalaxy <yhgalaxy@outlook.com>
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
… tp_size. (NVIDIA#3575)

Co-authored-by: xiaotaoliu <xiaotaoliu@tencent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made complexity: medium module: moe

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants