Skip to content

Fix documented shape - #3486

Merged
janEbert merged 1 commit into
NVIDIA:mainfrom
janEbert:fix-llava-emb-shape-docs
Apr 15, 2026
Merged

Fix documented shape#3486
janEbert merged 1 commit into
NVIDIA:mainfrom
janEbert:fix-llava-emb-shape-docs

Conversation

@janEbert

Copy link
Copy Markdown
Contributor

What does this PR do ?

The output shape is different when self.context_parallel_lm != 1. This is now properly documented.

@duncanriach I had trouble reasoning about #3476 from just the docstrings; then I saw the previously not considered conditional transposition. :)

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

The output shape is different when `self.context_parallel_lm != 1`. This
is now properly documented.
@janEbert
janEbert requested review from a team as code owners February 19, 2026 12:56
@janEbert janEbert added Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. docs-only documentation only (docs or docstrings) complexity: low labels Feb 19, 2026
@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Feb 19, 2026
@svcnvidia-nemo-ci
svcnvidia-nemo-ci requested a review from a team February 19, 2026 12:56
@janEbert
janEbert enabled auto-merge February 19, 2026 12:58

Returns:
final_embedding (torch.Tensor): image and text embeddings [combined_seq_len, b, h].
final_embedding (torch.Tensor): image and text embeddings [combined_seq_len, b, h] if

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janEbert
janEbert added this pull request to the merge queue Apr 15, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/24464624994

@svcnvidia-nemo-ci svcnvidia-nemo-ci added the Final Review PR is in the "final review" stage label Apr 15, 2026
Merged via the queue into NVIDIA:main with commit 1d344ae Apr 15, 2026
35 checks passed
@janEbert
janEbert deleted the fix-llava-emb-shape-docs branch April 15, 2026 16:31
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
yhgalaxy pushed a commit to yhgalaxy/Megatron-LM that referenced this pull request Jun 17, 2026
Signed-off-by: yhgalaxy <yhgalaxy@outlook.com>
jon-barker pushed a commit to jon-barker/Megatron-LM that referenced this pull request Jul 10, 2026
Signed-off-by: Jon Barker <jbarker@aws-cmh-slurm-1-vscode-02.cm.cluster>
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity: low docs-only documentation only (docs or docstrings) Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. Final Review PR is in the "final review" stage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants