Skip to content

Remove redundant CUDA calls in the LLaVA dataloader - #3476

Merged
janEbert merged 2 commits into
NVIDIA:mainfrom
duncanriach:improve-llava-model
Feb 23, 2026
Merged

Remove redundant CUDA calls in the LLaVA dataloader#3476
janEbert merged 2 commits into
NVIDIA:mainfrom
duncanriach:improve-llava-model

Conversation

@duncanriach

@duncanriach duncanriach commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

What does this PR do ?

Removes redundant CUDA calls in the LLaVA dataloader. See internal MR 3840

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@duncanriach
duncanriach requested review from a team as code owners February 18, 2026 20:47
@ko3n1g ko3n1g added this to the Core 0.16 milestone Feb 18, 2026
@svcnvidia-nemo-ci
svcnvidia-nemo-ci requested a review from a team February 18, 2026 20:47
@duncanriach duncanriach changed the title Improve token parallel functionality in LLaVA model Remove redundant CUDA calls in the LLaVA dataloader Feb 18, 2026
@duncanriach duncanriach added the Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. label Feb 18, 2026
@duncanriach duncanriach self-assigned this Feb 18, 2026
@janEbert

Copy link
Copy Markdown
Contributor

/ok to test 6d2340b

@janEbert janEbert mentioned this pull request Feb 19, 2026
6 tasks
@duncanriach duncanriach added Final Review PR is in the "final review" stage and removed Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. labels Feb 19, 2026
@janEbert
janEbert enabled auto-merge February 23, 2026 19:12
@janEbert
janEbert added this pull request to the merge queue Feb 23, 2026
@svcnvidia-nemo-ci

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/22325051550

Merged via the queue into NVIDIA:main with commit a0b9c16 Feb 23, 2026
47 of 48 checks passed
ko3n1g pushed a commit to ko3n1g/Megatron-LM that referenced this pull request Feb 26, 2026
BoxiangW pushed a commit to BoxiangW/Megatron-LM that referenced this pull request Mar 4, 2026
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Final Review PR is in the "final review" stage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants