Skip to content

Update moe github test cases. - #3077

Merged
Victarry merged 4 commits into
NVIDIA:mainfrom
Victarry:denliu/update_moe_github_tests_main
Feb 13, 2026
Merged

Update moe github test cases.#3077
Victarry merged 4 commits into
NVIDIA:mainfrom
Victarry:denliu/update_moe_github_tests_main

Conversation

@Victarry

Copy link
Copy Markdown

What does this PR do ?

Mirror of #2449

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@Victarry
Victarry requested a review from a team as a code owner January 26, 2026 08:00
@copy-pr-bot

copy-pr-bot Bot commented Jan 26, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@ko3n1g
ko3n1g requested a review from a team January 26, 2026 08:00
@Victarry Victarry self-assigned this Jan 26, 2026
@Victarry

Copy link
Copy Markdown
Author

/ok to test b32f729

@maanug-nv maanug-nv added Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. complexity: low labels Jan 27, 2026
@maanug-nv
maanug-nv requested a review from ko3n1g January 27, 2026 02:15
@Victarry

Copy link
Copy Markdown
Author

/ok to test fba124f

@Phlip79

Phlip79 commented Feb 4, 2026

Copy link
Copy Markdown
Member

@Victarry can you please look into resolving merge conflict and failing tests?

@Victarry
Victarry force-pushed the denliu/update_moe_github_tests_main branch from fba124f to 18590b5 Compare February 6, 2026 08:40
@Victarry

Victarry commented Feb 6, 2026

Copy link
Copy Markdown
Author

/ok to test 18590b5

Comment thread tests/test_utils/recipes/h100/moe.yaml Outdated
@Victarry

Copy link
Copy Markdown
Author

/ok to test 1288f01

@Victarry

Copy link
Copy Markdown
Author

/ok to test 9945aa9

@ko3n1g

ko3n1g commented Feb 13, 2026

Copy link
Copy Markdown
Contributor

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/21976763947

Merged via the queue into NVIDIA:main with commit 9119fae Feb 13, 2026
201 of 203 checks passed
@Victarry
Victarry deleted the denliu/update_moe_github_tests_main branch February 13, 2026 06:52
ko3n1g added a commit that referenced this pull request Feb 13, 2026
BoxiangW pushed a commit to BoxiangW/Megatron-LM that referenced this pull request Mar 4, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Philip Petrakian <ppetrakian@nvidia.com>
BoxiangW pushed a commit to BoxiangW/Megatron-LM that referenced this pull request Mar 4, 2026
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Philip Petrakian <ppetrakian@nvidia.com>
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Philip Petrakian <ppetrakian@nvidia.com>
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity: low Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. Run functional tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants