Skip to content

[DEV] Update GitHub MoE functional test cases - #2449

Merged
Victarry merged 3 commits into
NVIDIA:devfrom
Victarry:denliu/update_github_tests
Dec 8, 2025
Merged

[DEV] Update GitHub MoE functional test cases#2449
Victarry merged 3 commits into
NVIDIA:devfrom
Victarry:denliu/update_github_tests

Conversation

@Victarry

@Victarry Victarry commented Dec 2, 2025

Copy link
Copy Markdown

What does this PR do ?

PR to main #3077

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share discuss a design-doc with the team.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@Victarry
Victarry requested review from a team as code owners December 2, 2025 07:34
@copy-pr-bot

copy-pr-bot Bot commented Dec 2, 2025

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@Victarry
Victarry marked this pull request as draft December 2, 2025 07:34
@Victarry

Victarry commented Dec 2, 2025

Copy link
Copy Markdown
Author

/ok to test 6711a81

@ko3n1g ko3n1g added this to the Core 0.16 milestone Dec 2, 2025
@Victarry Victarry self-assigned this Dec 2, 2025
@Victarry Victarry added the dev branch Dev branch related issues and development label Dec 2, 2025
@Victarry

Victarry commented Dec 2, 2025

Copy link
Copy Markdown
Author

/ok to test db36cf4

@Victarry

Victarry commented Dec 2, 2025

Copy link
Copy Markdown
Author

/ok to test 02c0aa9

@Victarry
Victarry marked this pull request as ready for review December 2, 2025 13:09
@Victarry Victarry changed the title [Draft] Update github CI functional test cases [DEV] Update GitHub MoE functional test cases Dec 2, 2025
@Victarry
Victarry requested review from ko3n1g and yanring December 2, 2025 14:08
@Victarry
Victarry added this pull request to the merge queue Dec 8, 2025
Merged via the queue into NVIDIA:dev with commit 1d462bd Dec 8, 2025
51 checks passed
@Victarry
Victarry deleted the denliu/update_github_tests branch December 8, 2025 23:00
@yanring

yanring commented Dec 10, 2025

Copy link
Copy Markdown
Contributor

Please submit a mirror PR to main, thanks

@Victarry

Copy link
Copy Markdown
Author

Please submit a mirror PR to main, thanks

The newly added GitHub CI test cases(Muon, scoped cuda graph, CPU offloading) don't exist in the main branch. Will submit a PR when these features get merged into main branch.

@Victarry Victarry mentioned this pull request Jan 26, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev branch Dev branch related issues and development Run functional tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants