Skip to content

Reduce Overhead in Timers - #2210

Merged
ko3n1g merged 7 commits into
NVIDIA:mainfrom
yaox12:xiny/fix_counting_zeros_main
Nov 25, 2025
Merged

Reduce Overhead in Timers#2210
ko3n1g merged 7 commits into
NVIDIA:mainfrom
yaox12:xiny/fix_counting_zeros_main

Conversation

@yaox12

@yaox12 yaox12 commented Nov 11, 2025

Copy link
Copy Markdown
Member

What does this PR do ?

Update: when there're no timers to log (e.g., log_level=0), only ~0.02ms overhead.

Previously, timers.log takes ~5ms, where a lot of PyTorch ops are invoked.

image

Now, it's reduced to ~0.44 ms.

image

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

Signed-off-by: Xin Yao <xiny@nvidia.com>
@yaox12
yaox12 requested a review from a team as a code owner November 11, 2025 10:11
@yaox12 yaox12 added the Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. label Nov 11, 2025
@yaox12
yaox12 requested a review from a team as a code owner November 11, 2025 10:11
@copy-pr-bot

copy-pr-bot Bot commented Nov 11, 2025

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yaox12 yaox12 changed the title Reduce Overhead in Timer Reduce Overhead in Timers Nov 11, 2025
@yaox12 yaox12 removed the Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. label Nov 11, 2025
@yaox12
yaox12 marked this pull request as draft November 11, 2025 10:19
Signed-off-by: Xin Yao <xiny@nvidia.com>
@yaox12
yaox12 marked this pull request as ready for review November 11, 2025 10:57
@yaox12 yaox12 added the Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. label Nov 11, 2025
'optimizer-copy-main-to-model-params',
'optimizer',
]
timers_to_log = []

@yaox12 yaox12 Nov 11, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grouped by the levels at which they're created.

Signed-off-by: Xin Yao <xiny@nvidia.com>
@yaox12
yaox12 force-pushed the xiny/fix_counting_zeros_main branch from dd7c6ab to 290d1ae Compare November 12, 2025 06:42
@yaox12 yaox12 mentioned this pull request Nov 13, 2025
6 tasks
@yanring yanring added this to the Core 0.16 milestone Nov 14, 2025
Comment thread megatron/core/timers.py
Comment thread megatron/core/timers.py Outdated
@yanring
yanring enabled auto-merge November 18, 2025 01:08
@yanring yanring added the Final Review PR is in the "final review" stage label Nov 18, 2025
@yaox12 yaox12 removed the Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. label Nov 18, 2025
@yaox12
yaox12 requested a review from ericharper November 20, 2025 01:38
@yaox12

yaox12 commented Nov 20, 2025

Copy link
Copy Markdown
Member Author

/ok to test 0965795

@yaox12

yaox12 commented Nov 25, 2025

Copy link
Copy Markdown
Member Author

/ok to test b34dc58

@yanring
yanring added this pull request to the merge queue Nov 25, 2025
github-merge-queue Bot pushed a commit that referenced this pull request Nov 25, 2025
Signed-off-by: Xin Yao <xiny@nvidia.com>
github-merge-queue Bot pushed a commit that referenced this pull request Nov 25, 2025
Signed-off-by: Xin Yao <xiny@nvidia.com>
@ko3n1g
ko3n1g removed this pull request from the merge queue due to a manual request Nov 25, 2025
@ko3n1g
ko3n1g added this pull request to the merge queue Nov 25, 2025
Merged via the queue into NVIDIA:main with commit ffb8c35 Nov 25, 2025
47 checks passed
@yaox12
yaox12 deleted the xiny/fix_counting_zeros_main branch November 26, 2025 02:02
frsun-nvda pushed a commit to frsun-nvda/Megatron-LM that referenced this pull request Dec 1, 2025
Signed-off-by: Xin Yao <xiny@nvidia.com>
cspades pushed a commit to cspades/Megatron-LM that referenced this pull request Jan 7, 2026
Signed-off-by: Xin Yao <xiny@nvidia.com>
daiyaanarfeen pushed a commit to daiyaanarfeen/Megatron-LM that referenced this pull request Feb 23, 2026
Signed-off-by: Xin Yao <xiny@nvidia.com>
yangbofun pushed a commit to xlm-research/Megatron-LM that referenced this pull request May 22, 2026
Signed-off-by: Xin Yao <xiny@nvidia.com>
terminator123 pushed a commit to 021ai/Megatron-LM that referenced this pull request Aug 3, 2026
Signed-off-by: Xin Yao <xiny@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Final Review PR is in the "final review" stage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants