[Dev] Reduce Overhead in Timers - #2208
Merged
Merged
Conversation
yaox12
marked this pull request as draft
November 11, 2025 10:19
yaox12
force-pushed
the
xiny/fix_counting_zeros
branch
from
November 11, 2025 10:51
3ed345c to
d2c0e1a
Compare
yaox12
marked this pull request as ready for review
November 11, 2025 10:52
yaox12
commented
Nov 11, 2025
| 'optimizer', | ||
| ] | ||
| timers_to_log = [] | ||
| if args.timing_log_level >= 1: |
Member
Author
There was a problem hiding this comment.
Grouped by the levels at which they're created.
Member
Author
|
/ok to test 970f01b |
yaox12
force-pushed
the
xiny/fix_counting_zeros
branch
from
November 12, 2025 06:42
3151749 to
6fa642c
Compare
Member
Author
|
/ok to test 6fa642c |
Signed-off-by: Xin Yao <xiny@nvidia.com>
Signed-off-by: Xin Yao <xiny@nvidia.com>
yaox12
force-pushed
the
xiny/fix_counting_zeros
branch
from
November 12, 2025 07:33
6fa642c to
9a09a00
Compare
Member
Author
|
/ok to test 9a09a00 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
PR to the main branch: #2210
Update: when there're no timers to log (e.g.,
log_level=0), only ~0.02ms overhead.Previously,
timers.logtakes ~5ms, where a lot of PyTorch ops are invoked.Now, it's reduced to ~0.44 ms.
Contribution process
flowchart LR A[Pre-checks] --> B[PR Tests] subgraph Code Review/Approval C1[Expert Review] --> C2[Final Review] end B --> C1 C2 --> D[Merge]Pre-checks
Core 0.8)Code review
The following process is enforced via the CODEOWNERS file for changes into
megatron/core. For changes outside ofmegatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.For MRs into `main` branch
(Step 1): Add PR label
Expert Review(Step 2): Collect the expert reviewers reviews
Expert Reviewlabel when your PR is ready for review.Final Review might get declined if these requirements are not fulfilled.
(Step 3): Final Review
Final Reviewlabel(Optional Step 4): Cherry-pick into release branch
If this PR also needs to be merged into
core_r*release branches, after this PR has been merged, selectCherry-pickto open a new PR into the release branch.For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.Merging your PR
Any member of core-adlr and
core-nemowill be able to merge your PR.