Skip to content

[Dev] Reduce Overhead in Timers - #2208

Merged
Victarry merged 3 commits into
NVIDIA:devfrom
yaox12:xiny/fix_counting_zeros
Nov 12, 2025
Merged

[Dev] Reduce Overhead in Timers#2208
Victarry merged 3 commits into
NVIDIA:devfrom
yaox12:xiny/fix_counting_zeros

Conversation

@yaox12

@yaox12 yaox12 commented Nov 11, 2025

Copy link
Copy Markdown
Member

What does this PR do ?

PR to the main branch: #2210

Update: when there're no timers to log (e.g., log_level=0), only ~0.02ms overhead.

Previously, timers.log takes ~5ms, where a lot of PyTorch ops are invoked.

image

Now, it's reduced to ~0.44 ms.

image

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@yaox12
yaox12 requested review from a team as code owners November 11, 2025 10:10
@yaox12 yaox12 added Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. dev branch Dev branch related issues and development labels Nov 11, 2025
@copy-pr-bot

copy-pr-bot Bot commented Nov 11, 2025

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yaox12 yaox12 removed the Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. label Nov 11, 2025
@yaox12
yaox12 marked this pull request as draft November 11, 2025 10:19
@yaox12
yaox12 force-pushed the xiny/fix_counting_zeros branch from 3ed345c to d2c0e1a Compare November 11, 2025 10:51
@yaox12
yaox12 marked this pull request as ready for review November 11, 2025 10:52
'optimizer',
]
timers_to_log = []
if args.timing_log_level >= 1:

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grouped by the levels at which they're created.

@yaox12 yaox12 added the Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. label Nov 11, 2025

@FDecaYed FDecaYed left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@yaox12

yaox12 commented Nov 12, 2025

Copy link
Copy Markdown
Member Author

/ok to test 970f01b

@yaox12

yaox12 commented Nov 12, 2025

Copy link
Copy Markdown
Member Author

/ok to test 6fa642c

Signed-off-by: Xin Yao <xiny@nvidia.com>
Signed-off-by: Xin Yao <xiny@nvidia.com>
Signed-off-by: Xin Yao <xiny@nvidia.com>
@yaox12
yaox12 force-pushed the xiny/fix_counting_zeros branch from 6fa642c to 9a09a00 Compare November 12, 2025 07:33
@yaox12

yaox12 commented Nov 12, 2025

Copy link
Copy Markdown
Member Author

/ok to test 9a09a00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev branch Dev branch related issues and development Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants