[Dev] Update symmetric registration interface to sync-up with upstream pytorch change - #1930
Merged
youngeunkwon0405 merged 4 commits intoOct 28, 2025
Merged
Conversation
Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com> update Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
Signed-off-by: Youngeun <kyeg9404@gmail.com> Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
youngeunkwon0405
added
the
Expert Review
Member
Author
|
/ok to test bcd2b81 |
Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
Member
Author
|
/ok to test 1ad740f |
youngeunkwon0405
added
Final Review
erhoo82
approved these changes
Oct 28, 2025
youngeunkwon0405
enabled auto-merge
October 28, 2025 04:28
ericharper
approved these changes
Oct 28, 2025
Contributor
|
Hey @youngeunkwon0405 can we have a mirror PR to main? |
Member
Author
I have already merged that #1924 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a change in the symmetric registration interface from the upstream pytorch.
Upstream change: pytorch/pytorch#161238
This PR syncs with this change and still supports legacy APIs.