Update symmetric registration interface to sync-up with upstream pytorch change - #1924
Merged
ko3n1g merged 6 commits intoOct 29, 2025
Merged
Conversation
youngeunkwon0405
force-pushed
the
symmetric-reg-new-interface
branch
from
October 24, 2025 18:34
d56c1c3 to
6d7f1d8
Compare
Skylion007
reviewed
Oct 24, 2025
| # Prefer attempting symmetric registration first; fall back if unsupported. | ||
| if self.symmetric: | ||
| try: | ||
| # Since PyTorch PR #161238 symmetric knob is now in registration function. |
Contributor
There was a problem hiding this comment.
True, but you could always do version checks. :)
Skylion007
approved these changes
Oct 24, 2025
Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com> update Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
Signed-off-by: Youngeun <kyeg9404@gmail.com> Signed-off-by: Youngeun Kwon <youngeunk@nvidia.com>
youngeunkwon0405
force-pushed
the
symmetric-reg-new-interface
branch
from
October 24, 2025 21:49
6d7f1d8 to
d85aa69
Compare
Member
Author
|
/ok to test d85aa69 |
youngeunkwon0405
added
Expert Review
ko3n1g
removed
the
Expert Review
Member
Author
|
/ok to test d85aa69 |
Member
Author
|
/ok to test 5a54fe7 |
Contributor
|
/ok to test 54cd520 |
Contributor
|
/ok to test 70a5092 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a change in the symmetric registration interface from the upstream pytorch.
Upstream change: pytorch/pytorch#161238
This PR syncs with this change and still supports legacy APIs.