feat(studio): job-detail placeholder route for Anonymizer [ASTD-331] - #887
Merged
marcusds merged 4 commits intoJul 24, 2026
Merged
Conversation
…TD-327] The :name route rendered the builder form (shared component). Split it: /new keeps the builder, /:name renders a job-detail placeholder showing the job name. Full detail page is ASTD-330. Signed-off-by: mschwab <mschwab@nvidia.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds a feature-flagged anonymizer job detail placeholder route, uses the job name for breadcrumbs and headings, and wires the route through lazy loading. ChangesAnonymizer job detail
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
web/packages/studio/src/routes/AnonymizerJobDetailRoute/index.tsx (1)
9-9: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUse
import typeforFCin both modules.
web/packages/studio/src/routes/AnonymizerJobDetailRoute/index.tsx#L9-L9: change theFCimport toimport type.web/packages/studio/src/routes/groups/anonymizerRoutes.tsx#L25-L31: splitFCfrom the value import and import it withimport type.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@web/packages/studio/src/routes/AnonymizerJobDetailRoute/index.tsx` at line 9, Use type-only imports for FC in web/packages/studio/src/routes/AnonymizerJobDetailRoute/index.tsx lines 9-9 and web/packages/studio/src/routes/groups/anonymizerRoutes.tsx lines 25-31; split FC from any value imports in the latter module while preserving all existing runtime imports.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web/packages/studio/src/routes/AnonymizerJobDetailRoute/index.tsx`:
- Around line 12-13: Update AnonymizerJobDetailRoute and the ANONYMIZER_ENABLED
definition so the anonymizer is disabled when VITE_FF_ANONYMIZER_ENABLED is
unset, enabling it only when explicitly opted in. Preserve the route’s existing
conditional behavior for explicit enablement.
---
Nitpick comments:
In `@web/packages/studio/src/routes/AnonymizerJobDetailRoute/index.tsx`:
- Line 9: Use type-only imports for FC in
web/packages/studio/src/routes/AnonymizerJobDetailRoute/index.tsx lines 9-9 and
web/packages/studio/src/routes/groups/anonymizerRoutes.tsx lines 25-31; split FC
from any value imports in the latter module while preserving all existing
runtime imports.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 21ea0749-1563-4fae-9199-a9bb458854c0
📒 Files selected for processing (2)
web/packages/studio/src/routes/AnonymizerJobDetailRoute/index.tsxweb/packages/studio/src/routes/groups/anonymizerRoutes.tsx
Contributor
|
Signed-off-by: mschwab <mschwab@nvidia.com>
steramae-nvidia
approved these changes
Jul 24, 2026
steramae-nvidia
left a comment
steramae-nvidia
left a comment
Contributor
There was a problem hiding this comment.
Approved but seems like you need to fix the lint error
…331] Signed-off-by: mschwab <mschwab@nvidia.com>
marcusds
enabled auto-merge
July 24, 2026 17:09
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 24, 2026
aray12
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Splits
/anonymizer/:anonymizerJobNameoff the builder so it renders a job-detail placeholder instead of the create form (ASTD-331).Part of ASTD-215.
Why
/newand/:nameboth routed toAnonymizerBuilderRoute, so clicking a job in the list (and the post-create redirect) landed on the create form.Changes
AnonymizerJobDetailRoute— placeholder showing the job name + breadcrumbs ("Job details coming soon")ROUTES.workspace.anonymizerJobnow points at it ingroups/anonymizerRoutes.tsx;/newkeeps the builderFull detail page (status, results, Replacement Map, download, actions) is ASTD-330.
Testing
@nemo/studiotsc --noEmit— no new errors; eslint clean.VITE_FF_ANONYMIZER_ENABLED(default false).Summary by CodeRabbit