feat(studio): Anonymizer jobs list page [ASTD-325] by marcusds · Pull Request #881 · NVIDIA-NeMo/nemo-platform

marcusds · 2026-07-23T23:14:01Z

Rebased onto main — #876 (routes/flag scaffold) and #879 (jobs API + web SDK) are both merged. This PR is now standalone: the diff is only the four list-page files.

What

Builds the Anonymizer jobs list page (ASTD-325), replacing the placeholder from #876 with a real jobs DataView on the SDK from #879.

Part of ASTD-215.

List-page changes (the reviewable diff)

components/dataViews/AnonymizerJobsDataView/ — mirrors DataDesignerJobsDataView:
- paginated list via useAnonymizerListRunJobs (polls on JOB_POLLING_INTERVAL_MS)
- columns: name, description, created (RelativeTime), status (StatusBadge), updated (hidden)
- status single-select + created/updated date-range filters, name search ($like)
- server-side pagination/sort, row → detail (getAnonymizerJobRoute), bulk delete (BulkDeleteModal)
- empty state (first-run CTA + no-results/clear-filters) and loading state
components/AnonymizerJobActionsMenu/ — per-row: View details / Cancel (when cancellable) / Delete
AnonymizerListRoute renders <AnonymizerJobsDataView />

Decisions

Dropped Data Designer's Clone action — it needs a DD-specific request builder, and the anonymizer builder page is still a placeholder (follow-up ticket).
Strategy isn't a column — it lives deep in spec and is optional; can add once the builder/detail views land.

Depends on

feat(studio): scaffold Anonymizer routes, nav, and feature flag [ASTD-215] #876 — routes, feature flag (VITE_FF_ANONYMIZER_ENABLED, default false), nav
feat(anonymizer): expose jobs API via OpenAPI + web SDK [ASTD-326] #879 — anonymizer OpenAPI spec + web SDK (useAnonymizerListRunJobs, RunJob, …)

Testing

@nemo/studio tsc --noEmit — no new errors (16 pre-existing come from an ungenerated customizer SDK, identical on main).
eslint clean on new files. No dataview unit test — matches the existing Data Designer / Safe Synthesizer dataviews (untested by convention).
Gated behind VITE_FF_ANONYMIZER_ENABLED (default false) — no surface exposed by default.

Notes

Pre-push typecheck hook bypassed (Studio's pre-existing customizer-SDK failures, unrelated). This branch's own checks pass.

Summary by CodeRabbit

New Features
- Added an anonymizer jobs data view directly on the anonymizer page (search, filter, server-driven sorting/pagination, and live polling).
- Displays job metadata (including relative timestamps) and status badges with single-select filtering.
- Added per-job actions: view details (when available), cancel (when eligible), and delete.
- Added bulk deletion with selection and confirmation, including partial-failure handling.
Bug Fixes
- Improved cancel/delete error handling and ensured errors are cleared/reset after successful actions.
Documentation
- None

github-actions · 2026-07-24T00:16:02Z

Suite	Lines Covered	Line Rate	Branch Rate
Unit Tests	27158/34869	77.9%	62.1%
Integration Tests	15968/33581	47.5%	20.0%

coderabbitai · 2026-07-24T04:09:19Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e21b942c-37d1-44fc-ab65-a994b6495422

📥 Commits

Reviewing files that changed from the base of the PR and between cd0afba and d64c068.

📒 Files selected for processing (4)

web/packages/studio/src/components/AnonymizerJobActionsMenu/index.tsx
web/packages/studio/src/components/dataViews/AnonymizerJobsDataView/DeleteJobModal.tsx
web/packages/studio/src/components/dataViews/AnonymizerJobsDataView/index.tsx
web/packages/studio/src/routes/AnonymizerListRoute/index.tsx

🚧 Files skipped from review as they are similar to previous changes (4)

web/packages/studio/src/routes/AnonymizerListRoute/index.tsx
web/packages/studio/src/components/dataViews/AnonymizerJobsDataView/DeleteJobModal.tsx
web/packages/studio/src/components/AnonymizerJobActionsMenu/index.tsx
web/packages/studio/src/components/dataViews/AnonymizerJobsDataView/index.tsx

📝 Walkthrough

Walkthrough

Changes

Anonymizer jobs management

Layer / File(s)	Summary
Jobs data view `web/packages/studio/src/components/dataViews/AnonymizerJobsDataView/index.tsx`	Adds a polled, filterable, sortable, paginated jobs table with row actions, cancellation errors, bulk deletion, and empty states.
Job actions `web/packages/studio/src/components/AnonymizerJobActionsMenu/index.tsx`	Adds view-details, conditional cancel, and delete actions with query refresh and error handling.
Deletion and route wiring `web/packages/studio/src/components/dataViews/AnonymizerJobsDataView/DeleteJobModal.tsx`, `web/packages/studio/src/routes/AnonymizerListRoute/index.tsx`	Adds concurrent job deletion and renders the jobs view beneath the anonymizer page header.

Sequence Diagram(s)

sequenceDiagram
  participant AnonymizerListRoute
  participant AnonymizerJobsDataView
  participant AnonymizerJobActionsMenu
  participant DeleteJobModal
  AnonymizerListRoute->>AnonymizerJobsDataView: render jobs table
  AnonymizerJobsDataView->>AnonymizerJobActionsMenu: render row actions
  AnonymizerJobActionsMenu->>DeleteJobModal: open delete modal
  DeleteJobModal-->>AnonymizerJobsDataView: reset jobs query after deletion

Possibly related PRs

NVIDIA-NeMo/nemo-platform#887: Adds and guards the anonymizer job detail route used by view-details navigation.

Suggested reviewers: steramae-nvidia

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: adding the Anonymizer jobs list page in studio.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch astd-325-anonymizer-list-page/mschwab

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 2

🧹 Nitpick comments (1)

web/packages/studio/src/components/dataViews/AnonymizerJobsDataView/index.tsx (1)
34-34: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Use import type for React types.

web/packages/studio/src/components/dataViews/AnonymizerJobsDataView/index.tsx: move ComponentProps and FC to import type.

web/packages/studio/src/components/dataViews/AnonymizerJobsDataView/DeleteJobModal.tsx: change FC to a type-only import.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@web/packages/studio/src/components/dataViews/AnonymizerJobsDataView/index.tsx`
at line 34, Use type-only React imports for the specified symbols: update
web/packages/studio/src/components/dataViews/AnonymizerJobsDataView/index.tsx
lines 34-34 to import ComponentProps and FC with import type, and update
web/packages/studio/src/components/dataViews/AnonymizerJobsDataView/DeleteJobModal.tsx
lines 12-12 to import FC with import type; leave runtime React imports
unchanged.
Source: Coding guidelines

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@web/packages/studio/src/components/dataViews/AnonymizerJobsDataView/DeleteJobModal.tsx`:
- Around line 33-47: Update handleDelete to validate all jobs before invoking
deleteJobMutation, rejecting or reporting any job missing workspace or name
instead of filtering it out. Only proceed with Promise.all and call onDeleted
after every input job passes validation, matching the existing bulk-delete
handler behavior.

In
`@web/packages/studio/src/components/dataViews/AnonymizerJobsDataView/index.tsx`:
- Around line 69-79: Update the bulk deletion flow around jobsToDelete and
deleteJobMutation.mutateAsync so it records each job’s success or failure
instead of relying on Promise.all’s first rejection. Remove successfully deleted
jobs from the selected state, retain failed jobs for retry, and report the
aggregate per-job outcome in the modal; use an atomic bulk endpoint only if one
already exists.

---

Nitpick comments:
In
`@web/packages/studio/src/components/dataViews/AnonymizerJobsDataView/index.tsx`:
- Line 34: Use type-only React imports for the specified symbols: update
web/packages/studio/src/components/dataViews/AnonymizerJobsDataView/index.tsx
lines 34-34 to import ComponentProps and FC with import type, and update
web/packages/studio/src/components/dataViews/AnonymizerJobsDataView/DeleteJobModal.tsx
lines 12-12 to import FC with import type; leave runtime React imports
unchanged.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b1dced1d-358d-4f31-b49b-4ac54da92469

📥 Commits

Reviewing files that changed from the base of the PR and between 8adcee4 and 4457f3e.

📒 Files selected for processing (4)

web/packages/studio/src/components/AnonymizerJobActionsMenu/index.tsx
web/packages/studio/src/components/dataViews/AnonymizerJobsDataView/DeleteJobModal.tsx
web/packages/studio/src/components/dataViews/AnonymizerJobsDataView/index.tsx
web/packages/studio/src/routes/AnonymizerListRoute/index.tsx

marcusds · 2026-07-24T04:31:44Z

Claude says: "Done in cd0afba — FC/ComponentProps now use inline type imports in both files." @coderabbitai

coderabbitai · 2026-07-24T04:31:53Z

Tip

For best results, initiate chat on the files or code changes.

@marcusds Confirmed. The inline type-import fix addresses the finding.

Replace the Anonymizer list placeholder with a jobs DataView mirroring Data Designer: paginated list via useAnonymizerListRunJobs, name / description / created / status columns, status + date filters, search, row -> detail navigation, per-row actions (view/cancel/delete), and bulk delete. Empty and loading states included. - components/dataViews/AnonymizerJobsDataView (+ DeleteJobModal) - components/AnonymizerJobActionsMenu - AnonymizerListRoute renders the DataView Signed-off-by: mschwab <mschwab@nvidia.com>

StudioDataView memoizes column defs keyed on the makeColumns identity, so passing a fresh arrow rebuilt every column on each render of a table that polls on an interval. Wrap it in useCallback. Also drop a useCallback whose only dep was the dataViewState object (a new literal every render, so it never memoized) in favor of the hook's already stable resetFilters, narrow handleCancel's dep to the stable mutateAsync ref, and memoize the per-row actions array. Signed-off-by: mschwab <mschwab@nvidia.com>

github-actions Bot added the feat label Jul 23, 2026

marcusds force-pushed the astd-325-anonymizer-list-page/mschwab branch from 19aa12d to 8d69260 Compare July 24, 2026 00:03

marcusds force-pushed the astd-325-anonymizer-list-page/mschwab branch from 8d69260 to 4457f3e Compare July 24, 2026 04:01

marcusds marked this pull request as ready for review July 24, 2026 04:03

marcusds requested review from a team as code owners July 24, 2026 04:03

marcusds force-pushed the astd-325-anonymizer-list-page/mschwab branch from 4457f3e to 1a57b58 Compare July 24, 2026 04:05

coderabbitai Bot reviewed Jul 24, 2026

View reviewed changes

Comment thread web/packages/studio/src/components/dataViews/AnonymizerJobsDataView/DeleteJobModal.tsx

Comment thread web/packages/studio/src/components/dataViews/AnonymizerJobsDataView/index.tsx Outdated

marcusds force-pushed the astd-325-anonymizer-list-page/mschwab branch from 1a57b58 to cd0afba Compare July 24, 2026 04:27

This was referenced Jul 24, 2026

feat(studio): Anonymizer builder Source form [ASTD-327] #884

Merged

feat(studio): job-detail placeholder route for Anonymizer [ASTD-331] #887

Merged

marcusds enabled auto-merge July 24, 2026 17:28

marcusds added 2 commits July 24, 2026 11:01

marcusds force-pushed the astd-325-anonymizer-list-page/mschwab branch from cd0afba to d64c068 Compare July 24, 2026 18:10

htolentino-nvidia approved these changes Jul 24, 2026

View reviewed changes

marcusds added this pull request to the merge queue Jul 24, 2026

Merged via the queue into main with commit f518e45 Jul 24, 2026
59 of 60 checks passed

marcusds deleted the astd-325-anonymizer-list-page/mschwab branch July 24, 2026 18:51

coderabbitai Bot mentioned this pull request Jul 28, 2026

feat(studio): Anonymizer job detail page [ASTD-330] #962

Merged

Navigation Menu

Uh oh!

feat(studio): Anonymizer jobs list page [ASTD-325] - #881

feat(studio): Anonymizer jobs list page [ASTD-325]#881
marcusds merged 2 commits into
mainfrom
astd-325-anonymizer-list-page/mschwab

marcusds commented Jul 23, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

github-actions Bot commented Jul 24, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jul 24, 2026 •

edited

Loading

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

marcusds commented Jul 24, 2026

Uh oh!

coderabbitai Bot commented Jul 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

marcusds commented Jul 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

List-page changes (the reviewable diff)

Decisions

Depends on

Testing

Notes

Summary by CodeRabbit

Uh oh!

github-actions Bot commented Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jul 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

marcusds commented Jul 24, 2026

Uh oh!

coderabbitai Bot commented Jul 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

marcusds commented Jul 23, 2026 •

edited by coderabbitai Bot

Loading

github-actions Bot commented Jul 24, 2026 •

edited

Loading

coderabbitai Bot commented Jul 24, 2026 •

edited

Loading