feat(studio): Dedicated Agent Details Page - #806
Merged
Conversation
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAgent navigation now opens a dedicated routed detail page with URL-synchronized tabs for evaluations, deployments, logs, and chat. New tab components, deployment log selection control, header actions, modals, side navigation wiring, and route-level tests are included. ChangesAgent detail experience
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (3)
web/packages/studio/src/routes/agents/AgentDetailRoute/index.test.tsx (3)
4-10: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winGroup external imports before internal imports.
Move
@testing-library/user-eventabove the@studio/*imports.As per coding guidelines, follow “Group imports: external libraries, internal modules, relative imports in TypeScript.”
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@web/packages/studio/src/routes/agents/AgentDetailRoute/index.test.tsx` around lines 4 - 10, Reorder the imports in the AgentDetailRoute test so the external `@testing-library/user-event` import appears before all internal `@studio/`* imports, while preserving the existing import statements.Source: Coding guidelines
36-43: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winVerify Chat updates the URL.
This only checks
aria-selected; a regression in the route’s search-parameter synchronization would pass. Assert the memory router’s location contains the expected tab search parameter after clicking Chat.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@web/packages/studio/src/routes/agents/AgentDetailRoute/index.test.tsx` around lines 36 - 43, Update the “switches to the chat tab” test to also inspect the memory router location after clicking the Chat tab, asserting that the URL search parameters contain the expected Chat tab value while preserving the existing aria-selected and textbox assertions.
21-33: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winAssert the default tab’s content.
The test verifies that Overview is selected but not that its panel renders. Add a stable assertion for the Overview content, such as
Overview is coming soon.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@web/packages/studio/src/routes/agents/AgentDetailRoute/index.test.tsx` around lines 21 - 33, Add an assertion in the “renders the agent as a full page with tabs and header actions” test that verifies the selected Overview panel content, using the stable text “Overview is coming soon” while preserving the existing tab and header-action assertions.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@web/packages/studio/src/routes/agents/AgentDetailRoute/index.test.tsx`:
- Around line 4-10: Reorder the imports in the AgentDetailRoute test so the
external `@testing-library/user-event` import appears before all internal
`@studio/`* imports, while preserving the existing import statements.
- Around line 36-43: Update the “switches to the chat tab” test to also inspect
the memory router location after clicking the Chat tab, asserting that the URL
search parameters contain the expected Chat tab value while preserving the
existing aria-selected and textbox assertions.
- Around line 21-33: Add an assertion in the “renders the agent as a full page
with tabs and header actions” test that verifies the selected Overview panel
content, using the stable text “Overview is coming soon” while preserving the
existing tab and header-action assertions.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: af148d44-30c1-4122-a554-cd0a1c189b57
📒 Files selected for processing (10)
web/packages/studio/src/components/sidePanels/AgentPanels/AgentPanel/DeploymentLogsView.tsxweb/packages/studio/src/routes/agents/AgentDetailRoute/ConfigurationTab.tsxweb/packages/studio/src/routes/agents/AgentDetailRoute/DeploymentsTab.tsxweb/packages/studio/src/routes/agents/AgentDetailRoute/EvaluationsTab.tsxweb/packages/studio/src/routes/agents/AgentDetailRoute/TabPlaceholder.tsxweb/packages/studio/src/routes/agents/AgentDetailRoute/index.test.tsxweb/packages/studio/src/routes/agents/AgentDetailRoute/index.tsxweb/packages/studio/src/routes/agents/AgentDetailRoute/overview/DetailPanel.tsxweb/packages/studio/src/routes/agents/AgentsListRoute/index.tsxweb/packages/studio/src/routes/groups/agentRoutes.tsx
Contributor
|
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
web/packages/studio/src/components/sidePanels/AgentPanels/AgentPanel/DeploymentLogsView.tsx (1)
72-77: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueRename the constant to
P_OFFSET.As per coding guidelines, “Use
SCREAMING_SNAKE_CASEfor constants and environment variables.”🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@web/packages/studio/src/components/sidePanels/AgentPanels/AgentPanel/DeploymentLogsView.tsx` around lines 72 - 77, Rename the module-level constant pOffset to P_OFFSET and update its usage in the Stack/Block rendering within DeploymentLogsView. Preserve the existing value and behavior.Source: Coding guidelines
web/packages/studio/src/routes/agents/AgentDetailRoute/index.tsx (1)
18-33: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueRestore external-before-internal import grouping.
web/packages/studio/src/routes/agents/AgentDetailRoute/index.tsx#L18-L33: movelucide-reactandreactimports before@studio/*imports.web/packages/studio/src/routes/agents/AgentDetailRoute/index.test.tsx#L4-L9: move@testing-library/user-eventbefore@studio/*imports.As per coding guidelines, “Group imports: external libraries, internal modules, relative imports in TypeScript.”
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@web/packages/studio/src/routes/agents/AgentDetailRoute/index.tsx` around lines 18 - 33, Restore import grouping in AgentDetailRoute/index.tsx by placing the lucide-react and react imports before all `@studio/`* internal imports. In AgentDetailRoute/index.test.tsx, move the `@testing-library/user-event` import before the `@studio/`* imports, preserving the external, internal, and relative ordering.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web/packages/studio/src/routes/agents/AgentDetailRoute/index.tsx`:
- Line 50: After deployment loading completes in AgentDetailRoute, validate
logsDeploymentName against agentDeployments and clear it with
setLogsDeploymentName when the selected deployment no longer exists. Preserve
the selection while it remains present and ensure the reset occurs only after
refreshed deployments are available.
---
Nitpick comments:
In
`@web/packages/studio/src/components/sidePanels/AgentPanels/AgentPanel/DeploymentLogsView.tsx`:
- Around line 72-77: Rename the module-level constant pOffset to P_OFFSET and
update its usage in the Stack/Block rendering within DeploymentLogsView.
Preserve the existing value and behavior.
In `@web/packages/studio/src/routes/agents/AgentDetailRoute/index.tsx`:
- Around line 18-33: Restore import grouping in AgentDetailRoute/index.tsx by
placing the lucide-react and react imports before all `@studio/`* internal
imports. In AgentDetailRoute/index.test.tsx, move the
`@testing-library/user-event` import before the `@studio/`* imports, preserving the
external, internal, and relative ordering.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 07aec955-6e37-4175-94b5-9f33e19c780f
📒 Files selected for processing (4)
web/packages/studio/src/components/sidePanels/AgentPanels/AgentPanel/DeploymentLogsView.tsxweb/packages/studio/src/routes/agents/AgentDetailRoute/DeploymentsTab.tsxweb/packages/studio/src/routes/agents/AgentDetailRoute/index.test.tsxweb/packages/studio/src/routes/agents/AgentDetailRoute/index.tsx
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 21, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 21, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 21, 2026
Signed-off-by: Sean Teramae <steramae@nvidia.com>
Signed-off-by: Sean Teramae <steramae@nvidia.com>
Signed-off-by: Sean Teramae <steramae@nvidia.com>
Signed-off-by: Sean Teramae <steramae@nvidia.com>
Signed-off-by: Sean Teramae <steramae@nvidia.com>
steramae-nvidia
force-pushed
the
steramae/agent-details-page
branch
from
July 21, 2026 22:31
ec31245 to
1c892e4
Compare
soluwalana
pushed a commit
that referenced
this pull request
Jul 22, 2026
* feat(studio): Dedicated Agent Details Page Signed-off-by: Sean Teramae <steramae@nvidia.com> * fix agent suggestions route Signed-off-by: Sean Teramae <steramae@nvidia.com> * Remove unused tabs Signed-off-by: Sean Teramae <steramae@nvidia.com> * fix overflow Signed-off-by: Sean Teramae <steramae@nvidia.com> * fix type error Signed-off-by: Sean Teramae <steramae@nvidia.com> --------- Signed-off-by: Sean Teramae <steramae@nvidia.com> Signed-off-by: Sam Oluwalana <soluwalana@nvidia.com>
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sean Teramae steramae@nvidia.com
Summary by CodeRabbit