Skip to content

feat(studio): Add Agent Details tab - #880

Merged
steramae-nvidia merged 3 commits into
mainfrom
agent-config-details-tab/steramae
Jul 24, 2026
Merged

feat(studio): Add Agent Details tab#880
steramae-nvidia merged 3 commits into
mainfrom
agent-config-details-tab/steramae

Conversation

@steramae-nvidia

@steramae-nvidia steramae-nvidia commented Jul 23, 2026

Copy link
Copy Markdown
Contributor
Screenshot 2026-07-23 at 4 05 34 PM Screenshot 2026-07-23 at 4 03 19 PM Screenshot 2026-07-23 at 4 03 24 PM

Summary by CodeRabbit

  • New Features
    • Added a Details tab to agent pages.
    • Displays agent Overview, Workflow, Models, Tools, timestamps, and Additional configuration (including nested values).
    • Sensitive configuration values are automatically masked; non-sensitive token/limit fields display unmasked token counts.
  • Bug Fixes
    • Improved configuration label humanization using common acronym normalization.
    • Better rendering for empty, null, boolean, scalar arrays, and nested objects.
  • Tests
    • Added coverage for label humanization, recursive config rendering, and masking behavior.

Signed-off-by: Sean Teramae <steramae@nvidia.com>
@steramae-nvidia
steramae-nvidia requested review from a team as code owners July 23, 2026 23:04
@github-actions github-actions Bot added the feat label Jul 23, 2026
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a4a8fcd2-1cc8-4bb4-8622-49fc36decebb

📥 Commits

Reviewing files that changed from the base of the PR and between 7931240 and c0e1a06.

📒 Files selected for processing (2)
  • web/packages/studio/src/routes/agents/AgentDetailRoute/ConfigValue.test.tsx
  • web/packages/studio/src/routes/agents/AgentDetailRoute/ConfigValue.tsx
🚧 Files skipped from review as they are similar to previous changes (2)
  • web/packages/studio/src/routes/agents/AgentDetailRoute/ConfigValue.tsx
  • web/packages/studio/src/routes/agents/AgentDetailRoute/ConfigValue.test.tsx

📝 Walkthrough

Walkthrough

Adds a Details tab to the agent detail route with structured configuration panels, recursive value rendering, humanized labels, sensitive-value masking, and coverage for the new UI behavior.

Changes

Agent details configuration

Layer / File(s) Summary
Configuration value rendering
web/packages/studio/src/routes/agents/AgentDetailRoute/configFormat.ts, web/packages/studio/src/routes/agents/AgentDetailRoute/ConfigValue.tsx, web/packages/studio/src/routes/agents/AgentDetailRoute/ConfigValue.test.tsx
Formats configuration labels, masks sensitive values, renders scalar and nested values, and tests these behaviors.
Details tab content
web/packages/studio/src/routes/agents/AgentDetailRoute/DetailsTab.tsx
Renders overview, workflow, models, tools, and additional configuration panels, with a fallback for agents without stored configuration.
Agent detail route integration
web/packages/studio/src/routes/agents/AgentDetailRoute/index.tsx, web/packages/studio/src/routes/agents/AgentDetailRoute/index.test.tsx
Adds the Details tab, wires agent data into DetailsTab, and tests panel contents and secret masking.

Sequence Diagram(s)

sequenceDiagram
  participant AgentDetailRoute
  participant DetailsTab
  participant ConfigValue
  AgentDetailRoute->>DetailsTab: Pass agent details
  DetailsTab->>ConfigValue: Render additional configuration
  ConfigValue-->>DetailsTab: Return formatted and masked rows
  DetailsTab-->>AgentDetailRoute: Display Details panels
Loading

Suggested labels: feat

Suggested reviewers: aray12

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Title accurately summarizes the main change: adding an Agent Details tab to Studio.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent-config-details-tab/steramae

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@web/packages/studio/src/routes/agents/AgentDetailRoute/ConfigValue.tsx`:
- Around line 25-26: Update isSensitiveKey to normalize key naming consistently
before applying the NON_SENSITIVE_KEYS allowlist and SENSITIVE_KEY pattern,
ensuring camelCase keys such as maxTokens match their snake_case allowlist entry
and remain visible while other sensitive keys are still masked.
- Line 7: Update the type-only import in ConfigValue.tsx to include ReactNode
alongside FC, and use the imported ReactNode type instead of the unbound
React.ReactNode reference.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 790a0cde-035c-4a19-99bb-301c3bcc881c

📥 Commits

Reviewing files that changed from the base of the PR and between 565a815 and 7931240.

📒 Files selected for processing (7)
  • web/packages/studio/src/routes/agents/AgentDetailRoute/ConfigValue.test.tsx
  • web/packages/studio/src/routes/agents/AgentDetailRoute/ConfigValue.tsx
  • web/packages/studio/src/routes/agents/AgentDetailRoute/ConfigurationTab.tsx
  • web/packages/studio/src/routes/agents/AgentDetailRoute/DetailsTab.tsx
  • web/packages/studio/src/routes/agents/AgentDetailRoute/configFormat.ts
  • web/packages/studio/src/routes/agents/AgentDetailRoute/index.test.tsx
  • web/packages/studio/src/routes/agents/AgentDetailRoute/index.tsx
💤 Files with no reviewable changes (1)
  • web/packages/studio/src/routes/agents/AgentDetailRoute/ConfigurationTab.tsx

Comment thread web/packages/studio/src/routes/agents/AgentDetailRoute/ConfigValue.tsx Outdated
Comment thread web/packages/studio/src/routes/agents/AgentDetailRoute/ConfigValue.tsx Outdated
Signed-off-by: Sean Teramae <steramae@nvidia.com>
@github-actions

github-actions Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 27163/34869 77.9% 62.1%
Integration Tests 15969/33581 47.5% 20.0%

Signed-off-by: Sean Teramae <steramae@nvidia.com>
@steramae-nvidia
steramae-nvidia added this pull request to the merge queue Jul 24, 2026
Merged via the queue into main with commit 9b3a8dc Jul 24, 2026
58 checks passed
@steramae-nvidia
steramae-nvidia deleted the agent-config-details-tab/steramae branch July 24, 2026 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants