feat(studio): Add Agent Details tab - #880
Conversation
Signed-off-by: Sean Teramae <steramae@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughAdds a Details tab to the agent detail route with structured configuration panels, recursive value rendering, humanized labels, sensitive-value masking, and coverage for the new UI behavior. ChangesAgent details configuration
Sequence Diagram(s)sequenceDiagram
participant AgentDetailRoute
participant DetailsTab
participant ConfigValue
AgentDetailRoute->>DetailsTab: Pass agent details
DetailsTab->>ConfigValue: Render additional configuration
ConfigValue-->>DetailsTab: Return formatted and masked rows
DetailsTab-->>AgentDetailRoute: Display Details panels
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web/packages/studio/src/routes/agents/AgentDetailRoute/ConfigValue.tsx`:
- Around line 25-26: Update isSensitiveKey to normalize key naming consistently
before applying the NON_SENSITIVE_KEYS allowlist and SENSITIVE_KEY pattern,
ensuring camelCase keys such as maxTokens match their snake_case allowlist entry
and remain visible while other sensitive keys are still masked.
- Line 7: Update the type-only import in ConfigValue.tsx to include ReactNode
alongside FC, and use the imported ReactNode type instead of the unbound
React.ReactNode reference.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 790a0cde-035c-4a19-99bb-301c3bcc881c
📒 Files selected for processing (7)
web/packages/studio/src/routes/agents/AgentDetailRoute/ConfigValue.test.tsxweb/packages/studio/src/routes/agents/AgentDetailRoute/ConfigValue.tsxweb/packages/studio/src/routes/agents/AgentDetailRoute/ConfigurationTab.tsxweb/packages/studio/src/routes/agents/AgentDetailRoute/DetailsTab.tsxweb/packages/studio/src/routes/agents/AgentDetailRoute/configFormat.tsweb/packages/studio/src/routes/agents/AgentDetailRoute/index.test.tsxweb/packages/studio/src/routes/agents/AgentDetailRoute/index.tsx
💤 Files with no reviewable changes (1)
- web/packages/studio/src/routes/agents/AgentDetailRoute/ConfigurationTab.tsx
Signed-off-by: Sean Teramae <steramae@nvidia.com>
|
Signed-off-by: Sean Teramae <steramae@nvidia.com>
Summary by CodeRabbit