Skip to content

feat(studio): Use LogViewer on Customizer Job Details #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
htolentino-nvidia merged 3 commits into from
Jul 22, 2026
Merged

feat(studio): Use LogViewer on Customizer Job Details #728

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b460df2
Use LogViewer on Customizer Job Details
htolentino-nvidia Jul 16, 2026
74160e7
Add a loading check
htolentino-nvidia Jul 16, 2026
75ef67f
Merge branch 'main' into studio-update-customizer-logs/htolentino
htolentino-nvidia Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 8 additions & 27 deletions web/packages/studio/src/components/CustomizationDetailsPanel/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,25 +2,16 @@
// SPDX-License-Identifier: Apache-2.0

import { KVPair } from '@nemo/common/src/components/KVPair';
import { LogViewer } from '@nemo/common/src/components/LogViewer';
import { PanelFooterAccordion } from '@nemo/common/src/components/PanelFooterAccordion';
import { formatAbsoluteTimestamp } from '@nemo/common/src/components/RelativeTime/util';
import { StatusBadge } from '@nemo/common/src/components/StatusBadge';
import { CJobTerminalStatuses } from '@nemo/common/src/constants/query';
import { useJobLogs } from '@nemo/common/src/hooks/useJobLogs';
import { useLiveSeconds } from '@nemo/common/src/hooks/useLiveSeconds';
import { useToast } from '@nemo/common/src/providers/toast/useToast';
import { formatTimeInSeconds, utcToLocalDate } from '@nemo/common/src/utils/date';
import { formatLogs } from '@nemo/common/src/utils/logs';
import { getJobRefetchInterval } from '@nemo/common/src/utils/query';
import {
Button,
CodeSnippet,
Flex,
Grid,
Panel,
Stack,
Text,
} from '@nvidia/foundations-react-core';
import { Button, Flex, Grid, Panel, Stack, Text } from '@nvidia/foundations-react-core';
import { TrainValidationLossLineChart } from '@studio/components/charts/TrainValidationLossLineChart';
import { ErrorMessageWithRetry } from '@studio/components/ErrorMessageWithRetry';
import { Loading } from '@studio/components/Layouts/Loading';
Expand All @@ -44,7 +35,6 @@ type Props = {
workspace?: string;
};
export const CustomizationDetailsPanel: FC<Props> = ({ customizationJobName, workspace = '' }) => {
const toast = useToast();
const [openConfigSidePanel, setOpenConfigSidePanel] = useState(false);
const {
job: customization,
Expand All @@ -55,7 +45,7 @@ export const CustomizationDetailsPanel: FC<Props> = ({ customizationJobName, wor
refetchInterval: (query) => getJobRefetchInterval(query.state.data?.status),
});

const { data: logs } = useJobLogs({
const { data: logs, isLoading: isLogsLoading } = useJobLogs({
workspace,
name: customizationJobName,
enabled: !!customization,
Expand Down Expand Up @@ -164,11 +154,6 @@ export const CustomizationDetailsPanel: FC<Props> = ({ customizationJobName, wor
);
}

// Fallback to status details if logs are not available
const codeSnippet = logs?.length
? formatLogs(logs)
: (JSON.stringify(customization?.status_details?.events, null, 2) ?? '');

return (
<Panel
elevation="high"
Expand All @@ -190,15 +175,11 @@ export const CustomizationDetailsPanel: FC<Props> = ({ customizationJobName, wor
</Flex>
}
slotContent={
<Flex className="h-full">
<CodeSnippet
className="h-full w-full"
value={codeSnippet}
language="shell"
kind="block"
onCopySuccess={() => toast.success('Logs copied to clipboard')}
/>
</Flex>
<LogViewer
logs={logs ?? []}
isLoading={isLogsLoading}
downloadFilename={`${customizationJobName}.log`}
/>
}
/>
}
Expand Down