feat(studio): Use LogViewer on Customizer Job Details - #728
Merged
htolentino-nvidia merged 3 commits intoJul 22, 2026
Conversation
Signed-off-by: Henrique Tolentino <htolentino@nvidia.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughChangesStatus logs display
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web/packages/studio/src/components/CustomizationDetailsPanel/index.tsx`:
- Line 178: Update the LogViewer invocation in CustomizationDetailsPanel to pass
the existing loading state as its isLoading prop, while retaining logs ?? [] for
the logs value. Ensure the footer displays the loading spinner during the
initial fetch instead of the empty state.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: f238e5e8-0a4b-420e-863d-14e7378509ce
📒 Files selected for processing (1)
web/packages/studio/src/components/CustomizationDetailsPanel/index.tsx
Contributor
|
Signed-off-by: Henrique Tolentino <htolentino@nvidia.com>
steramae-nvidia
approved these changes
Jul 16, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 22, 2026
htolentino-nvidia
removed this pull request from the merge queue due to a manual request
Jul 22, 2026
htolentino-nvidia
enabled auto-merge
July 22, 2026 14:13
soluwalana
pushed a commit
that referenced
this pull request
Jul 22, 2026
* Use LogViewer on Customizer Job Details Signed-off-by: Henrique Tolentino <htolentino@nvidia.com> * Add a loading check Signed-off-by: Henrique Tolentino <htolentino@nvidia.com> --------- Signed-off-by: Henrique Tolentino <htolentino@nvidia.com> Signed-off-by: Sam Oluwalana <soluwalana@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
.logextension).