Skip to content

feat(studio): Use LogViewer on Customizer Job Details - #728

Merged
htolentino-nvidia merged 3 commits into
mainfrom
studio-update-customizer-logs/htolentino
Jul 22, 2026
Merged

feat(studio): Use LogViewer on Customizer Job Details#728
htolentino-nvidia merged 3 commits into
mainfrom
studio-update-customizer-logs/htolentino

Conversation

@htolentino-nvidia

@htolentino-nvidia htolentino-nvidia commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features
    • Replaced the status log text view with a dedicated log viewer UI.
    • Added log download support for customization jobs, using a descriptive filename (e.g., job name with a .log extension).
  • Improvements
    • Status logs now render consistently and handle the loading state while showing an empty view when no log entries are available.

Signed-off-by: Henrique Tolentino <htolentino@nvidia.com>
@htolentino-nvidia
htolentino-nvidia requested review from a team as code owners July 16, 2026 17:20
@github-actions github-actions Bot added the feat label Jul 16, 2026
@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2c0d95a0-20c8-4111-81af-2c56e31b3b94

📥 Commits

Reviewing files that changed from the base of the PR and between b460df2 and 74160e7.

📒 Files selected for processing (1)
  • web/packages/studio/src/components/CustomizationDetailsPanel/index.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • web/packages/studio/src/components/CustomizationDetailsPanel/index.tsx

📝 Walkthrough

Walkthrough

Changes

Status logs display

Layer / File(s) Summary
Replace status log rendering
web/packages/studio/src/components/CustomizationDetailsPanel/index.tsx
Replaces the code snippet and copy toast with LogViewer, passing job logs, loading state, and ${customizationJobName}.log as the download filename. Removes fallback event serialization and unused imports.

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: replacing the customizer job details log display with LogViewer.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch studio-update-customizer-logs/htolentino

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@web/packages/studio/src/components/CustomizationDetailsPanel/index.tsx`:
- Line 178: Update the LogViewer invocation in CustomizationDetailsPanel to pass
the existing loading state as its isLoading prop, while retaining logs ?? [] for
the logs value. Ensure the footer displays the loading spinner during the
initial fetch instead of the empty state.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: f238e5e8-0a4b-420e-863d-14e7378509ce

📥 Commits

Reviewing files that changed from the base of the PR and between 87c8dfb and b460df2.

📒 Files selected for processing (1)
  • web/packages/studio/src/components/CustomizationDetailsPanel/index.tsx

Comment thread web/packages/studio/src/components/CustomizationDetailsPanel/index.tsx Outdated
@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 27113/34832 77.8% 62.1%
Integration Tests 15891/33443 47.5% 19.9%

Signed-off-by: Henrique Tolentino <htolentino@nvidia.com>
@htolentino-nvidia
htolentino-nvidia added this pull request to the merge queue Jul 22, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 22, 2026
@htolentino-nvidia
htolentino-nvidia added this pull request to the merge queue Jul 22, 2026
@htolentino-nvidia
htolentino-nvidia removed this pull request from the merge queue due to a manual request Jul 22, 2026
@htolentino-nvidia
htolentino-nvidia added this pull request to the merge queue Jul 22, 2026
Merged via the queue into main with commit be2efe8 Jul 22, 2026
58 checks passed
@htolentino-nvidia
htolentino-nvidia deleted the studio-update-customizer-logs/htolentino branch July 22, 2026 14:46
soluwalana pushed a commit that referenced this pull request Jul 22, 2026
* Use LogViewer on Customizer Job Details

Signed-off-by: Henrique Tolentino <htolentino@nvidia.com>

* Add a loading check

Signed-off-by: Henrique Tolentino <htolentino@nvidia.com>

---------

Signed-off-by: Henrique Tolentino <htolentino@nvidia.com>
Signed-off-by: Sam Oluwalana <soluwalana@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants