feat(studio): Support seeding DD - #685
Conversation
|
This change is part of the following stack:
Change managed by git-spice. |
6bafee5 to
8057b7b
Compare
b9acf23 to
7de3df8
Compare
8057b7b to
cc20eba
Compare
7de3df8 to
d1b3282
Compare
cc20eba to
0f94702
Compare
d1b3282 to
a3512f5
Compare
0f94702 to
04570fd
Compare
Signed-off-by: Sean Teramae <steramae@nvidia.com>
a3512f5 to
5682ada
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughChangesSeed dataset support
Sequence Diagram(s)sequenceDiagram
participant User
participant BuilderPalette
participant AddColumnPalette
participant ColumnTypeCard
participant useJobBuilder
User->>BuilderPalette: Open column palette
BuilderPalette->>AddColumnPalette: Pass disabledColumnReasons
AddColumnPalette->>ColumnTypeCard: Pass disabledReason
User->>ColumnTypeCard: Activate seed-dataset option
ColumnTypeCard->>useJobBuilder: Request column addition
useJobBuilder-->>ColumnTypeCard: Reject second seed-dataset column
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
web/packages/studio/src/components/SafeSynthesizerFilesetPreview/util.ts (1)
7-7: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winDeclare the parser result contract.
parseCSVTableis a public API consumed bygetContentColumns; give it a co-located result interface and explicit return type.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@web/packages/studio/src/components/SafeSynthesizerFilesetPreview/util.ts` at line 7, Define a co-located interface describing the result returned by parseCSVTable, and annotate parseCSVTable with that explicit return type. Ensure the contract matches the shape consumed by getContentColumns.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web/packages/studio/src/components/ColumnConfigPanel/SeedDatasetConfig.tsx`:
- Around line 125-130: Update the onValueChange handler for the Seed file Select
to clear SEED_AVAILABLE_COLUMNS_KEY whenever the selected file changes, while
still storing the new SEED_FILE_PATH_KEY value. Ensure downstream graph tags and
dependencies cannot reuse columns from the previously selected file during
loading or after a schema error.
In `@web/packages/studio/src/components/common/SelectableCard/index.tsx`:
- Around line 69-84: Update the SelectableCard button to use native
disabled={disabled}, removing disabled cards from keyboard tab order while
preserving the existing click, aria, title, and styling behavior.
---
Nitpick comments:
In `@web/packages/studio/src/components/SafeSynthesizerFilesetPreview/util.ts`:
- Line 7: Define a co-located interface describing the result returned by
parseCSVTable, and annotate parseCSVTable with that explicit return type. Ensure
the contract matches the shape consumed by getContentColumns.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 9110cdd1-8f0f-4e26-ba67-5f8073dd2254
📒 Files selected for processing (15)
web/packages/studio/src/components/AddColumnPalette/ColumnTypeCard.tsxweb/packages/studio/src/components/AddColumnPalette/ColumnTypeGroupSection.tsxweb/packages/studio/src/components/AddColumnPalette/index.tsxweb/packages/studio/src/components/ColumnConfigPanel/SeedDatasetConfig.tsxweb/packages/studio/src/components/ColumnConfigPanel/index.tsxweb/packages/studio/src/components/SafeSynthesizerFilesetPreview/util.test.tsweb/packages/studio/src/components/SafeSynthesizerFilesetPreview/util.tsweb/packages/studio/src/components/common/SelectableCard/index.tsxweb/packages/studio/src/routes/DataDesignerJobBuildRoute/BuilderPalette.tsxweb/packages/studio/src/routes/DataDesignerJobBuildRoute/columns.test.tsweb/packages/studio/src/routes/DataDesignerJobBuildRoute/columns.tsweb/packages/studio/src/routes/DataDesignerJobBuildRoute/index.tsxweb/packages/studio/src/routes/DataDesignerJobBuildRoute/useJobBuilder.tsweb/packages/studio/src/util/files.test.tsweb/packages/studio/src/util/files.ts
|
Signed-off-by: Sean Teramae <steramae@nvidia.com>
Signed-off-by: Sean Teramae steramae@nvidia.com
Summary by CodeRabbit