Skip to content

feat(studio): More templates and visual fixes - #647

Merged
steramae-nvidia merged 3 commits into
mainfrom
steramae/template-fixes
Jul 14, 2026
Merged

feat(studio): More templates and visual fixes#647
steramae-nvidia merged 3 commits into
mainfrom
steramae/template-fixes

Conversation

@steramae-nvidia

@steramae-nvidia steramae-nvidia commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Add templates
Screenshot 2026-07-13 at 4 04 08 PM

Signed-off-by: Sean Teramae steramae@nvidia.com

Summary by CodeRabbit

  • New Features

    • Added new fileset templates (code generation/validation, structured data extraction, reward modeling, semantic search, and expression transforms).
    • Added validator parameter configuration with JSON guidance.
    • Improved Data Designer job building by incorporating served model names and applying default inference settings when generating model configs.
  • UI Improvements

    • Updated template selection to use a grid layout for better responsiveness.
    • Enhanced template cards by clipping overflow, improving description sizing, and truncating long descriptions with hover/title support.

@steramae-nvidia
steramae-nvidia requested review from a team as code owners July 10, 2026 23:49
@steramae-nvidia steramae-nvidia changed the title more fixes feat(studio): More templates and visual fixes Jul 10, 2026
@github-actions github-actions Bot added the feat label Jul 10, 2026
@steramae-nvidia
steramae-nvidia force-pushed the steramae/column-fields branch from 798927a to 32c9b12 Compare July 13, 2026 16:43
@steramae-nvidia
steramae-nvidia force-pushed the steramae/template-fixes branch from d515e74 to 2439638 Compare July 13, 2026 16:44
@steramae-nvidia
steramae-nvidia force-pushed the steramae/column-fields branch from 32c9b12 to a6e15e5 Compare July 14, 2026 19:45
@steramae-nvidia
steramae-nvidia force-pushed the steramae/template-fixes branch from 2439638 to bfe5fce Compare July 14, 2026 19:45
@steramae-nvidia
steramae-nvidia force-pushed the steramae/column-fields branch from a6e15e5 to 9d9fb75 Compare July 14, 2026 21:25
@steramae-nvidia
steramae-nvidia force-pushed the steramae/template-fixes branch from bfe5fce to 452fdd8 Compare July 14, 2026 21:25
Base automatically changed from steramae/column-fields to main July 14, 2026 22:22
Signed-off-by: Sean Teramae <steramae@nvidia.com>
Signed-off-by: Sean Teramae <steramae@nvidia.com>
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 28529d19-98fd-4f3e-b80f-6a35c1545584

📥 Commits

Reviewing files that changed from the base of the PR and between d0fdb0b and 3fcbb64.

📒 Files selected for processing (1)
  • web/packages/studio/src/routes/DataDesignerJobBuildRoute/models.test.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • web/packages/studio/src/routes/DataDesignerJobBuildRoute/models.test.ts

📝 Walkthrough

Walkthrough

Template selection gains grid layout, card description truncation, and five additional fileset templates. Data Designer configuration accepts validator parameters, resolves served model names, and emits default chat-completion inference parameters.

Changes

Fileset templates and Data Designer configuration

Layer / File(s) Summary
Template picker layout and truncation
web/packages/studio/src/components/CreateFilesetStart/StartOptionDetail.tsx, web/packages/studio/src/components/CreateFilesetStart/TemplateCard.tsx
Template cards use a grid layout, clip overflow, and truncate descriptions to three lines with a title attribute.
Template definitions and validator parameters
web/packages/studio/src/components/CreateFilesetStart/templates.ts, web/packages/studio/src/routes/DataDesignerJobBuildRoute/columns.ts
Adds templates for code generation, structured extraction, reward modeling, semantic search, and expression transforms; validation columns accept JSON validator_params.
Served-model mapping and inference config
web/packages/studio/src/routes/DataDesignerJobBuildRoute/models.ts, web/packages/studio/src/routes/DataDesignerJobBuildRoute/models.test.ts
Maps model entity IDs to served names, falls back to URNs when unmapped, emits default inference parameters, and tests the updated behavior.
Provider discovery and job configuration wiring
web/packages/studio/src/routes/DataDesignerJobBuildRoute/index.tsx, web/packages/studio/src/routes/DataDesignerJobBuildRoute/columns.ts
Fetches provider data and passes served-model mappings into preview and job-creation configuration generation.

Sequence Diagram(s)

sequenceDiagram
  participant DataDesignerJobBuildRoute
  participant ModelsAPI
  participant ConfigBuilder
  participant JobAPI
  DataDesignerJobBuildRoute->>ModelsAPI: Fetch model providers
  ModelsAPI-->>DataDesignerJobBuildRoute: Return provider mappings
  DataDesignerJobBuildRoute->>ConfigBuilder: Build config with served model names
  ConfigBuilder-->>DataDesignerJobBuildRoute: Return current config
  DataDesignerJobBuildRoute->>JobAPI: Create job with spec.config
Loading

Possibly related PRs

Suggested labels: feat

Suggested reviewers: marcusds

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: new Studio templates plus UI polish.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch steramae/template-fixes

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@web/packages/studio/src/routes/DataDesignerJobBuildRoute/index.tsx`:
- Around line 81-90: Update the submit and preview action flow in
DataDesignerJobBuildRoute to remain unavailable until useModelsListProviders has
finished loading and servedModelNames is populated. Use the provider query’s
loading/readiness state to gate both actions, while preserving the existing
model-name serialization once provider data is ready.

In `@web/packages/studio/src/routes/DataDesignerJobBuildRoute/models.test.ts`:
- Around line 220-232: The test expectation in “omits empty optional fields but
always includes inference parameters with defaults” incorrectly places provider
inside inference_parameters. Update the expected model configuration to match
toModelConfig’s reachable shape: keep provider at its actual top-level location
or omit it according to the intended empty-field behavior, while retaining only
generation_type, max_tokens, temperature, and top_p within inference_parameters.

In `@web/packages/studio/src/routes/DataDesignerJobBuildRoute/models.ts`:
- Around line 158-175: Update toModelConfig so provider is only assigned when
model.provider.trim() is non-empty; remove it from the initial config object and
conditionally add the trimmed value afterward. Preserve the existing alias,
model, and inference parameter mappings.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9dfd125f-0134-4acb-8d3f-feca8dbfdd8b

📥 Commits

Reviewing files that changed from the base of the PR and between da42d40 and d0fdb0b.

📒 Files selected for processing (7)
  • web/packages/studio/src/components/CreateFilesetStart/StartOptionDetail.tsx
  • web/packages/studio/src/components/CreateFilesetStart/TemplateCard.tsx
  • web/packages/studio/src/components/CreateFilesetStart/templates.ts
  • web/packages/studio/src/routes/DataDesignerJobBuildRoute/columns.ts
  • web/packages/studio/src/routes/DataDesignerJobBuildRoute/index.tsx
  • web/packages/studio/src/routes/DataDesignerJobBuildRoute/models.test.ts
  • web/packages/studio/src/routes/DataDesignerJobBuildRoute/models.ts

Comment thread web/packages/studio/src/routes/DataDesignerJobBuildRoute/index.tsx
Comment thread web/packages/studio/src/routes/DataDesignerJobBuildRoute/models.ts
@github-actions

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 24398/31577 77.3% 62.0%
Integration Tests 14023/30226 46.4% 19.3%

@steramae-nvidia
steramae-nvidia disabled auto-merge July 14, 2026 23:02
Signed-off-by: Sean Teramae <steramae@nvidia.com>
@steramae-nvidia
steramae-nvidia added this pull request to the merge queue Jul 14, 2026
Merged via the queue into main with commit d3ddfa3 Jul 14, 2026
57 checks passed
@steramae-nvidia
steramae-nvidia deleted the steramae/template-fixes branch July 14, 2026 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants