feat(studio): More templates and visual fixes - #647
Conversation
|
This change is part of the following stack:
Change managed by git-spice. |
798927a to
32c9b12
Compare
d515e74 to
2439638
Compare
32c9b12 to
a6e15e5
Compare
2439638 to
bfe5fce
Compare
a6e15e5 to
9d9fb75
Compare
bfe5fce to
452fdd8
Compare
Signed-off-by: Sean Teramae <steramae@nvidia.com>
Signed-off-by: Sean Teramae <steramae@nvidia.com>
452fdd8 to
d0fdb0b
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughTemplate selection gains grid layout, card description truncation, and five additional fileset templates. Data Designer configuration accepts validator parameters, resolves served model names, and emits default chat-completion inference parameters. ChangesFileset templates and Data Designer configuration
Sequence Diagram(s)sequenceDiagram
participant DataDesignerJobBuildRoute
participant ModelsAPI
participant ConfigBuilder
participant JobAPI
DataDesignerJobBuildRoute->>ModelsAPI: Fetch model providers
ModelsAPI-->>DataDesignerJobBuildRoute: Return provider mappings
DataDesignerJobBuildRoute->>ConfigBuilder: Build config with served model names
ConfigBuilder-->>DataDesignerJobBuildRoute: Return current config
DataDesignerJobBuildRoute->>JobAPI: Create job with spec.config
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web/packages/studio/src/routes/DataDesignerJobBuildRoute/index.tsx`:
- Around line 81-90: Update the submit and preview action flow in
DataDesignerJobBuildRoute to remain unavailable until useModelsListProviders has
finished loading and servedModelNames is populated. Use the provider query’s
loading/readiness state to gate both actions, while preserving the existing
model-name serialization once provider data is ready.
In `@web/packages/studio/src/routes/DataDesignerJobBuildRoute/models.test.ts`:
- Around line 220-232: The test expectation in “omits empty optional fields but
always includes inference parameters with defaults” incorrectly places provider
inside inference_parameters. Update the expected model configuration to match
toModelConfig’s reachable shape: keep provider at its actual top-level location
or omit it according to the intended empty-field behavior, while retaining only
generation_type, max_tokens, temperature, and top_p within inference_parameters.
In `@web/packages/studio/src/routes/DataDesignerJobBuildRoute/models.ts`:
- Around line 158-175: Update toModelConfig so provider is only assigned when
model.provider.trim() is non-empty; remove it from the initial config object and
conditionally add the trimmed value afterward. Preserve the existing alias,
model, and inference parameter mappings.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 9dfd125f-0134-4acb-8d3f-feca8dbfdd8b
📒 Files selected for processing (7)
web/packages/studio/src/components/CreateFilesetStart/StartOptionDetail.tsxweb/packages/studio/src/components/CreateFilesetStart/TemplateCard.tsxweb/packages/studio/src/components/CreateFilesetStart/templates.tsweb/packages/studio/src/routes/DataDesignerJobBuildRoute/columns.tsweb/packages/studio/src/routes/DataDesignerJobBuildRoute/index.tsxweb/packages/studio/src/routes/DataDesignerJobBuildRoute/models.test.tsweb/packages/studio/src/routes/DataDesignerJobBuildRoute/models.ts
|
Add templates

Signed-off-by: Sean Teramae steramae@nvidia.com
Summary by CodeRabbit
New Features
UI Improvements