ci: move the studio CI tests into ci.yaml so that they can be required - #250
Merged
Conversation
Signed-off-by: Brooke Storm <brookes@nvidia.com>
crookedstorm
force-pushed
the
rollup-pr-ci/crookedstorm
branch
from
June 9, 2026 22:23
a2f7920 to
54c6ca3
Compare
Contributor
📝 WalkthroughWalkthroughConsolidates web CI jobs from ChangesCI Workflow Consolidation
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
|
Signed-off-by: Brooke Storm <brookes@nvidia.com>
crookedstorm
force-pushed
the
rollup-pr-ci/crookedstorm
branch
from
June 9, 2026 22:29
d68030e to
8510944
Compare
svvarom
self-requested a review
June 9, 2026 22:33
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yaml:
- Around line 399-402: The gating condition for web jobs uses
needs.changes.outputs.web-studio but your change-detection output currently
matches web/** (too broad), so update either the changes job that sets
outputs.web-studio to only be true for studio-specific paths (e.g., matches
web/studio/** or whatever studio path pattern you want) OR change the job
conditionals to use the correct output for general web changes vs studio-only
checks; specifically, fix the expression using needs.changes.outputs.web-studio
(the clause with github.event_name == 'workflow_dispatch' ||
needs.changes.outputs.web-studio == 'true') and all other occurrences
referencing needs.changes.outputs.web-studio (the additional gated web job
conditions) so studio-only jobs read a dedicated web-studio output and general
web jobs use the web output, preventing studio E2E/ci-status from running on
non-studio web changes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 3fc60b34-bef2-4c77-b7a8-730b564b4c25
📒 Files selected for processing (1)
.github/workflows/ci.yaml
mckornfield
approved these changes
Jun 9, 2026
svvarom
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should be a straightforward way to make the studio tests required for studio changes (only).
Summary by CodeRabbit
Chores
Documentation