chore(studio): simplify TypeScript and CI config - #150
Conversation
The root `web/tsconfig.json` had no `include` field, so tsserver applied it to every `**/*.ts(x)` under `web/` — producing false "missing globals" diagnostics in studio test files (vitest globals were missing from its `types`). Only `packages/scripts` extended it; every other package was already standalone. - Delete `web/tsconfig.json`; inline `packages/scripts/tsconfig.json` with only the fields it actually needs (it's Node CLI, no DOM/JSX). - Drop the redundant `web-scripts-check` CI job: it ran `pnpm --filter '@nemo/scripts' check:ci`, which is `pnpm typecheck`, which is already covered by `web-typecheck` running `typecheck` across every changed package. Remove the now-unused `check:ci` script and `web-scripts` output from the `changes` composite action. - Delete `web/ci/` — leftover GitLab CI fragments with no consumer. Signed-off-by: Alex Ray <alray@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (10)
💤 Files with no reviewable changes (9)
📝 WalkthroughWalkthroughThis PR removes scripts package CI checks from the studio workflow and consolidates GitHub Actions change detection. The composite action output is renamed from web-scripts to web-studio with updated path filters, the scripts check job is removed from studio-ci.yaml, and the scripts package's check:ci command and root tsconfig extension are removed. ChangesCI Infrastructure Consolidation
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
mckornfield
left a comment
There was a problem hiding this comment.
sadly I am not in the devops group lol
@mckornfield Noooo --- I just assumed you always had all of the super powers |
Summary
web/tsconfig.json. It had noincludefield, so tsserver was applying it to every**/*.ts(x)underweb/— producing false "missing globals" diagnostics in studio test files (itstypes: []overrode the per-package vitest types that should resolvedescribe/it/expect). Onlypackages/scriptsextended it; every other package was already standalone with its own correct config.packages/scripts/tsconfig.jsonwith only the fields it actually needs — dropslib: ["DOM", ...],jsx,paths, andallowJs(scripts is pure Node CLI), and the deadoutDir/rootDir/sourceMap(irrelevant undernoEmit).web-scripts-checkCI job. It ranpnpm --filter '@nemo/scripts' check:ci, which is literallypnpm typecheck— already covered byweb-typecheckrunningtypecheckacross every changed package. Also removed the now-deadcheck:ciscript and theweb-scriptsoutput/filter from thechangescomposite action.web/ci/— leftover GitLab CI fragments with no consumer (no root.gitlab-ci.yml, noinclude:references anywhere).Net: −267 / +14 lines.
Test plan
web-typecheckruns and passes for this PR (covers scripts via the changed-packages filter).web-lint,web-format,web-testpass.pnpm run --recursive --parallel --if-present typecheckfromweb/exits 0 across all packages (verified during implementation).packages/studio/src/**/*.test.tsx);describe/it/expectresolve with no "missing globals" diagnostics.Summary by CodeRabbit