Skip to content

chore(studio): simplify TypeScript and CI config - #150

Merged
aray12 merged 1 commit into
mainfrom
typecheck-simplify
Jun 3, 2026
Merged

chore(studio): simplify TypeScript and CI config#150
aray12 merged 1 commit into
mainfrom
typecheck-simplify

Conversation

@aray12

@aray12 aray12 commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Delete web/tsconfig.json. It had no include field, so tsserver was applying it to every **/*.ts(x) under web/ — producing false "missing globals" diagnostics in studio test files (its types: [] overrode the per-package vitest types that should resolve describe/it/expect). Only packages/scripts extended it; every other package was already standalone with its own correct config.
  • Inline packages/scripts/tsconfig.json with only the fields it actually needs — drops lib: ["DOM", ...], jsx, paths, and allowJs (scripts is pure Node CLI), and the dead outDir/rootDir/sourceMap (irrelevant under noEmit).
  • Drop the redundant web-scripts-check CI job. It ran pnpm --filter '@nemo/scripts' check:ci, which is literally pnpm typecheck — already covered by web-typecheck running typecheck across every changed package. Also removed the now-dead check:ci script and the web-scripts output/filter from the changes composite action.
  • Delete web/ci/ — leftover GitLab CI fragments with no consumer (no root .gitlab-ci.yml, no include: references anywhere).

Net: −267 / +14 lines.

Test plan

  • CI: web-typecheck runs and passes for this PR (covers scripts via the changed-packages filter).
  • CI: web-lint, web-format, web-test pass.
  • Locally: pnpm run --recursive --parallel --if-present typecheck from web/ exits 0 across all packages (verified during implementation).
  • LSP smoke check: open a studio test file (e.g. anything under packages/studio/src/**/*.test.tsx); describe/it/expect resolve with no "missing globals" diagnostics.

Summary by CodeRabbit

  • Chores
    • Reorganized CI pipeline configuration to consolidate web package categories and remove outdated release candidate tagging logic.
    • Updated build and TypeScript configuration files to streamline development setup.

The root `web/tsconfig.json` had no `include` field, so tsserver
applied it to every `**/*.ts(x)` under `web/` — producing false
"missing globals" diagnostics in studio test files (vitest globals
were missing from its `types`). Only `packages/scripts` extended it;
every other package was already standalone.

- Delete `web/tsconfig.json`; inline `packages/scripts/tsconfig.json`
  with only the fields it actually needs (it's Node CLI, no DOM/JSX).
- Drop the redundant `web-scripts-check` CI job: it ran
  `pnpm --filter '@nemo/scripts' check:ci`, which is `pnpm typecheck`,
  which is already covered by `web-typecheck` running `typecheck`
  across every changed package. Remove the now-unused `check:ci`
  script and `web-scripts` output from the `changes` composite action.
- Delete `web/ci/` — leftover GitLab CI fragments with no consumer.

Signed-off-by: Alex Ray <alray@nvidia.com>
@aray12
aray12 requested review from a team as code owners June 2, 2026 23:41
@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d2f45023-7ff3-4d88-aa4e-c8a02c0f475f

📥 Commits

Reviewing files that changed from the base of the PR and between 8e65012 and 05f4e35.

📒 Files selected for processing (10)
  • .github/actions/changes/action.yaml
  • .github/workflows/studio-ci.yaml
  • web/ci/node.yml
  • web/ci/packages/common.yml
  • web/ci/packages/scripts.yml
  • web/ci/packages/studio.yml
  • web/ci/scripts/fetch-rc-tags.sh
  • web/packages/scripts/package.json
  • web/packages/scripts/tsconfig.json
  • web/tsconfig.json
💤 Files with no reviewable changes (9)
  • web/tsconfig.json
  • web/ci/packages/common.yml
  • web/packages/scripts/package.json
  • web/ci/scripts/fetch-rc-tags.sh
  • web/ci/node.yml
  • .github/actions/changes/action.yaml
  • web/ci/packages/scripts.yml
  • .github/workflows/studio-ci.yaml
  • web/ci/packages/studio.yml

📝 Walkthrough

Walkthrough

This PR removes scripts package CI checks from the studio workflow and consolidates GitHub Actions change detection. The composite action output is renamed from web-scripts to web-studio with updated path filters, the scripts check job is removed from studio-ci.yaml, and the scripts package's check:ci command and root tsconfig extension are removed.

Changes

CI Infrastructure Consolidation

Layer / File(s) Summary
GitHub Actions output refactoring to web-studio
.github/actions/changes/action.yaml
The composite action's output is renamed from web-scripts to web-studio and the dorny/paths-filter configuration switches path matching from web/packages/scripts/** to web/packages/studio/**.
Workflow job and scripts package cleanup
.github/workflows/studio-ci.yaml, web/packages/scripts/package.json, web/packages/scripts/tsconfig.json
The web-scripts-check job and its output are removed from the studio workflow. The scripts package loses its check:ci script and its tsconfig.json is refactored to a standalone configuration with explicit compiler options instead of extending the root config.

Suggested reviewers

  • dmariali
  • htolentino-nvidia
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Title directly summarizes the main changes: removing TypeScript config duplication and CI jobs to simplify the build setup.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch typecheck-simplify

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 18438/24423 75.5% 62.0%
Integration Tests 11882/23200 51.2% 26.4%

@mckornfield mckornfield left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sadly I am not in the devops group lol

@aray12

aray12 commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

sadly I am not in the devops group lol

@mckornfield Noooo --- I just assumed you always had all of the super powers

@aray12
aray12 requested a review from philipmattingly June 3, 2026 19:06
@aray12
aray12 added this pull request to the merge queue Jun 3, 2026
Merged via the queue into main with commit a505f33 Jun 3, 2026
38 checks passed
@aray12
aray12 deleted the typecheck-simplify branch June 25, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants