Skip to content

fix(studio): Regen SDK schema without duplicate operations - #220

Merged
marcusds merged 2 commits into
mainfrom
steramae/fix-overlap-sdk-override
Jun 9, 2026
Merged

fix(studio): Regen SDK schema without duplicate operations#220
marcusds merged 2 commits into
mainfrom
steramae/fix-overlap-sdk-override

Conversation

@steramae-nvidia

@steramae-nvidia steramae-nvidia commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Tests

    • Added extensive coverage for job-subtype routing, including noun-first naming shapes and data-designer naming stability across create/list/cancel flows.
  • Improvements

    • Refined API operation naming so resources are disambiguated more reliably (better, more consistent operation names).
    • Switched data-designer job flows to use the "create jobs" variant — listing, cancellation, deletion reset logic, job details, and artifact retrieval now follow the create-jobs path for consistency.

Signed-off-by: Sean Teramae <steramae@nvidia.com>
@steramae-nvidia
steramae-nvidia requested review from a team as code owners June 8, 2026 23:43
@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e867d0f7-136f-4801-bdf7-a7ac87a68fb2

📥 Commits

Reviewing files that changed from the base of the PR and between 9b81284 and 6e230e1.

📒 Files selected for processing (2)
  • web/packages/sdk/orval/operationNameOverride.test.ts
  • web/packages/sdk/orval/operationNameOverride.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • web/packages/sdk/orval/operationNameOverride.ts

📝 Walkthrough

Walkthrough

Rewrites path qualification to disambiguate noun-first job-subtype routes and updates Data Designer UI components to use the "create jobs" API variants (list, get, cancel, results, delete). Table rendering, filtering, and polling behaviors are unchanged.

Changes

Job Subtype API Naming and Integration

Layer / File(s) Summary
Operation Name Override for Job Subtypes
web/packages/sdk/orval/operationNameOverride.ts, web/packages/sdk/orval/operationNameOverride.test.ts
qualifyResource singularizes all path words and implements "noun-first" reordering and subtype filtering; operationNameOverride updated to new signature. Tests add noun-first job-subtype collection coverage and create-subtype deduplication checks.
Delete Modal Create Jobs Integration
web/packages/studio/src/components/dataViews/DataDesignerJobsDataView/DeleteJobModal.tsx
Imports and delete mutation switched to useDataDesignerDeleteCreateJob and getDataDesignerListCreateJobsQueryKey; mutation resets create-jobs query on success.
Jobs List View Create Jobs Integration
web/packages/studio/src/components/dataViews/DataDesignerJobsDataView/index.tsx
Replaces list and cancel hooks with useDataDesignerListCreateJobs and useDataDesignerCancelCreateJob; cancel mutation resets create-jobs cache; table data now from useDataDesignerListCreateJobs.
Job Details Route Create Jobs Integration
web/packages/studio/src/routes/DataDesignerJobDetailsRoute/index.tsx
Job fetch hook replaced with useDataDesignerGetCreateJob; refetch interval/config preserved.
Job Output Fileset Create Jobs Integration
web/packages/studio/src/routes/DataDesignerJobDetailsRoute/JobOutputFilesetSection.tsx
Artifacts/results hook switched to useDataDesignerListCreateJobResults; terminal-state polling unchanged.

Possibly related PRs

Suggested reviewers

  • marcusds
  • yamini
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the primary change: regenerating SDK schema to eliminate duplicate operations. This directly aligns with the core modifications (qualifyResource rewrite, operationNameOverride updates, and schema regeneration across data-designer components).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch steramae/fix-overlap-sdk-override

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 18844/24899 75.7% 62.2%
Integration Tests 12026/23587 51.0% 26.2%

Signed-off-by: Sean Teramae <steramae@nvidia.com>
@steramae-nvidia
steramae-nvidia requested a review from marcusds June 9, 2026 00:00
@marcusds
marcusds added this pull request to the merge queue Jun 9, 2026
Merged via the queue into main with commit 9a6aba7 Jun 9, 2026
40 checks passed
@steramae-nvidia
steramae-nvidia deleted the steramae/fix-overlap-sdk-override branch July 24, 2026 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants