Skip to content

fix: generate subtype routes with distinct names - #219

Merged
mckornfield merged 1 commit into
mainfrom
fix-breaking-studio-sdk-names/mck
Jun 8, 2026
Merged

fix: generate subtype routes with distinct names#219
mckornfield merged 1 commit into
mainfrom
fix-breaking-studio-sdk-names/mck

Conversation

@mckornfield

@mckornfield mckornfield commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

Release Notes

  • Improvements

    • SDK cache invalidation now includes additional generator files to trigger proper regeneration when needed
    • Agent job operation naming enhanced with improved subtype qualification
  • Tests

    • Added test coverage for operation name mapping across multiple agent job routes

@mckornfield
mckornfield requested review from a team as code owners June 8, 2026 23:26
@mckornfield
mckornfield requested a review from marcusds June 8, 2026 23:26
Signed-off-by: Matt Kornfield <mkornfield@nvidia.com>
@mckornfield
mckornfield force-pushed the fix-breaking-studio-sdk-names/mck branch from 1bc9625 to 7f65729 Compare June 8, 2026 23:27
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 18844/24899 75.7% 62.2%
Integration Tests 12026/23587 51.0% 26.2%

@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 968bcead-c9e8-482e-aaad-5040a7ebb7a3

📥 Commits

Reviewing files that changed from the base of the PR and between 39b3283 and 7f65729.

📒 Files selected for processing (3)
  • web/packages/sdk/generateAll.ts
  • web/packages/sdk/orval/operationNameOverride.test.ts
  • web/packages/sdk/orval/operationNameOverride.ts

📝 Walkthrough

Walkthrough

SDK operation name generation now qualifies agent job routes with service-aware subtype reordering. A new qualifyJobSubtypeResource helper extracts and reorders job-shaped path segments for agents service routes. qualifyResource accepts service and prioritizes the new job-subtype logic. Tests validate data designer and agent job operation name mappings. Build cache source files are expanded to invalidate when generator dependencies change.

Changes

Job Operation Name Overrides for Agents Service

Layer / File(s) Summary
Job subtype qualification logic
web/packages/sdk/orval/operationNameOverride.ts
New qualifyJobSubtypeResource helper detects and reorders path subtypes for agents service job routes. qualifyResource now accepts service parameter and prioritizes job-subtype qualification over prior logic. Call site updated to pass service for conditional qualification. Comment examples expanded to show agents operation name mappings.
Test coverage for job operations
web/packages/sdk/orval/operationNameOverride.test.ts
Added test cases verifying operation name overrides for data designer job creation and agent job subtypes (analyze, evaluate suite, optimize analyze, optimize skills) with assertions matching expected qualified names.
Build cache source files
web/packages/sdk/generateAll.ts
computeInputHash() expands generatorSources array to include orval config and generator modules, invalidating cache when these source files change instead of using stale sentinel.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: generate subtype routes with distinct names' directly matches the main change: updating operationId-to-operation-name generation to add agent-specific job subtype qualification and generate distinct operation names.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-breaking-studio-sdk-names/mck

Comment @coderabbitai help to get the list of available commands and usage tips.

@mckornfield
mckornfield requested a review from yamini June 8, 2026 23:27
@mckornfield
mckornfield added this pull request to the merge queue Jun 8, 2026
Merged via the queue into main with commit 892ebce Jun 8, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants