feat(studio): Action menu on fileset detail route - #185
Conversation
Signed-off-by: Sean Teramae <steramae@nvidia.com>
📝 WalkthroughWalkthroughAdds a FilesetActionMenu component (View/Edit/Delete) with edit/delete modals and deletion mutation + cache invalidation, integrates it into FilesetDetailRoute header (wires delete to navigate back), and adjusts FilesetCard layout and description rendering. ChangesFileset action menu and header integration
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web/packages/studio/src/components/FilesetActionMenu/index.tsx`:
- Around line 70-71: The FilesetActionMenu component uses hardcoded "Dataset"
labels for UI text (e.g., the tertiary Button aria-label and the menu item
labels), but this menu is used for any fileset type; update all occurrences in
the FilesetActionMenu JSX to use the neutral term "Fileset" instead of "Dataset"
(update the Button aria-label, the menu item labels rendered by the menu/menu
items in FilesetActionMenu, and any helper/constant strings inside that
component) so the UI is fileset-neutral while leaving component structure
(Button, EllipsisVertical, MenuItems) unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: f53c74e4-6cb7-4bc8-8efb-c627288a7e65
📒 Files selected for processing (3)
web/packages/studio/src/components/FilesetActionMenu/index.tsxweb/packages/studio/src/routes/FilesetDetailRoute/FilesetCard/index.tsxweb/packages/studio/src/routes/FilesetDetailRoute/index.tsx
|
Signed-off-by: Sean Teramae <steramae@nvidia.com>
…table-description-component Signed-off-by: Sean Teramae <steramae@nvidia.com>
…table-description-component Signed-off-by: Sean Teramae <steramae@nvidia.com>
There was a problem hiding this comment.
🧹 Nitpick comments (1)
web/packages/studio/src/routes/FilesetDetailRoute/FilesetCard/index.tsx (1)
59-82: Reconsider rawdivgrid for Foundations layout consistency
FilesetCarduses a plain<div className="grid ...">instead of the NVIDIA Foundations ReactGrid(which is used elsewhere inweb/packages/studio); switch toGrid/GridItemor keep this only if there’s a specific reason to avoid the design-system component.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@web/packages/studio/src/routes/FilesetDetailRoute/FilesetCard/index.tsx` around lines 59 - 82, FilesetCard currently uses a raw div with Tailwind grid classes for layout; replace that outer div with the design-system Grid/GridItem components to keep Foundations layout consistent. In the FilesetCard component, swap the container div (the element with className="grid w-full grid-cols-1 gap-density-xl pt-density-xl lg:grid-cols-3" and data-testid="fileset-card") for a Grid and wrap the two children sections in GridItem(s) (preserving the lg column spans currently applied to the first and second columns), ensuring ReadmeBody, FilesetMetadataPanel and conditional DatasetSamplePanel remain as children and that existing props (isFilesError, readmePath, parsed?.content/metadata, workspace, filesetName, files) are passed through unchanged. Ensure imports for Grid and GridItem from the Foundations library are added and remove the raw grid className usage.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@web/packages/studio/src/routes/FilesetDetailRoute/FilesetCard/index.tsx`:
- Around line 59-82: FilesetCard currently uses a raw div with Tailwind grid
classes for layout; replace that outer div with the design-system Grid/GridItem
components to keep Foundations layout consistent. In the FilesetCard component,
swap the container div (the element with className="grid w-full grid-cols-1
gap-density-xl pt-density-xl lg:grid-cols-3" and data-testid="fileset-card") for
a Grid and wrap the two children sections in GridItem(s) (preserving the lg
column spans currently applied to the first and second columns), ensuring
ReadmeBody, FilesetMetadataPanel and conditional DatasetSamplePanel remain as
children and that existing props (isFilesError, readmePath,
parsed?.content/metadata, workspace, filesetName, files) are passed through
unchanged. Ensure imports for Grid and GridItem from the Foundations library are
added and remove the raw grid className usage.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: e952bca5-5916-49f9-b5ef-5b641de4fbcb
📒 Files selected for processing (2)
web/packages/studio/src/routes/FilesetDetailRoute/FilesetCard/index.tsxweb/packages/studio/src/routes/FilesetDetailRoute/index.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
- web/packages/studio/src/routes/FilesetDetailRoute/index.tsx
This PR adds additional functionality to the fileset detail route to allow a user to handle additional actions from the Action Menu in the top right CTA. This includes editing the description or deleting the fileset.
Also
Summary by CodeRabbit
New Features
UI Improvements