Skip to content

fix(studio): add delete action menu to guardrail detail page header - #1114

Merged
aray12 merged 1 commit into
mainfrom
aastd-367-nemo-platformoss-040studiodoc-studio-guardrails-doc-claims
Aug 5, 2026
Merged

fix(studio): add delete action menu to guardrail detail page header#1114
aray12 merged 1 commit into
mainfrom
aastd-367-nemo-platformoss-040studiodoc-studio-guardrails-doc-claims

Conversation

@aray12

@aray12 aray12 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds a ⋯ actions menu to the GuardrailDetailRoute header with a single Delete action
  • On confirm, deletes the config and redirects to the guardrails list
  • Updates docs/studio/guardrails.mdx to reflect the new UX (menu instead of a standalone header button)

Test plan

  • Open a guardrail config detail page
  • Confirm the ⋯ menu appears in the header alongside the Save/Reset buttons
  • Click ⋯ → Delete, confirm the dialog, verify redirect to the guardrails list
  • Verify the deleted config no longer appears in the list
image image

Summary by CodeRabbit

  • New Features

    • Added a Delete action to guardrail detail pages.
    • Added a confirmation step with success and failure feedback.
    • Returns to the guardrails list after successful deletion.
  • Documentation

    • Updated deletion instructions to explain using the detail-page actions menu () before selecting Delete.

Adds a ⋯ actions menu to the GuardrailDetailRoute header containing a
Delete action. On confirm, deletes the config and redirects to the list.
Updates the guardrails doc to reflect the new UX (menu instead of a
standalone header button).

Signed-off-by: Alex Ray <alray@nvidia.com>
@aray12
aray12 requested review from a team as code owners August 5, 2026 22:17
@github-actions github-actions Bot added the feat label Aug 5, 2026
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Changes

Guardrail detail deletion

Layer / File(s) Summary
Confirmed deletion flow
web/packages/studio/src/routes/guardrails/GuardrailDetailRoute/GuardrailDetailActions.tsx
Adds a delete action with confirmation, API error handling, query invalidation, success or failure reporting, and navigation after deletion.
Detail header integration and documentation
web/packages/studio/src/routes/guardrails/GuardrailDetailRoute/index.tsx, docs/studio/guardrails.mdx
Adds the action to the detail-page header and updates the instructions to use the actions menu.

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant GuardrailDetailActions
  participant DeleteModal
  participant GuardrailAPI
  participant WorkspaceConfigurationQuery
  User->>GuardrailDetailActions: Select Delete
  GuardrailDetailActions->>DeleteModal: Open confirmation
  User->>DeleteModal: Confirm deletion
  DeleteModal->>GuardrailAPI: Delete guardrail
  GuardrailAPI-->>DeleteModal: Return result
  DeleteModal->>WorkspaceConfigurationQuery: Invalidate configuration query
  DeleteModal-->>User: Show success or failure
Loading

Possibly related PRs

Suggested reviewers: nakolean

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the added delete action menu on the guardrail detail page header.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch aastd-367-nemo-platformoss-040studiodoc-studio-guardrails-doc-claims

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

@aray12 aray12 changed the title feat(studio): add delete action menu to guardrail detail page header fix(studio): add delete action menu to guardrail detail page header Aug 5, 2026
@github-actions github-actions Bot added the fix label Aug 5, 2026
@aray12 aray12 removed the feat label Aug 5, 2026
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor
Suite Lines Covered Line Rate Branch Rate
Unit Tests 30786/39277 78.4% 62.8%
Integration Tests 18077/37229 48.6% 21.1%

@aray12
aray12 added this pull request to the merge queue Aug 5, 2026
Merged via the queue into main with commit 96cb643 Aug 5, 2026
60 checks passed
@aray12
aray12 deleted the aastd-367-nemo-platformoss-040studiodoc-studio-guardrails-doc-claims branch August 5, 2026 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants