build: remove FFmpeg from automodel to avoid unfixed CVE - #1167
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe Automodel GPU wheel group and base-builder context no longer include the FFmpeg VLM wheel. The base image no longer installs VLM media wheels or sets the TorchCodec video-reader override. The dependency patch and documentation now reflect the removed media dependencies. ChangesAutomodel VLM dependency removal
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docker/automodel/Dockerfile.nmp-automodel-base`:
- Around line 44-51: The unconditional opencv-python-headless dependency still
enters the text-training image despite excluding VLM/media extras. In
docker/automodel/Dockerfile.nmp-automodel-base lines 44-51, adjust the Automodel
dependency setup so OpenCV is not installed for the base text-training
environment, while preserving it for VLM usage if required; update the related
dependency/install handling at lines 164-166 accordingly. Update
docker/automodel/README.md line 88 to accurately describe the resulting image
behavior.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 6e0c9c60-6b7e-4e4a-8a41-8af2da2a81dd
📒 Files selected for processing (3)
docker-bake.hcldocker/automodel/Dockerfile.nmp-automodel-basedocker/automodel/README.md
💤 Files with no reviewable changes (1)
- docker-bake.hcl
|
Signed-off-by: Aaron Gabow <agabow@nvidia.com>
996983d to
2e7238d
Compare
Signed-off-by: Aaron Gabow <agabow@nvidia.com>
Summary
This change addresses multiple High CVEs in the nmp-automoel-training image that all relate to FFMpeg. The current version of FFMpeg (8.1.2) is the latest version of the 8.xx versions. There is a 9.0 release but underlying dependencies only document compability with 8.xx and libavcodec bumps between the releases. GPT thought it was safer to remove than upgrade. Since we aren't exposing VLM, fully removing seemed the better option.
Changes
Type of Change
Quality Gates
Verification
Targeted validation:
Summary by CodeRabbit
Bug Fixes
Documentation