chore(customizer): fix CVEs in RL image - #1150
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe RL image build updates ChangesRL image build
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docker-bake.hcl`:
- Line 103: Update the NEMO_RL_REF value in Dockerfile.nmp-rl-base to the
immutable SHA 1427564b347ee0a4b672182a8a98048ed2785217, matching the pinned
default in docker-bake.hcl, and remove the mutable nmp/customizer reference.
In `@docker/rl/Dockerfile.nmp-rl-base`:
- Around line 248-262: Update the PyNvVideoCodec CVE cleanup in the Docker build
to run after all prefetch operations, remove the package from any symlinked
prefetched virtual environments before cache deletion, and delete both cached
wheel archives and unpacked payloads under the package’s
*.data/data/external/ffmpeg location. Add an assertion after cleanup that no
PyNvVideoCodec FFmpeg payload remains.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 454852f9-028e-43dd-923b-afe9bff6795a
📒 Files selected for processing (3)
docker-bake.hcldocker/rl/Dockerfile.nmp-rl-basedocker/rl/README.md
💤 Files with no reviewable changes (1)
- docker/rl/README.md
87252be to
c8b3d92
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
Signed-off-by: anubhutiv <anubhutiv@nvidia.com>
Signed-off-by: anubhutiv <anubhutiv@nvidia.com>
c8b3d92 to
4ade415
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Summary
Fix CVEs for RL image
Changes
CVEs fixed:
av,opencv-python-headless,decord2from this wheel that RL specifically removes in pyproject.toml and in PRs, 3107 and 3339, both are in our RL fork, so there's essentially no use of it./opt/uv_cache/archive-v0/y7K6jcDvx-Obnh8H/PyNvVideoCodec/that is removedPyNvVideoCodec==2.0.4comes in from a pin from vllm and GRPO needs vllm, but removing PyNvVideoCodec from cache is safe because nothing on the DPO/GRPO path can reach itimport PyNvVideoCodecis function-local, insidedecode_frames_pynvvideocodec(), so it only executes if that backend is explicitly selected - https://github.com/vllm-project/vllm/blob/752a3a504485790a2e8491cacbb35c137339ad34/vllm/multimodal/video.py#L799opencvbackend - https://github.com/vllm-project/vllm/blob/752a3a504485790a2e8491cacbb35c137339ad34/vllm/envs.py#L83aiohttp3.14.2 bumped up to 3.14.3 in PR - chore: address cves soluwalana/RL#10cryptography48.0.1 bumped up to to 50.0.0 in PR - chore: address cves soluwalana/RL#10remaining can't be fixed:
grpc v1.82.0(needs 1.82.1) from/opt/uv_cache/archive-v0/Lt4dmx5C-VX-edr9/wandb/bin/wandb-core- already on the latest wandb (0.28.1); needs an upstream Go rebuildstdlib go1.26.4- samewandb-corebinary, same reason, latest wandb alreadygrpc v1.79.3(needs 1.82.1) comes from/opt/uv_cache/archive-v0/0zovx6DYaLJWcATd/mooncake/libetcd_wrapper.so- already on the latestmooncake-transfer-engine-cuda130.3.12.post1; no fix released yetstdlib go1.25.10from samelibetcd_wrapper.so- but we're on latest mooncake alreadyflash-attn 2.8.1- no fix yetpython-build-standaloneproject, and that project has not published the latest version yet, it tops out at 3.13.14.Type of Change
Quality Gates
Verification
Signed-off-by:traileruv run pre-commit run -apasses, or any blocked checks are identified belowTargeted validation:
Summary by CodeRabbit
Chores
Documentation