feat: add NVSkills CI request workflow - #103
Conversation
Signed-off-by: Nick Goncharenko <ngoncharenko@nvidia.com>
c705cba to
b9e93f9
Compare
|
8e446dd to
b9e93f9
Compare
|
/nvskills-ci |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds a GitHub Actions workflow that triggers NVSkills validation on ChangesNVSkills CI Workflow Integration
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/request-nvskills-ci.yml:
- Around line 11-13: The workflow condition that dispatches on the issue_comment
currently allows any commenter to trigger the job via
startsWith(github.event.comment.body, '/nvskills-ci'); update the job's if:
condition to also check github.event.comment.author_association against an
allowlist (e.g., oneOf(github.event.comment.author_association,
'OWNER','MEMBER','COLLABORATOR')) so only trusted associations can trigger it,
and replace the reusable workflow ref "uses:
NVIDIA/skills/.github/workflows/team-request.yml@main" with a pinned immutable
ref (a commit SHA or immutable tag) to prevent supply-chain drift.
- Line 20: The workflow currently references the reusable workflow tag
"NVIDIA/skills/.github/workflows/team-request.yml@main" which is mutable; update
that reference to a specific immutable commit SHA (replace "`@main`" with the
exact commit SHA of the upstream repo) so the reusable workflow cannot change
unexpectedly, and verify the dispatcher token/scope still functions with the
pinned commit after updating the reference.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 88242345-cdda-47eb-bf0b-6b40fcee7993
📒 Files selected for processing (1)
.github/workflows/request-nvskills-ci.yml
Signed-off-by: Nick Goncharenko <ngoncharenko@nvidia.com>
Summary
Add the GitHub Actions workflow that connects this repo to NVIDIA NVSkills validation. Reviewers can comment
/nvskills-cion a PR to dispatch the team validation workflow; the workflow also accepts signature commits from the NVSkills bot.Linear
https://linear.app/nvidia/issue/AALGO-231/skills-publishing
Why
NeMo Platform skills is being onboarded to the NVSkills catalog (
NVIDIA/skills). This workflow is the product-repo side of that integration — it does not publish skills by itself, but triggers validation runs against the catalog pipeline.Changes
.github/workflows/request-nvskills-ci.yml— reusable workflow dispatch toNVIDIA/skills/.github/workflows/team-request.yml@mainTest plan
/nvskills-ciand verify dispatch (after secret is configured)Related
Summary by CodeRabbit