Add mixtral to mapping for vocab in trt server#7
Merged
Conversation
Signed-off-by: Igor Gitman <igitman@nvidia.com>
dgtm777
pushed a commit
that referenced
this pull request
Apr 2, 2025
Signed-off-by: Igor Gitman <igitman@nvidia.com>
wasiahmad
pushed a commit
that referenced
this pull request
Oct 1, 2025
Signed-off-by: Igor Gitman <igitman@nvidia.com>
gwarmstrong
added a commit
to gwarmstrong/NeMo-Skills
that referenced
this pull request
Feb 14, 2026
Rewrite the dependency boundary section to: - Define core as "everything needed for inference + evaluation" (not just PythonTool-specific deps) - Remove references to deleted requirements/main.txt - Clarify that all benchmark evaluator deps go to core until JIT install is implemented - Improve dataset module separation guidance (pipeline = cluster I/O only, core = all local logic) - Add note about summarize-results refactor (issue NVIDIA-NeMo#779) Addresses review comments NVIDIA-NeMo#3, NVIDIA-NeMo#4, NVIDIA-NeMo#6, NVIDIA-NeMo#7 on PR NVIDIA-NeMo#1229. Signed-off-by: George Armstrong <georgea@nvidia.com>
gwarmstrong
added a commit
to gwarmstrong/NeMo-Skills
that referenced
this pull request
Feb 14, 2026
Refactor pipeline/dataset.py so it ONLY handles cluster I/O (SSH downloads, mount path resolution) and delegates all local import/resolution logic to core's dataset/utils.py. Key changes: - Extract cluster-specific loading into _get_cluster_dataset_module() - For local extra_datasets fallback, delegate to core instead of reimplementing add_to_path + import_module - For non-cluster cases, delegate entirely to core from the start - Remove duplicated local import logic that was parallel to core Addresses review comment NVIDIA-NeMo#7 on PR NVIDIA-NeMo#1229. Signed-off-by: George Armstrong <georgea@nvidia.com>
gwarmstrong
added a commit
to gwarmstrong/NeMo-Skills
that referenced
this pull request
Feb 17, 2026
Pipeline no longer calls importlib.import_module or add_to_path directly — all import/module-resolution logic lives in core. Pipeline's only responsibilities are now: - Local executor: unmount paths via get_unmounted_path, then delegate to core, then map returned paths back to mounted form - Remote executor: SSH download via cluster_download_file for custom data_dir or cluster-type extra_datasets Addresses review comment NVIDIA-NeMo#7 on PR NVIDIA-NeMo#1229. Signed-off-by: George Armstrong <georgea@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.