Switch trtllm slurm scripts to use mpirun directly for better stability#6
Merged
Switch trtllm slurm scripts to use mpirun directly for better stability#6
Conversation
Signed-off-by: Igor Gitman <igitman@nvidia.com>
Signed-off-by: Igor Gitman <igitman@nvidia.com>
dgtm777
pushed a commit
that referenced
this pull request
Apr 2, 2025
…ty (#6) Signed-off-by: Igor Gitman <igitman@nvidia.com>
wasiahmad
pushed a commit
that referenced
this pull request
Oct 1, 2025
…ty (#6) Signed-off-by: Igor Gitman <igitman@nvidia.com>
gwarmstrong
added a commit
to gwarmstrong/NeMo-Skills
that referenced
this pull request
Feb 14, 2026
Per review feedback: all benchmark-specific packages should go to core for now since JIT install is not yet implemented. Previously only PythonTool-specific deps were in core while benchmark deps like datasets, sacrebleu, faiss-cpu, etc. were only in main.txt. This led to an inconsistent boundary where math grader deps were in core but BFCL deps were not, despite both being benchmark-specific. Addresses review comments #1, NVIDIA-NeMo#4, NVIDIA-NeMo#6 on PR NVIDIA-NeMo#1229. Signed-off-by: George Armstrong <georgea@nvidia.com>
gwarmstrong
added a commit
to gwarmstrong/NeMo-Skills
that referenced
this pull request
Feb 14, 2026
Rewrite the dependency boundary section to: - Define core as "everything needed for inference + evaluation" (not just PythonTool-specific deps) - Remove references to deleted requirements/main.txt - Clarify that all benchmark evaluator deps go to core until JIT install is implemented - Improve dataset module separation guidance (pipeline = cluster I/O only, core = all local logic) - Add note about summarize-results refactor (issue NVIDIA-NeMo#779) Addresses review comments NVIDIA-NeMo#3, NVIDIA-NeMo#4, NVIDIA-NeMo#6, NVIDIA-NeMo#7 on PR NVIDIA-NeMo#1229. Signed-off-by: George Armstrong <georgea@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need this to avoid errors on some slurm configurations.