Skip to content

fix: restore SIGINT handler in sandbox shell worker to prevent session resets #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gwarmstrong merged 2 commits into from
Mar 12, 2026
Merged

fix: restore SIGINT handler in sandbox shell worker to prevent session resets #1302

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31045ae
fix: restore SIGINT handler in sandbox shell worker to prevent sessio…
gwarmstrong Mar 11, 2026
5e54bae
Merge branch 'main' into georgea/fix-sandbox-interruption-handling
gwarmstrong Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions nemo_skills/code_execution/local_sandbox/local_sandbox_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,11 @@ def __init__(self, family=-1, type=-1, proto=-1, fileno=None):
socket_module.socket = BlockedSocket # Blocks: import socket; socket.socket()

shell = TerminalInteractiveShell()
# TerminalInteractiveShell installs a SIGINT handler that calls sys.exit(0)
# instead of raising KeyboardInterrupt when _executing is False (which is
# the case when run_cell is called programmatically). Restore the default
# handler so SIGINT raises KeyboardInterrupt and our except clause catches it.
signal.signal(signal.SIGINT, signal.SIG_DFL)
try:
while True:
try:
Expand Down Expand Up @@ -203,7 +208,7 @@ def stop_shell(self, shell_id):
proc.terminate()
proc.join(timeout=2.0)

def run_cell(self, shell_id, code, timeout=1.0, grace=0.5, traceback_verbosity="Plain"):
def run_cell(self, shell_id, code, timeout=1.0, grace=2.0, traceback_verbosity="Plain"):
"""
Execute `code` on shell `shell_id`.
- timeout: seconds to wait for normal completion
Expand Down Expand Up @@ -427,7 +432,7 @@ def execute_ipython_session(generated_code, session_id, timeout=30, traceback_ve

# Execute code using ShellManager with proper timeout and cancellation
result = shell_manager.run_cell(
session_id, generated_code, timeout=timeout, grace=0.5, traceback_verbosity=traceback_verbosity
session_id, generated_code, timeout=timeout, grace=2.0, traceback_verbosity=traceback_verbosity
)

# Determine if this is effectively a new session
Expand Down
Loading