fix: restore SIGINT handler in sandbox shell worker to prevent session resets

[gwarmstrong]

Summary

• Restore default SIGINT handler after TerminalInteractiveShell() creation so timeouts raise KeyboardInterrupt instead of sys.exit(0)

[coderabbitai]

📝 Walkthrough

Walkthrough

Modifies ShellManager.run_cell to restore default SIGINT handler in shell process, enabling KeyboardInterrupt handling during programmatic execution. Extends the default grace period for interrupt handling from 0.5 seconds to 2.0 seconds and propagates this change through execute_ipython_session.

Changes

Cohort / File(s)	Summary
Shell Interrupt Handling nemo_skills/code_execution/local_sandbox/local_sandbox_server.py	Restores default SIGINT handler in shell process for proper KeyboardInterrupt behavior. Changes default grace parameter from 0.5 to 2.0 seconds in ShellManager.run_cell method signature. Propagates updated grace period value in execute_ipython_session.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The PR title clearly and specifically summarizes the main change: restoring the SIGINT handler in the sandbox shell to prevent session resets, which directly addresses the core problem described in the PR objectives.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch georgea/fix-sandbox-interruption-handling

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

nemo_skills/code_execution/local_sandbox/local_sandbox_server.py (1)

435-435: Consider removing redundant grace=2.0 parameter.

Since grace=2.0 is now the default in run_cell (line 211), explicitly passing it here is redundant. However, keeping it explicit does document the intended behavior and guards against future default changes.

♻️ Optional: Remove redundant parameter

         result = shell_manager.run_cell(
-            session_id, generated_code, timeout=timeout, grace=2.0, traceback_verbosity=traceback_verbosity
+            session_id, generated_code, timeout=timeout, traceback_verbosity=traceback_verbosity
         )

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@nemo_skills/code_execution/local_sandbox/local_sandbox_server.py` at line
435, The call that invokes run_cell (passing session_id, generated_code,
timeout=timeout, grace=2.0, traceback_verbosity=traceback_verbosity) is
redundantly specifying grace=2.0; remove the explicit grace=2.0 argument so the
call becomes session_id, generated_code, timeout=timeout,
traceback_verbosity=traceback_verbosity and rely on run_cell's default grace
(set at its definition), leaving all other parameters and behavior unchanged.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@nemo_skills/code_execution/local_sandbox/local_sandbox_server.py`:
- Line 435: The call that invokes run_cell (passing session_id, generated_code,
timeout=timeout, grace=2.0, traceback_verbosity=traceback_verbosity) is
redundantly specifying grace=2.0; remove the explicit grace=2.0 argument so the
call becomes session_id, generated_code, timeout=timeout,
traceback_verbosity=traceback_verbosity and rely on run_cell's default grace
(set at its definition), leaving all other parameters and behavior unchanged.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: dd20afd4-ed23-474c-aee8-aca63cb08593

📥 Commits

Reviewing files that changed from the base of the PR and between 005cd03 and 31045ae.

📒 Files selected for processing (1)

• nemo_skills/code_execution/local_sandbox/local_sandbox_server.py

[i-vainn]

Thanks George! Looks good; fixed issues in our setup. Please update with main and let's merge.